* [PATCH] zd1211rw: ignore unknown regulatory domain.
@ 2010-06-13 5:52 Kouhei Sutou
2010-06-13 20:23 ` Luis R. Rodriguez
0 siblings, 1 reply; 10+ messages in thread
From: Kouhei Sutou @ 2010-06-13 5:52 UTC (permalink / raw
To: linux-wireless
[-- Attachment #1: Type: Text/Plain, Size: 1570 bytes --]
Hi,
I'm using PLANEX GW-US54GXS (2019:5303) and it works with
the attached patch. Could you consider to merge the attached
patch?
Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
a regulatory domain reported by GW-US54GXS (0x49).
Solutions:
(1) add a new regulatory domain (0x49). Here is a patch to
use the approach:
----
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c
index 163a8a0..faf45f1 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c
@@ -43,6 +43,7 @@ static struct zd_reg_alpha2_map reg_alpha2_map[] = {
{ ZD_REGDOMAIN_ETSI, "DE" }, /* Generic ETSI, use most restrictive */
{ ZD_REGDOMAIN_JAPAN, "JP" },
{ ZD_REGDOMAIN_JAPAN_ADD, "JP" },
+ { ZD_REGDOMAIN_JAPAN_GW_US54GXS, "JP" },
{ ZD_REGDOMAIN_SPAIN, "ES" },
{ ZD_REGDOMAIN_FRANCE, "FR" },
};
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.h b/drivers/net/wireless/zd1211rw/zd_mac.h
index 630c298..7ab19d5 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.h
+++ b/drivers/net/wireless/zd1211rw/zd_mac.h
@@ -214,6 +214,7 @@ struct zd_mac {
#define ZD_REGDOMAIN_FRANCE 0x32
#define ZD_REGDOMAIN_JAPAN_ADD 0x40
#define ZD_REGDOMAIN_JAPAN 0x41
+#define ZD_REGDOMAIN_JAPAN_GW_US54GXS 0x49
enum {
MIN_CHANNEL24 = 1,
----
(2) just ignore unknown regulatory domain. (the attached
patch approach)
It seems that (2) is a better solution because we can change
regulatory domain by CRDA (*).
(*) http://wireless.kernel.org/en/developers/Regulatory/CRDA
Thanks,
--
kou
[-- Attachment #2: 0001-zd1211rw-ignore-unknown-regulatory-domain.patch --]
[-- Type: Text/X-Patch, Size: 1353 bytes --]
>From c230320db45e9261814b69e7596d4f641c3c8aad Mon Sep 17 00:00:00 2001
From: Kouhei Sutou <kou@clear-code.com>
Date: Sun, 13 Jun 2010 14:37:54 +0900
Subject: [PATCH] zd1211rw: ignore unknown regulatory domain.
Zd1211rw supports 7 regulatory domains (ZD_REGDOMAIN_*) but they
aren't cover all regulatory domains. For example, PLANEX
GW-US54GXS (2019:5303) uses 0x49 for its regulatory domain.
If zd1211rw can't convert a regulatory domain to alpha2, it
reports that initialization is failed. But we can change
regulatory domain by another way (CRDA). So it seems that zd1211rw
can ignore unknown regulatory domain.
Signed-off-by: Kouhei Sutou <kou@clear-code.com>
---
drivers/net/wireless/zd1211rw/zd_mac.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c
index 163a8a0..8b04d93 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c
@@ -198,11 +198,9 @@ int zd_mac_init_hw(struct ieee80211_hw *hw)
if (r)
goto disable_int;
- r = zd_reg2alpha2(mac->regdomain, alpha2);
- if (r)
- goto disable_int;
+ if (zd_reg2alpha2(mac->regdomain, alpha2))
+ r = regulatory_hint(hw->wiphy, alpha2);
- r = regulatory_hint(hw->wiphy, alpha2);
disable_int:
zd_chip_disable_int(chip);
out:
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-13 5:52 [PATCH] zd1211rw: ignore unknown regulatory domain Kouhei Sutou
@ 2010-06-13 20:23 ` Luis R. Rodriguez
2010-06-15 14:25 ` Kouhei Sutou
2010-06-15 17:40 ` Gábor Stefanik
0 siblings, 2 replies; 10+ messages in thread
From: Luis R. Rodriguez @ 2010-06-13 20:23 UTC (permalink / raw
To: Kouhei Sutou, Stephen Chen, David Quan; +Cc: linux-wireless, Michael Green
Note: this e-mail is on a public mailing list!
On Sat, Jun 12, 2010 at 10:52 PM, Kouhei Sutou <kou@clear-code.com> wrote:
> Hi,
>
> I'm using PLANEX GW-US54GXS (2019:5303) and it works with
> the attached patch. Could you consider to merge the attached
> patch?
>
> Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
> a regulatory domain reported by GW-US54GXS (0x49).
>
> Solutions:
>
> (1) add a new regulatory domain (0x49). Here is a patch to
> use the approach:
Stephen, David, does 0x49 map to JP for zd1211 ? Are there other ones?
Here is our list so far:
#define ZD_REGDOMAIN_FCC 0x10
#define ZD_REGDOMAIN_IC 0x20
#define ZD_REGDOMAIN_ETSI 0x30
#define ZD_REGDOMAIN_SPAIN 0x31
#define ZD_REGDOMAIN_FRANCE 0x32
#define ZD_REGDOMAIN_JAPAN_ADD 0x40
#define ZD_REGDOMAIN_JAPAN 0x41
This is what they map to:
static struct zd_reg_alpha2_map reg_alpha2_map[] = {
{ ZD_REGDOMAIN_FCC, "US" },
{ ZD_REGDOMAIN_IC, "CA" },
{ ZD_REGDOMAIN_ETSI, "DE" }, /* Generic ETSI, use most restrictive */
{ ZD_REGDOMAIN_JAPAN, "JP" },
{ ZD_REGDOMAIN_JAPAN_ADD, "JP" },
{ ZD_REGDOMAIN_SPAIN, "ES" },
{ ZD_REGDOMAIN_FRANCE, "FR" },
};
Kouhei, if no regulatory domain is found, instead we should world
roam, we cannot allow letting the user change regulatory domains at
their whim. We can, however let them choose one to help compliance,
but you can only help compliance once you know your actual regulatory
domain.
Luis
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-13 20:23 ` Luis R. Rodriguez
@ 2010-06-15 14:25 ` Kouhei Sutou
2010-06-15 15:22 ` Luis R. Rodriguez
2010-06-15 17:40 ` Gábor Stefanik
1 sibling, 1 reply; 10+ messages in thread
From: Kouhei Sutou @ 2010-06-15 14:25 UTC (permalink / raw
To: mcgrof; +Cc: Stephen.Chen, David.Quan, linux-wireless, Michael.Green
Hi,
In <AANLkTinEMAQu33Tlv81-Cdx9fLZK-a-7uJlbAo7te2_w@mail.gmail.com>
"Re: [PATCH] zd1211rw: ignore unknown regulatory domain." on Sun, 13 Jun 2010 13:23:20 -0700,
"Luis R. Rodriguez" <mcgrof@gmail.com> wrote:
>> I'm using PLANEX GW-US54GXS (2019:5303) and it works with
>> the attached patch. Could you consider to merge the attached
>> patch?
>>
>> Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
>> a regulatory domain reported by GW-US54GXS (0x49).
>>
>> Solutions:
>>
>> (1) add a new regulatory domain (0x49). Here is a patch to
>> use the approach:
>
> Stephen, David, does 0x49 map to JP for zd1211 ? Are there other ones?
> Here is our list so far:
...
> Kouhei, if no regulatory domain is found, instead we should world
> roam, we cannot allow letting the user change regulatory domains at
> their whim. We can, however let them choose one to help compliance,
> but you can only help compliance once you know your actual regulatory
> domain.
Luis, thanks for your input.
It seems that we can't use GW-US54GXS until 0x49 regulatory
domain is registered to zd1211rw. Is it right?
If it is right, what I can do for GW-US54GXS? Should I wait
a response from Stephen and/or David?
Thanks,
--
kou
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-15 14:25 ` Kouhei Sutou
@ 2010-06-15 15:22 ` Luis R. Rodriguez
2010-06-16 12:55 ` Kouhei Sutou
0 siblings, 1 reply; 10+ messages in thread
From: Luis R. Rodriguez @ 2010-06-15 15:22 UTC (permalink / raw
To: Kouhei Sutou; +Cc: Stephen.Chen, David.Quan, linux-wireless, Michael.Green
On Tue, Jun 15, 2010 at 7:25 AM, Kouhei Sutou <kou@clear-code.com> wrote:
> Hi,
>
> In <AANLkTinEMAQu33Tlv81-Cdx9fLZK-a-7uJlbAo7te2_w@mail.gmail.com>
> "Re: [PATCH] zd1211rw: ignore unknown regulatory domain." on Sun, 13 Jun 2010 13:23:20 -0700,
> "Luis R. Rodriguez" <mcgrof@gmail.com> wrote:
>
>>> I'm using PLANEX GW-US54GXS (2019:5303) and it works with
>>> the attached patch. Could you consider to merge the attached
>>> patch?
>>>
>>> Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
>>> a regulatory domain reported by GW-US54GXS (0x49).
>>>
>>> Solutions:
>>>
>>> (1) add a new regulatory domain (0x49). Here is a patch to
>>> use the approach:
>>
>> Stephen, David, does 0x49 map to JP for zd1211 ? Are there other ones?
>> Here is our list so far:
> ...
>> Kouhei, if no regulatory domain is found, instead we should world
>> roam, we cannot allow letting the user change regulatory domains at
>> their whim. We can, however let them choose one to help compliance,
>> but you can only help compliance once you know your actual regulatory
>> domain.
>
> Luis, thanks for your input.
> It seems that we can't use GW-US54GXS until 0x49 regulatory
> domain is registered to zd1211rw. Is it right?
>
> If it is right, what I can do for GW-US54GXS? Should I wait
> a response from Stephen and/or David?
We spoke and 0x49 - > JP is ok, can you send a patch for that?
Luis
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-13 20:23 ` Luis R. Rodriguez
2010-06-15 14:25 ` Kouhei Sutou
@ 2010-06-15 17:40 ` Gábor Stefanik
1 sibling, 0 replies; 10+ messages in thread
From: Gábor Stefanik @ 2010-06-15 17:40 UTC (permalink / raw
To: Luis R. Rodriguez
Cc: Kouhei Sutou, Stephen Chen, David Quan, linux-wireless,
Michael Green
On Sun, Jun 13, 2010 at 10:23 PM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> Note: this e-mail is on a public mailing list!
>
> On Sat, Jun 12, 2010 at 10:52 PM, Kouhei Sutou <kou@clear-code.com> wrote:
>> Hi,
>>
>> I'm using PLANEX GW-US54GXS (2019:5303) and it works with
>> the attached patch. Could you consider to merge the attached
>> patch?
>>
>> Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
>> a regulatory domain reported by GW-US54GXS (0x49).
>>
>> Solutions:
>>
>> (1) add a new regulatory domain (0x49). Here is a patch to
>> use the approach:
>
> Stephen, David, does 0x49 map to JP for zd1211 ? Are there other ones?
> Here is our list so far:
>
> #define ZD_REGDOMAIN_FCC 0x10
> #define ZD_REGDOMAIN_IC 0x20
> #define ZD_REGDOMAIN_ETSI 0x30
> #define ZD_REGDOMAIN_SPAIN 0x31
> #define ZD_REGDOMAIN_FRANCE 0x32
> #define ZD_REGDOMAIN_JAPAN_ADD 0x40
> #define ZD_REGDOMAIN_JAPAN 0x41
>
> This is what they map to:
>
> static struct zd_reg_alpha2_map reg_alpha2_map[] = {
> { ZD_REGDOMAIN_FCC, "US" },
> { ZD_REGDOMAIN_IC, "CA" },
> { ZD_REGDOMAIN_ETSI, "DE" }, /* Generic ETSI, use most restrictive */
Note: This one is causing me problems here in Hungary, as it keeps
resetting my regdomain to Germany. I believe we should implement
allowing the user to choose regdomain in this case, but allowing only
regdomains in ETSI.
> { ZD_REGDOMAIN_JAPAN, "JP" },
> { ZD_REGDOMAIN_JAPAN_ADD, "JP" },
> { ZD_REGDOMAIN_SPAIN, "ES" },
> { ZD_REGDOMAIN_FRANCE, "FR" },
> };
>
> Kouhei, if no regulatory domain is found, instead we should world
> roam, we cannot allow letting the user change regulatory domains at
> their whim. We can, however let them choose one to help compliance,
> but you can only help compliance once you know your actual regulatory
> domain.
>
> Luis
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-15 15:22 ` Luis R. Rodriguez
@ 2010-06-16 12:55 ` Kouhei Sutou
2010-06-16 13:44 ` John W. Linville
0 siblings, 1 reply; 10+ messages in thread
From: Kouhei Sutou @ 2010-06-16 12:55 UTC (permalink / raw
To: mcgrof; +Cc: Stephen.Chen, David.Quan, linux-wireless, Michael.Green
[-- Attachment #1: Type: Text/Plain, Size: 1898 bytes --]
Hi,
In <AANLkTin9bG4qDEKwgOXmlR3k9wZ-JBSIlh3JzYjzVDeY@mail.gmail.com>
"Re: [PATCH] zd1211rw: ignore unknown regulatory domain." on Tue, 15 Jun 2010 08:22:09 -0700,
"Luis R. Rodriguez" <mcgrof@gmail.com> wrote:
> On Tue, Jun 15, 2010 at 7:25 AM, Kouhei Sutou <kou@clear-code.com> wrote:
>> Hi,
>>
>> In <AANLkTinEMAQu33Tlv81-Cdx9fLZK-a-7uJlbAo7te2_w@mail.gmail.com>
>> "Re: [PATCH] zd1211rw: ignore unknown regulatory domain." on Sun, 13 Jun 2010 13:23:20 -0700,
>> "Luis R. Rodriguez" <mcgrof@gmail.com> wrote:
>>
>>>> I'm using PLANEX GW-US54GXS (2019:5303) and it works with
>>>> the attached patch. Could you consider to merge the attached
>>>> patch?
>>>>
>>>> Problem: GW-US54GXS uses zd1211rw but zd1211rw doesn't have
>>>> a regulatory domain reported by GW-US54GXS (0x49).
>>>>
>>>> Solutions:
>>>>
>>>> (1) add a new regulatory domain (0x49). Here is a patch to
>>>> use the approach:
>>>
>>> Stephen, David, does 0x49 map to JP for zd1211 ? Are there other ones?
>>> Here is our list so far:
>> ...
>>> Kouhei, if no regulatory domain is found, instead we should world
>>> roam, we cannot allow letting the user change regulatory domains at
>>> their whim. We can, however let them choose one to help compliance,
>>> but you can only help compliance once you know your actual regulatory
>>> domain.
>>
>> Luis, thanks for your input.
>> It seems that we can't use GW-US54GXS until 0x49 regulatory
>> domain is registered to zd1211rw. Is it right?
>>
>> If it is right, what I can do for GW-US54GXS? Should I wait
>> a response from Stephen and/or David?
>
> We spoke and 0x49 - > JP is ok, can you send a patch for that?
OK.
I'll attach a patch for that.
I used 'ZD_REGDOMAIN_JAPAN_GW_US54GXS' as a macro name for
0x49 because 0x49 is used by GW-US54GXS. Is it OK? Or should
I use other name for it?
Thanks,
--
kou
[-- Attachment #2: 0001-zd1211rw-add-0x49-JP-regulatory-domain-map.patch --]
[-- Type: Text/X-Patch, Size: 1440 bytes --]
>From a530e66e6e995d8e8bc00ece2a9b3540ef88688f Mon Sep 17 00:00:00 2001
From: Kouhei Sutou <kou@clear-code.com>
Date: Wed, 16 Jun 2010 21:53:59 +0900
Subject: [PATCH] zd1211rw: add 0x49 -> JP regulatory domain map
0x49 is used by PLANEX GW-US54GXS (2019:5303).
Signed-off-by: Kouhei Sutou <kou@clear-code.com>
---
drivers/net/wireless/zd1211rw/zd_mac.c | 1 +
drivers/net/wireless/zd1211rw/zd_mac.h | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c
index 163a8a0..faf45f1 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.c
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c
@@ -43,6 +43,7 @@ static struct zd_reg_alpha2_map reg_alpha2_map[] = {
{ ZD_REGDOMAIN_ETSI, "DE" }, /* Generic ETSI, use most restrictive */
{ ZD_REGDOMAIN_JAPAN, "JP" },
{ ZD_REGDOMAIN_JAPAN_ADD, "JP" },
+ { ZD_REGDOMAIN_JAPAN_GW_US54GXS, "JP" },
{ ZD_REGDOMAIN_SPAIN, "ES" },
{ ZD_REGDOMAIN_FRANCE, "FR" },
};
diff --git a/drivers/net/wireless/zd1211rw/zd_mac.h b/drivers/net/wireless/zd1211rw/zd_mac.h
index 630c298..7ab19d5 100644
--- a/drivers/net/wireless/zd1211rw/zd_mac.h
+++ b/drivers/net/wireless/zd1211rw/zd_mac.h
@@ -214,6 +214,7 @@ struct zd_mac {
#define ZD_REGDOMAIN_FRANCE 0x32
#define ZD_REGDOMAIN_JAPAN_ADD 0x40
#define ZD_REGDOMAIN_JAPAN 0x41
+#define ZD_REGDOMAIN_JAPAN_GW_US54GXS 0x49
enum {
MIN_CHANNEL24 = 1,
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-16 12:55 ` Kouhei Sutou
@ 2010-06-16 13:44 ` John W. Linville
2010-06-16 15:02 ` Kouhei Sutou
0 siblings, 1 reply; 10+ messages in thread
From: John W. Linville @ 2010-06-16 13:44 UTC (permalink / raw
To: Kouhei Sutou
Cc: mcgrof, Stephen.Chen, David.Quan, linux-wireless, Michael.Green
On Wed, Jun 16, 2010 at 09:55:23PM +0900, Kouhei Sutou wrote:
> I used 'ZD_REGDOMAIN_JAPAN_GW_US54GXS' as a macro name for
> 0x49 because 0x49 is used by GW-US54GXS. Is it OK? Or should
> I use other name for it?
Hopefully someone can suggest a better name. Anyone know what inspired
"ZD_REGDOMAIN_JAPAN_ADD"?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-16 13:44 ` John W. Linville
@ 2010-06-16 15:02 ` Kouhei Sutou
2010-06-16 15:29 ` John W. Linville
0 siblings, 1 reply; 10+ messages in thread
From: Kouhei Sutou @ 2010-06-16 15:02 UTC (permalink / raw
To: linville; +Cc: mcgrof, Stephen.Chen, David.Quan, linux-wireless, Michael.Green
Hi,
In <20100616134421.GB2404@tuxdriver.com>
"Re: [PATCH] zd1211rw: ignore unknown regulatory domain." on Wed, 16 Jun 2010 09:44:22 -0400,
"John W. Linville" <linville@tuxdriver.com> wrote:
> On Wed, Jun 16, 2010 at 09:55:23PM +0900, Kouhei Sutou wrote:
>
>> I used 'ZD_REGDOMAIN_JAPAN_GW_US54GXS' as a macro name for
>> 0x49 because 0x49 is used by GW-US54GXS. Is it OK? Or should
>> I use other name for it?
>
> Hopefully someone can suggest a better name. Anyone know what inspired
> "ZD_REGDOMAIN_JAPAN_ADD"?
'ZD_REGDOMAIN_JAPAN_3' was used in another patch:
https://patchwork.kernel.org/patch/47220/
But I don't know why '3' was used...
Thanks,
--
kou
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-16 15:02 ` Kouhei Sutou
@ 2010-06-16 15:29 ` John W. Linville
2010-06-16 15:46 ` Luis R. Rodriguez
0 siblings, 1 reply; 10+ messages in thread
From: John W. Linville @ 2010-06-16 15:29 UTC (permalink / raw
To: Kouhei Sutou
Cc: mcgrof, Stephen.Chen, David.Quan, linux-wireless, Michael.Green
On Thu, Jun 17, 2010 at 12:02:23AM +0900, Kouhei Sutou wrote:
> Hi,
>
> In <20100616134421.GB2404@tuxdriver.com>
> "Re: [PATCH] zd1211rw: ignore unknown regulatory domain." on Wed, 16 Jun 2010 09:44:22 -0400,
> "John W. Linville" <linville@tuxdriver.com> wrote:
>
> > On Wed, Jun 16, 2010 at 09:55:23PM +0900, Kouhei Sutou wrote:
> >
> >> I used 'ZD_REGDOMAIN_JAPAN_GW_US54GXS' as a macro name for
> >> 0x49 because 0x49 is used by GW-US54GXS. Is it OK? Or should
> >> I use other name for it?
> >
> > Hopefully someone can suggest a better name. Anyone know what inspired
> > "ZD_REGDOMAIN_JAPAN_ADD"?
>
> 'ZD_REGDOMAIN_JAPAN_3' was used in another patch:
> https://patchwork.kernel.org/patch/47220/
>
> But I don't know why '3' was used...
'3' makes sense to me. The better question is why not change 'ADD' to '2'? :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] zd1211rw: ignore unknown regulatory domain.
2010-06-16 15:29 ` John W. Linville
@ 2010-06-16 15:46 ` Luis R. Rodriguez
0 siblings, 0 replies; 10+ messages in thread
From: Luis R. Rodriguez @ 2010-06-16 15:46 UTC (permalink / raw
To: John W. Linville
Cc: Kouhei Sutou, Stephen.Chen, David.Quan, linux-wireless,
Michael.Green
On Wed, Jun 16, 2010 at 8:29 AM, John W. Linville
<linville@tuxdriver.com> wrote:
> On Thu, Jun 17, 2010 at 12:02:23AM +0900, Kouhei Sutou wrote:
>> Hi,
>>
>> In <20100616134421.GB2404@tuxdriver.com>
>> "Re: [PATCH] zd1211rw: ignore unknown regulatory domain." on Wed, 16 Jun 2010 09:44:22 -0400,
>> "John W. Linville" <linville@tuxdriver.com> wrote:
>>
>> > On Wed, Jun 16, 2010 at 09:55:23PM +0900, Kouhei Sutou wrote:
>> >
>> >> I used 'ZD_REGDOMAIN_JAPAN_GW_US54GXS' as a macro name for
>> >> 0x49 because 0x49 is used by GW-US54GXS. Is it OK? Or should
>> >> I use other name for it?
>> >
>> > Hopefully someone can suggest a better name. Anyone know what inspired
>> > "ZD_REGDOMAIN_JAPAN_ADD"?
>>
>> 'ZD_REGDOMAIN_JAPAN_3' was used in another patch:
>> https://patchwork.kernel.org/patch/47220/
>>
>> But I don't know why '3' was used...
>
> '3' makes sense to me. The better question is why not change 'ADD' to '2'? :-)
2 is fine to replace ADD, I think "ADD" is additional :P
Luis
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-06-16 15:47 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-13 5:52 [PATCH] zd1211rw: ignore unknown regulatory domain Kouhei Sutou
2010-06-13 20:23 ` Luis R. Rodriguez
2010-06-15 14:25 ` Kouhei Sutou
2010-06-15 15:22 ` Luis R. Rodriguez
2010-06-16 12:55 ` Kouhei Sutou
2010-06-16 13:44 ` John W. Linville
2010-06-16 15:02 ` Kouhei Sutou
2010-06-16 15:29 ` John W. Linville
2010-06-16 15:46 ` Luis R. Rodriguez
2010-06-15 17:40 ` Gábor Stefanik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.