* [PATCH] mioa701: fix camera regression
@ 2010-06-02 21:29 Robert Jarzmik
2010-06-03 18:59 ` Guennadi Liakhovetski
0 siblings, 1 reply; 4+ messages in thread
From: Robert Jarzmik @ 2010-06-02 21:29 UTC (permalink / raw
To: linux-arm-kernel
Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the
camera is not working anymore.
After the v4l2 migration, the mt9m111 camera board
information was not passed to the i2c layer anymore, but
stored for future use of v4l2 (through soc_camera).
Because mioa701_i2c_devices[] was tagged as "__initdata",
and because after the v4l2 migration, the new structure
"iclink" references it, the mt9m111 driver is not probed
anymore, as part of "iclink" is not valid (discarded after
kernel init).
Although there is not compilation error, nor runtime oops,
this patch restores a working camera on the mioa701 board.
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
--
Eric, could you schedule that into your fix branch please ?
---
arch/arm/mach-pxa/mioa701.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
index 7a50ed8..9836921 100644
--- a/arch/arm/mach-pxa/mioa701.c
+++ b/arch/arm/mach-pxa/mioa701.c
@@ -696,7 +696,7 @@ static struct i2c_board_info __initdata mioa701_pi2c_devices[] = {
};
/* Board I2C devices. */
-static struct i2c_board_info __initdata mioa701_i2c_devices[] = {
+static struct i2c_board_info mioa701_i2c_devices[] = {
{
I2C_BOARD_INFO("mt9m111", 0x5d),
},
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mioa701: fix camera regression
2010-06-02 21:29 [PATCH] mioa701: fix camera regression Robert Jarzmik
@ 2010-06-03 18:59 ` Guennadi Liakhovetski
2010-06-08 17:31 ` Robert Jarzmik
0 siblings, 1 reply; 4+ messages in thread
From: Guennadi Liakhovetski @ 2010-06-03 18:59 UTC (permalink / raw
To: linux-arm-kernel
On Wed, 2 Jun 2010, Robert Jarzmik wrote:
> Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the
> camera is not working anymore.
>
> After the v4l2 migration, the mt9m111 camera board
> information was not passed to the i2c layer anymore, but
> stored for future use of v4l2 (through soc_camera).
>
> Because mioa701_i2c_devices[] was tagged as "__initdata",
> and because after the v4l2 migration, the new structure
> "iclink" references it, the mt9m111 driver is not probed
> anymore, as part of "iclink" is not valid (discarded after
> kernel init).
>
> Although there is not compilation error, nor runtime oops,
> this patch restores a working camera on the mioa701 board.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> --
> Eric, could you schedule that into your fix branch please ?
> ---
> arch/arm/mach-pxa/mioa701.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
> index 7a50ed8..9836921 100644
> --- a/arch/arm/mach-pxa/mioa701.c
> +++ b/arch/arm/mach-pxa/mioa701.c
> @@ -696,7 +696,7 @@ static struct i2c_board_info __initdata mioa701_pi2c_devices[] = {
> };
>
> /* Board I2C devices. */
> -static struct i2c_board_info __initdata mioa701_i2c_devices[] = {
> +static struct i2c_board_info mioa701_i2c_devices[] = {
> {
> I2C_BOARD_INFO("mt9m111", 0x5d),
> },
> --
> 1.7.0.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mioa701: fix camera regression
2010-06-03 18:59 ` Guennadi Liakhovetski
@ 2010-06-08 17:31 ` Robert Jarzmik
2010-06-13 10:47 ` Eric Miao
0 siblings, 1 reply; 4+ messages in thread
From: Robert Jarzmik @ 2010-06-08 17:31 UTC (permalink / raw
To: linux-arm-kernel
> On Wed, 2 Jun 2010, Robert Jarzmik wrote:
>
>> Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the
>> camera is not working anymore.
>>
>> After the v4l2 migration, the mt9m111 camera board
>> information was not passed to the i2c layer anymore, but
>> stored for future use of v4l2 (through soc_camera).
>>
>> Because mioa701_i2c_devices[] was tagged as "__initdata",
>> and because after the v4l2 migration, the new structure
>> "iclink" references it, the mt9m111 driver is not probed
>> anymore, as part of "iclink" is not valid (discarded after
>> kernel init).
>>
>> Although there is not compilation error, nor runtime oops,
>> this patch restores a working camera on the mioa701 board.
>>
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
>>
>> --
>> Eric, could you schedule that into your fix branch please ?
Ping.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mioa701: fix camera regression
2010-06-08 17:31 ` Robert Jarzmik
@ 2010-06-13 10:47 ` Eric Miao
0 siblings, 0 replies; 4+ messages in thread
From: Eric Miao @ 2010-06-13 10:47 UTC (permalink / raw
To: linux-arm-kernel
On Wed, Jun 9, 2010 at 1:31 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> On Wed, 2 Jun 2010, Robert Jarzmik wrote:
>>
>>> Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the
>>> camera is not working anymore.
>>>
>>> After the v4l2 migration, the mt9m111 camera board
>>> information was not passed to the i2c layer anymore, but
>>> stored for future use of v4l2 (through soc_camera).
>>>
>>> Because mioa701_i2c_devices[] was tagged as "__initdata",
>>> and because after the v4l2 migration, the new structure
>>> "iclink" references it, the mt9m111 driver is not probed
>>> anymore, as part of "iclink" is not valid (discarded after
>>> kernel init).
>>>
>>> Although there is not compilation error, nor runtime oops,
>>> this patch restores a working camera on the mioa701 board.
>>>
>>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>>
>> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>
>>>
>>> --
>>> Eric, could you schedule that into your fix branch please ?
>
> Ping.
>
Sorry. Now merged.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-13 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-02 21:29 [PATCH] mioa701: fix camera regression Robert Jarzmik
2010-06-03 18:59 ` Guennadi Liakhovetski
2010-06-08 17:31 ` Robert Jarzmik
2010-06-13 10:47 ` Eric Miao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.