From: Linus Torvalds <torvalds@linux-foundation.org>
To: Carlos Mafra <crmafra2@gmail.com>,
Keith Packard <keithp@keithp.com>,
Dave Airlie <airlied@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Takashi Iwai <tiwai@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Florian Mickler <florian@mickler.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Linux PM List <linux-pm@lists.linux-foundation.org>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
DRI <dri-devel@lists.freedesktop.org>
Subject: Re: 2.6.38-rc3-git1: Reported regressions 2.6.36 -> 2.6.37
Date: Thu, 3 Feb 2011 14:10:51 -0800 [thread overview]
Message-ID: <AANLkTi=7EOih=fY5FCvhQbewSc=3a49cYVaKJRWM+-3d@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=suS1VDL=6EtT0D2=0c1DWwxdwZBBv=-BySNX-@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]
On Thu, Feb 3, 2011 at 1:56 PM, Carlos Mafra <crmafra2@gmail.com> wrote:
>>
>> I added https://bugzilla.kernel.org/show_bug.cgi?id=24982 to the list of
>> post-2.6.36 regressions for further tracking.
>
> I also tested on 2.6.38-rc3+ now and the issue is not solved,
> just like Takashi expected.
Hmm. That commit (bf9dc102e284) still reverts cleanly.
Keith, Dave, should we just revert it? It's definitely a regression,
and we do _not_ allow "fixes" to one thing that just causes a
regression to another.
Quite frankly, I think it's totally wrong to just blindly set DPMS
status to ON like that. It's as wrong as it was to leave it off, and
the regressions reported are basically mirror images of the exact same
bug that that commit tried to fix.
IOW, the commit message says:
When setting a new crtc configuration, force the DPMS state of all
connectors to ON. Otherwise, they'll be left at OFF and a future mode set
that disables the specified connector will not turn the connector off.
but setting it to ON doesn't actually _fix_ anything, because you just
get the exact same issue in reverse, ie you just get
.. and a future mode set that ENables the specified connector will
not turn the connector ON.
instead. Which is exactly what Carlos and Takashi are reporting.
Maybe the right thing to do is to set it to 'unknown', something like this.
TOTALLY UNTESTED!
Linus
[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 1334 bytes --]
drivers/gpu/drm/drm_crtc_helper.c | 6 +++---
include/drm/drm_mode.h | 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 952b3d4..7f585ed 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -681,11 +681,11 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
goto fail;
}
}
- DRM_DEBUG_KMS("Setting connector DPMS state to on\n");
+ DRM_DEBUG_KMS("Setting connector DPMS state to 'unknown'\n");
for (i = 0; i < set->num_connectors; i++) {
- DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id,
+ DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS 'unknown'\n", set->connectors[i]->base.id,
drm_get_connector_name(set->connectors[i]));
- set->connectors[i]->dpms = DRM_MODE_DPMS_ON;
+ set->connectors[i]->dpms = DRM_MODE_DPMS_UNKNOWN;
}
kfree(save_connectors);
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index 0fc7397..4b5144c 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -59,6 +59,7 @@
/* DPMS flags */
/* bit compatible with the xorg definitions. */
+#define DRM_MODE_DPMS_UNKNOWN (-1)
#define DRM_MODE_DPMS_ON 0
#define DRM_MODE_DPMS_STANDBY 1
#define DRM_MODE_DPMS_SUSPEND 2
next prev parent reply other threads:[~2011-02-03 22:11 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 0:03 2.6.38-rc3-git1: Reported regressions 2.6.36 -> 2.6.37 Rafael J. Wysocki
2011-02-03 0:03 ` Rafael J. Wysocki
2011-02-03 0:03 ` [Bug #22542] [2.6.37-rc1] drm:i195 errors Rafael J. Wysocki
2011-02-03 8:19 ` Paul Rolland
2011-02-03 8:19 ` Paul Rolland
2011-02-03 19:01 ` Rafael J. Wysocki
2011-02-03 19:01 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #22882] (2.6.37-rc1) amd64-agp module crashed on second load Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #22642] 2.6.37-rc1: Disk takes 10 seconds to resume - MacBook2,1 Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #22912] spi_lm70llp module crash on unload (2.6.37-rc1) Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #24762] BUG at perf_ctx_adjust_freq (kernel/perf_event.c:1582) Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #24822] Embedded DisplayPort is detected wrongly on HP ProBook 5320m Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #23472] 2.6.37-rc2 vs. 2.6.36 laptop backlight changes? Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #24582] Kernel Oops at tty_buffer_request_room when using pppd program (2.6.37-rc4) Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #22942] [2.6.37-rc1, OOM] virtblk: OOM in do_virtblk_request() Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #25442] ixp4xx defines FREQ macro; conflicts with gspca/ov519 driver Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #24882] PM/Hibernate: Memory corruption patch introduces regression (2.6.36.2) Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #25072] backlight level is not maintened during LID close/open Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #25402] kernel (2.6.37-8-generic_amd64) panic on boot (with message "map_single: bounce buffer is not DMA'ble) - possible regression !!! Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #25432] Alpha fails to build with gcc 4.4 Rafael J. Wysocki
2011-02-08 8:24 ` Michael Cree
2011-02-03 0:05 ` [Bug #25822] [BUG] kernel BUG at mm/truncate.c:479! on 2.6.37-rc8 Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #25732] i915 turns picture green when display switched off-on Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #25832] kernel crashes upon resume if usb devices are removed when suspended Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #25922] IdeaPad Y530 brightness keys not functioning Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26112] [LogFS] [2.6.37-rc8+] Kernel BUG at logfs/readwrite.c:297! Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26102] [2.6.37-rc8] BUG kmalloc-256: Poison overwritten Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26242] BUG: unable to handle kernel NULL pointer dereference at (null) Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26552] Screen flickering with 2.6.37 [ATI X1600] Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26212] kernel NULL pointer dereference in pxa3xx_nand_probe Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26802] b43: Suspend failed Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26932] [SNB mobile] Oops in DRM intel driver, esp. during S3/S4 stress test Rafael J. Wysocki
2011-02-03 13:35 ` Matthias Hopf
2011-02-03 13:35 ` Matthias Hopf
2011-02-03 19:03 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26582] NULL pointer dereference on pipe creation Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26842] [2.6.37 regression] threads with CPU affinity cannot be killed Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27132] flush-btrfs gets into an infinite loop Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27152] VGA output broken at cold boot Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #26942] radeon: screen distortion on resume Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27402] Atheros adapter no longer loads firmware Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27532] ath9k prevents CPU from entering lower C-states Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27202] Remote control of saa7134-based tv card "ASUSTeK P7131 Hybrid" stopped working in 2.6.37 Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27642] 2.6.37 says WARNING: at arch/x86/kernel/apic/apic.c:1287 setup_local_APIC+0x18f/0x263() Rafael J. Wysocki
2011-02-03 0:05 ` Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27892] SNB: GPU hang with Slip xscreensaver Rafael J. Wysocki
2011-02-03 0:05 ` [Bug #27842] [regression?] hang with 2.6.37 on a BTRFS test machine Rafael J. Wysocki
2011-02-03 11:20 ` Martin Steigerwald
2011-02-03 11:46 ` Helmut Hullen
2011-02-03 23:21 ` Chris Samuel
2011-02-03 19:05 ` Rafael J. Wysocki
2011-02-03 11:23 ` 2.6.38-rc3-git1: Reported regressions 2.6.36 -> 2.6.37 Carlos R. Mafra
2011-02-03 11:23 ` Carlos R. Mafra
2011-02-03 15:42 ` Linus Torvalds
2011-02-03 15:42 ` Linus Torvalds
2011-02-03 15:42 ` Linus Torvalds
2011-02-03 16:11 ` Takashi Iwai
2011-02-03 16:11 ` Takashi Iwai
2011-02-03 19:09 ` Rafael J. Wysocki
2011-02-03 19:09 ` Rafael J. Wysocki
2011-02-03 21:56 ` Carlos Mafra
2011-02-03 21:56 ` Carlos Mafra
2011-02-03 21:56 ` Carlos Mafra
2011-02-03 22:10 ` Linus Torvalds
2011-02-03 22:10 ` Linus Torvalds [this message]
2011-02-03 22:19 ` Linus Torvalds
2011-02-03 22:19 ` Linus Torvalds
2011-02-04 0:06 ` Dave Airlie
2011-02-04 0:06 ` Dave Airlie
2011-02-04 0:30 ` Linus Torvalds
2011-02-04 0:30 ` Linus Torvalds
2011-02-04 0:45 ` Dave Airlie
2011-02-04 0:45 ` Dave Airlie
2011-02-04 1:05 ` Keith Packard
2011-02-04 1:05 ` Keith Packard
2011-02-04 1:11 ` Linus Torvalds
2011-02-04 1:11 ` Linus Torvalds
2011-02-04 1:41 ` Keith Packard
2011-02-04 1:41 ` Keith Packard
2011-02-04 1:42 ` Dave Airlie
2011-02-04 1:42 ` Dave Airlie
2011-02-04 7:05 ` Carlos R. Mafra
2011-02-04 7:05 ` Carlos R. Mafra
2011-02-04 7:05 ` Carlos R. Mafra
2011-02-04 11:16 ` Takashi Iwai
2011-02-04 11:16 ` Takashi Iwai
2011-02-04 1:05 ` Keith Packard
2011-02-04 0:06 ` Dave Airlie
2011-02-03 11:23 ` Carlos R. Mafra
-- strict thread matches above, loose matches on Subject: below --
2011-02-03 0:03 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=7EOih=fY5FCvhQbewSc=3a49cYVaKJRWM+-3d@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=crmafra2@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=florian@mickler.org \
--cc=keithp@keithp.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.