* drm/mcde: Reconsider duplicate statement in mcde_probe()
@ 2019-10-28 17:00 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-10-28 17:00 UTC (permalink / raw
To: Linus Walleij, Daniel Vetter, dri-devel
Cc: LKML, kernel-janitors, David Airlie
Hello,
I have taken another look also at the implementation of the function “mcde_probe”.
Now I wonder why the statement “drm->dev_private = mcde;” was specified twice there.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/mcde/mcde_drv.c#L339
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mcde/mcde_drv.c?id=0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3#n339
How do you think about to delete one of them so that a duplicate assignment
can be avoided?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* drm/mcde: Reconsider duplicate statement in mcde_probe()
@ 2019-10-28 17:00 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-10-28 17:00 UTC (permalink / raw
To: Linus Walleij, Daniel Vetter, dri-devel
Cc: David Airlie, kernel-janitors, LKML
Hello,
I have taken another look also at the implementation of the function “mcde_probe”.
Now I wonder why the statement “drm->dev_private = mcde;” was specified twice there.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/mcde/mcde_drv.c#L339
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mcde/mcde_drv.c?id=0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3#n339
How do you think about to delete one of them so that a duplicate assignment
can be avoided?
Regards,
Markus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* drm/mcde: Reconsider duplicate statement in mcde_probe()
@ 2019-10-28 17:00 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-10-28 17:00 UTC (permalink / raw
To: Linus Walleij, Daniel Vetter, dri-devel
Cc: LKML, kernel-janitors, David Airlie
Hello,
I have taken another look also at the implementation of the function “mcde_probe”.
Now I wonder why the statement “drm->dev_private = mcde;” was specified twice there.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/mcde/mcde_drv.c#L339
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mcde/mcde_drv.c?id=0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3#n339
How do you think about to delete one of them so that a duplicate assignment
can be avoided?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-28 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-28 17:00 drm/mcde: Reconsider duplicate statement in mcde_probe() Markus Elfring
2019-10-28 17:00 ` Markus Elfring
2019-10-28 17:00 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.