From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74CACC47082 for ; Mon, 7 Jun 2021 16:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B5D461C5D for ; Mon, 7 Jun 2021 16:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbhFGQce (ORCPT ); Mon, 7 Jun 2021 12:32:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232573AbhFGQ0W (ORCPT ); Mon, 7 Jun 2021 12:26:22 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A981C0604C5; Mon, 7 Jun 2021 09:20:57 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id i12-20020a05683033ecb02903346fa0f74dso17250157otu.10; Mon, 07 Jun 2021 09:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=NCnduflce68YkMnn3i+unqWk8SYuVU7hs0nySniBIqo=; b=NqbK6nDyy6LvMfquS66sa0nUEDrX7atPQMGjlhl1ZFugtyvAjezaTleeVNnhdRGWLa F7CYeHqE0qgkFY83UNGtW7eeCDZSjh8M37KwkDrJIQZHNwpi63a2pXWE/noNkEJTM9IE ZXdYL3H3/JO6REQrqENp2NSQHg0rNwDsSZdx1Q7tfboer6KbJK69LGRx2xx6rCRa8sOI SEQeI8HjFtX37olEP/ILtonHJAX+Q9X2CgWfIC2mJei4KroAgWcoDTOQ0qyjeXbi/WtW UKHcRmo7GNTu/y22jVmJwv/hwT/DNQcRKgpdPC6IfPT4fDNCz2/cV6NOeAH3Ni+O4cwu xQvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NCnduflce68YkMnn3i+unqWk8SYuVU7hs0nySniBIqo=; b=cjmAyet+sy6sZT83+oAbKXpFThZWZ3Z6k4gSJnwyu53cAf77hyDADxZp+NJrI8FJXd lBTmqteH2gdOc6ab6LT+4Y1PNHoGrcS43EDLQOeGzD/lw4yBcgAHl2JAefUvVNwDADPq d5MdBgQ8T+As4bf28OrBtceiJ1QWXVR86Nk0NunYUnm7zMhhoox1qoc2BU+xiNwK99nk yay0vpE0ZPbH3Wt8NAbFqz3xmqf3VmCSrF4ZgwEFqs7rEd7vn2/2InCEXoY5N9HEw3vB jZqrtxVDhuBttoPXti6wDBXhpAqgLBLoiHJqaj4ZE3+JbU6khnh48eo/aM4EPAXq2NVR Gw6w== X-Gm-Message-State: AOAM531ROZdzfdiBI0CHAT7UxaXT+a8BltHL2dnRtTKrVAC+1QscQCnx qoXHst8FKJf43a36VtuCMebKcuh1FdE= X-Google-Smtp-Source: ABdhPJxWDfzJm1mcMJbUJOfYtNE2NGOlVfTBtBG+2Py222H6hSWCZ8dmX9wMmAqIVaN1ckkVGiq1ow== X-Received: by 2002:a05:6830:1d72:: with SMTP id l18mr2388313oti.150.1623082856345; Mon, 07 Jun 2021 09:20:56 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.22]) by smtp.googlemail.com with ESMTPSA id n17sm2372879oij.57.2021.06.07.09.20.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 09:20:56 -0700 (PDT) Subject: Re: [PATCH net-next] net: ipv4: Remove unneed BUG() function To: Zheng Yongjun , davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210607143909.2844407-1-zhengyongjun3@huawei.com> From: David Ahern Message-ID: <9274e18e-dc57-f6c2-e0cc-0d06841df54e@gmail.com> Date: Mon, 7 Jun 2021 10:20:54 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210607143909.2844407-1-zhengyongjun3@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/7/21 8:39 AM, Zheng Yongjun wrote: > When 'nla_parse_nested_deprecated' failed, it's no need to > BUG() here, return -EINVAL is ok. > > Signed-off-by: Zheng Yongjun > --- > net/ipv4/devinet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c > index 2e35f68da40a..1c6429c353a9 100644 > --- a/net/ipv4/devinet.c > +++ b/net/ipv4/devinet.c > @@ -1989,7 +1989,7 @@ static int inet_set_link_af(struct net_device *dev, const struct nlattr *nla, > return -EAFNOSUPPORT; > > if (nla_parse_nested_deprecated(tb, IFLA_INET_MAX, nla, NULL, NULL) < 0) Avoid assumptions on the failure reason: int err; err = nla_parse_nested_deprecated(); if (err < 0) return err; > - BUG(); > + return -EINVAL; > > if (tb[IFLA_INET_CONF]) { > nla_for_each_nested(a, tb[IFLA_INET_CONF], rem) > seems like this patch and a similar fix for the IPv6 version of set_link_af should go to net rather than net-next.