From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E1FC3DA6E for ; Mon, 8 Jan 2024 16:07:21 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D45440273; Mon, 8 Jan 2024 17:07:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9809640263 for ; Mon, 8 Jan 2024 17:07:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704730038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sI6OTTrMxbVKheBX0Mid/BoEmJPmBxRHVjAo8AA58Zc=; b=Pymjl4bNwymH3Q12pmwykKUKsAWyFRgz3NUBAY3N33tUKZ4BLgtfM4A82L1f5Z/9KzRVFj eYy/0KnMXFDbWJtTeiyb2cwl9uoJ5WVt80pR5dtprKbl9yC2fRERCCg9uxUkE8/xoyjulT GU6zYluPFdE9fw1tuk6AkpCmLPfJjZk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-65bYTlfFPx-J-ln94Uayug-1; Mon, 08 Jan 2024 11:07:17 -0500 X-MC-Unique: 65bYTlfFPx-J-ln94Uayug-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-336c3c777ffso1343319f8f.2 for ; Mon, 08 Jan 2024 08:07:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704730035; x=1705334835; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sI6OTTrMxbVKheBX0Mid/BoEmJPmBxRHVjAo8AA58Zc=; b=SZTJBL3/pAJZtOyUzbMcykPrXEzmMch9OtwdPKtvTAJDTd0+7fN1LJARAdrbnjgoY/ HCSDSMaCfZzCglGHsG9NJgQtWbv1PzfLtCODlMoM7hygsBA9FztRGGyjkc5gauv50N9x YhSj/GVjbUlAbjwlYJqa2lZ107MNybQ0oq89g5pySEa1V7TWTI0LAeroBsOLtVNjUFbV r89jAMnFTxLlTqufw+aSBTUCmmmX7ArQqwK+Sa2vOs/peq9IM76j5LnZ8dPyy/J/hVUg y2EVGl+ZnkU3nvmO+2YszYbC8KgqbJPmMWz66o9qPM6yMBsdAkMiA0ek1u5afpRF+qXf UkYQ== X-Gm-Message-State: AOJu0Yx+uG+TipUkvWtiPMXaglCaJBv4CAs/E3wtfQ5tjz6IhtUI7xja IZtxafD4tc0YWawZzlQX63D7oWJlrgcrJUC74nOdfByGgVFTGVctV11FTqGs+Ww+Bc1T77ACmp9 YVMuypr0BrPY= X-Received: by 2002:adf:ab19:0:b0:337:1d49:c03 with SMTP id q25-20020adfab19000000b003371d490c03mr1683300wrc.106.1704730035361; Mon, 08 Jan 2024 08:07:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbuEtwCtspDn5bpC9u8gLlovefmINog/QDFCUqb6yTzw1cTqLtk/CVhQV6cxxJ1mHiAYvEgw== X-Received: by 2002:adf:ab19:0:b0:337:1d49:c03 with SMTP id q25-20020adfab19000000b003371d490c03mr1683296wrc.106.1704730035047; Mon, 08 Jan 2024 08:07:15 -0800 (PST) Received: from [192.168.0.36] ([78.17.181.114]) by smtp.gmail.com with ESMTPSA id s13-20020adff80d000000b003365fc41bcasm16409wrp.51.2024.01.08.08.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 08:07:14 -0800 (PST) Message-ID: <903be6f2-b04e-4e95-915d-0756044f3bc3@redhat.com> Date: Mon, 8 Jan 2024 16:07:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [BUG] [bonding] bonding member delete bug To: Ferruh Yigit , Simon Jones , dev@dpdk.org Cc: David Marchand References: From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 08/01/2024 15:55, Ferruh Yigit wrote: > On 12/18/2023 6:37 AM, Simon Jones wrote: >> Oh, it's fixed by 0911d4ec and f5e72e8e >> > > Thanks Simon for reporting. > > Do you know if the above fixes backported to the 21.11.x LTS release? > Yes, 0911d4ec as part of 18.11 [0] and f5e72e8e backported to 21.11 branch since v21.11.2 [1] [0] https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=0911d4ec01839c9149a0df5758d00d9d57a47cea [1] https://git.dpdk.org/dpdk-stable/commit/?h=21.11&id=5a8afc69afabd3c69efbc1b0c048f31d06f7d875 thanks, Kevin. > >> ---- >> Simon Jones >> >> >> Simon Jones > 于2023 >> 年12月18日周一 10:51写道： >> >> Hi all, >> >> I'm using DPDK-21.11 in ovs-dpdk. >> >> I found a "bonding member delete bug" . >> >> 1. How to reproduce >> >> ``` >> NOTICE: bondctl is a tool I develop, it's to control DPDK. >> >> ### step 1, Add bonding device bond0. >> bondctl add bond0 mode active-backup >> >> ### step 2, Add member m1 into bond0. >> bondctl set 0000:00:0a.0 master bond0  >> >> ### step 3, Add bond0 into ovs bridge. >> ovs-vsctl add-port brp0 bond0 -- set interface bond0 type=dpdk >> options:dpdk-devargs=net_bonding-bond0 >> (this command call @bond_ethdev_start at last.) >> >> ### step 4, Delete bond0 from ovs bridge. >> ovs-vsctl del-port br-phy bond0 >> (this command call @bond_ethdev_stop at last.) >> >> ### step 5, Delete m1 from bond0. >> bondctl set 0000:00:0a.0 nomaster >> >> ### step 6, Delete bond0. >> bondctl del bond0 >> >> ### step 7, Add bond0. >> bondctl add bond0 mode active-backup >> >> ### step 8, Add member m1 into bond0. >> bondctl set 0000:00:0a.0 master bond0 >> (this command call @bond_ethdev_start at last.) >> >> ### Then got error message. >> 2023-12-15T08:24:04.153Z|00017|dpdk|ERR|Port 0 must be stopped to >> allow configurr >> ation >> 2023-12-15T08:24:04.153Z|00018|dpdk|ERR|bond_cmd_set_master(581) - >> can not confii >> g slave 0000:00:0a.0! >> ``` >> >> 2. Debug >> >> I found the reason is, when member port is DOWN, then add operation >> will call "eth_dev->data->dev_started = 1;", but no one add active >> member port, so when delete bond0, will NOT call @rte_eth_dev_stop, >> then add bond0 again, got error. Detail is: >> ``` >> ### After step 1-3, add bond0 into ovs-dpdk >> bond_ethdev_start >>     eth_dev->data->dev_started = 1; >>     for (i = 0; i < internals->slave_count; i++) { >>         if (slave_configure(eth_dev, slave_ethdev) != 0) { >>         if (slave_start(eth_dev, slave_ethdev) != 0) { >>             rte_eth_dev_start >> >> ### NOTICE, as member port is DOWN, so will NOT >> call @activate_slave, so @active_slave_count is 0. >> bond_ethdev_lsc_event_callback >>     activate_slave(bonded_eth_dev, port_id); >> >> ### After step 4, delete bond0 from ovs-dpdk, NOTICE, >> as @active_slave_count is 0, so will NOT call @rte_eth_dev_stop >> bond_ethdev_stop >>     for (i = 0; i < internals->slave_count; i++) { >>         if (find_slave_by_id(internals->active_slaves, >>                 internals->active_slave_count, slave_id) != >>                         internals->active_slave_count) { >>             ret = rte_eth_dev_stop(slave_id); >> >> ### After step 5-7, delete bond0 and then add bond0 >> >> ### After step 8, add bond0, as it's NOT call @rte_eth_dev_stop, so >> call @rte_eth_dev_start again will got error. >> 2023-12-15T08:24:04.153Z|00017|dpdk|ERR|Port 0 must be stopped to >> allow configurr >> ation >> >> ``` >> >> 3. My question >> >> Is this bug fixed ? Which commit ? >> >> If NOT, how to fix this bug? I think it's better to >> call @rte_eth_dev_stop for every member, even it's DOWN. How about this? >> >> Thanks~ >> >> >> ---- >> Simon Jones >> >