All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/audio: fix monitor presence indication after disable
@ 2014-11-18 10:11 Jani Nikula
  2014-11-18 10:20 ` Daniel Vetter
  2014-11-18 16:04 ` [PATCH] drm/i915/audio: fix monitor presence indication shuang.he
  0 siblings, 2 replies; 3+ messages in thread
From: Jani Nikula @ 2014-11-18 10:11 UTC (permalink / raw
  To: intel-gfx; +Cc: jani.nikula

Indicate the monitor has been disconnected on disable.

The regression has been introduced in

commit 5fad84a7530f8e7664cdc6f490cb90653fed1266
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Tue Nov 4 10:30:23 2014 +0200

    drm/i915: rewrite hsw/bdw audio codec enable/disable sequences

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86424
Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index 87750ef018e6..2c7ed5cb29c0 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -194,6 +194,7 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder)
 	/* Invalidate ELD */
 	tmp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
 	tmp &= ~AUDIO_ELD_VALID(pipe);
+	tmp &= ~AUDIO_OUTPUT_ENABLE(pipe);
 	I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, tmp);
 }
 
-- 
2.1.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915/audio: fix monitor presence indication after disable
  2014-11-18 10:11 [PATCH] drm/i915/audio: fix monitor presence indication after disable Jani Nikula
@ 2014-11-18 10:20 ` Daniel Vetter
  2014-11-18 16:04 ` [PATCH] drm/i915/audio: fix monitor presence indication shuang.he
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2014-11-18 10:20 UTC (permalink / raw
  To: Jani Nikula; +Cc: intel-gfx

On Tue, Nov 18, 2014 at 12:11:29PM +0200, Jani Nikula wrote:
> Indicate the monitor has been disconnected on disable.
> 
> The regression has been introduced in
> 
> commit 5fad84a7530f8e7664cdc6f490cb90653fed1266
> Author: Jani Nikula <jani.nikula@intel.com>
> Date:   Tue Nov 4 10:30:23 2014 +0200
> 
>     drm/i915: rewrite hsw/bdw audio codec enable/disable sequences
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86424
> Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915/audio: fix monitor presence indication
  2014-11-18 10:11 [PATCH] drm/i915/audio: fix monitor presence indication after disable Jani Nikula
  2014-11-18 10:20 ` Daniel Vetter
@ 2014-11-18 16:04 ` shuang.he
  1 sibling, 0 replies; 3+ messages in thread
From: shuang.he @ 2014-11-18 16:04 UTC (permalink / raw
  To: shuang.he, intel-gfx, jani.nikula

Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform: baseline_drm_intel_nightly_pass_rate->patch_applied_pass_rate
BYT: pass/total=290/290->290/290
PNV: pass/total=362/362->362/362
ILK: pass/total=381/381->380/381
IVB: pass/total=522/559->521/559
SNB: pass/total=444/444->444/444
HSW: pass/total=595/595->595/595
BDW: pass/total=436/436->436/436
-------------------------------------Detailed-------------------------------------
test_platform: test_suite, test_case, result_with_drm_intel_nightly(count, machine_id...)...->result_with_patch_applied(count, machine_id)...
ILK: Intel_gpu_tools, igt_kms_flip_flip-vs-modeset-vs-hang-interruptible, DMESG_WARN(2, M26M37)PASS(5, M37M26) -> DMESG_WARN(1, M37)PASS(3, M37)
IVB: Intel_gpu_tools, igt_kms_cursor_crc_cursor-64x64-offscreen, PASS(4, M21) -> DMESG_WARN(1, M21)PASS(3, M21)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-18 16:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-18 10:11 [PATCH] drm/i915/audio: fix monitor presence indication after disable Jani Nikula
2014-11-18 10:20 ` Daniel Vetter
2014-11-18 16:04 ` [PATCH] drm/i915/audio: fix monitor presence indication shuang.he

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.