From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDBC79463 for ; Thu, 11 Apr 2024 01:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712798877; cv=none; b=KVH4s9DwsO1FSeIp13/PJg7t/H50NrC1enfFcxrqx7jPaEYM+PQVVU2mV5gtCA4Z8zgbab75PxeCJVeNy7VLTMG+wGCu1enMWetPabho0V8svq3h1ZmoLQWO7bzqGkwI1GdZd1nOUfQIosCu3uSFPSXm1gUN5DueiLncEUgND/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712798877; c=relaxed/simple; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kFnO2xfY1GlwErcPHH5bjjPMAc4V8r5oPhYxf76DQIwJgvBfsY73xHKHU1SEklCGuz8RGPwhPMn6BtnDxsxcJ7ZcNwUojJkflmZP+x0A2TkCTJq2nssFtPKSUl3fe9TK2ogJva/FMIxKMdV6oFXkkikYLJNEc8pkDBHXtbMuH5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LKkv38HO; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LKkv38HO" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-2330f85c2ebso752646fac.1 for ; Wed, 10 Apr 2024 18:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712798875; x=1713403675; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=LKkv38HODTb7tDoqSW7ZCIK/QIRsuMQ9wf+dwQ30x4ZBho8y9efrp9yM/PjWM3ErC+ fXD340D/fTjXt/riFHYr4ektQKre0gAPXLQ3DrwS/FDP/mntefcL7GiPcoZI3ZW/X7ER QESXKnJHie7YzUyiuykysAsz4/uYZIMMSWA8wPrXKlh6Qy5yGk8Oox2vJU6FL3jWrbMb brM4ED9ofH9Oj5IhMJPbXJJqTHQzRu9bQFrD65cGYAJAOh4T/9cpUGudUlOsMnrTkyO4 l25xuXKUVY+T02d8Vza+IMYylD+TCRb1I279Ca/rzY/rP05249yuJnRZEDoIqtvmsh6k u+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712798875; x=1713403675; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=gzB/EeENHxRIjtbbox4SCDK5VDZw9axB0pmB+f598cfSg1I3hjO3aSv7buOgAJufvs XMqK5Q9LYe/KIY+ztr6+usfoARKqOvUcw2bviQGPI+y/yN/OJKFepQKx/k4TESh7Mobe gMdL2YZxfaOMAVcnncdJHFeBE+XkZ2PlPVt6m84UKi+uwgFwkGphmeiOtIwjtgPO0cTt TV2ub+1fm4rFTM0lLDLTjX1uGOlKSdyJDyo2QLdLyH0XhMSSDzmKcSQiVps7YGS387TN RZLY0IYbqgNUHv72JW8jXZ0bK6h0TOMqe/n+7+Rz8sbv5fdPW7MrEzQyf2HXj4J+rNZc WakQ== X-Forwarded-Encrypted: i=1; AJvYcCV0el1ZPlkMzSghk+/MSorsIlPHiaKclqckvNh+0R6nFjzzdOwP7EI4VlElougOHajzw0ohq9JXn1nT5X/Jy6D/bzt1/RLbqYbSyIFO X-Gm-Message-State: AOJu0Yxh9oXqcBWQbmlE1aZU/LYcCzTCuD0JAzkmRYChVX0zuHVL89r3 bcR2zm3BTwc+bDO+AqZggZ+aVLjZBqDGOrGPAOxjlZZ4aV+JFj4X296SO7gcFz0= X-Google-Smtp-Source: AGHT+IF8lPPFTalL1WPSfnBvduuYhf5K6F9EIeC9RLCCka0Vl/mHkW4wRauCXJubFXwb7faJCr3ffA== X-Received: by 2002:a05:6870:518:b0:22e:bcfd:deb0 with SMTP id j24-20020a056870051800b0022ebcfddeb0mr4667832oao.41.1712798874921; Wed, 10 Apr 2024 18:27:54 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:fcac:9b42:fe81:c62f]) by smtp.gmail.com with ESMTPSA id c1-20020aa78c01000000b006ed38291aebsm289791pfd.178.2024.04.10.18.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 18:27:54 -0700 (PDT) From: Thiago Jung Bauermann To: Samuel Holland Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT In-Reply-To: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> (Samuel Holland's message of "Wed, 10 Apr 2024 20:11:04 -0500") References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 10 Apr 2024 22:27:52 -0300 Message-ID: <87le5kofhj.fsf@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hello Samuel, Samuel Holland writes: > On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: >> Samuel Holland writes: >>> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>>> >>>> Unfortunately this patch causes build failures on arm with allyesconfig >>>> and allmodconfig. Tested with next-20240410. >> >> >> >>> In both cases, the issue is that the toolchain requires runtime support to >>> convert between `unsigned long long` and `double`, even when hardware FP is >>> enabled. There was some past discussion about GCC inlining some of these >>> conversions[1], but that did not get implemented. >> >> Thank you for the explanation and the bugzilla reference. I added a >> comment there mentioning that the problem came up again with this patch >> series. >> >>> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >>> 32-bit arm until we can provide these runtime library functions. >> >> Does this mean that patch 2 in this series: >> >> [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT >> >> will be dropped? > > No, because later patches in the series (3, 6) depend on the definition of > CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can > find a GPL-2 compatible implementation of the runtime library functions. Ok, thank you for clarifying. Andrew Pinski just responded on the GCC bugzilla and if I understood his point correctly, it seems to be a matter of changing function names to what GCC (or actually the arm EABI) expects... -- Thiago From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68D91CD11C2 for ; Thu, 11 Apr 2024 01:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YrdEnVpMuXINnrXLPCGPb/XJumqb4Gmo/RI3cKu46F0=; b=suyASvQgeEwpVC We+fpUCA8aUbYr9c+eqpr0kSESnZz0+rt+J4+DtSLWmR0YcCexyd1KKQk8cffgn1g56bTmm+KF0UV yKc1NbXobBylJnbjX8WX1QvXXnM+KKiD19A9af1WkvvipAC/cvN23WrONz/urxNqZQQ24fI0WhTLG 8wSfTcF4e8heyABBQ3/DmhvVwMmTwnMcBxWXIteBvzHqiGxVcA7oWn3iTeQ+R/NyYBmPrLrXWp00N 6lVaCgY6q2ax4EHTu1aa35j22IALz/2mNU+RRdADiM+99uhuU1tYtbyYUq98oD05cbgcw5vi18ZFF oRvHbmW0pbi9dVhyWuYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rujEP-00000009ptn-0sII; Thu, 11 Apr 2024 01:28:01 +0000 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rujEK-00000009prd-39Rd for linux-riscv@lists.infradead.org; Thu, 11 Apr 2024 01:27:58 +0000 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-22ecc103220so3815084fac.2 for ; Wed, 10 Apr 2024 18:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712798875; x=1713403675; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=Dho5xIqj3rvmtrajHHzEGzF1vndJC/QL869/4K1hYXUcJkWFcMADPuybhhYruQnzRg kC8+B+MgD31+TebFXj20wjPmiXyHWrstnhnJfL/XaoTnWS1MUv2AhSrJb/ii0L64vudj sDhQVUl+UfdeNtSddOjaaZ5qhSxiS1/CXThTkBhmYNiaYk3W6+BTzq3nq+7Ut2RMrKjR eYKln2/OYIfWhWuxQ2ltGiuWzUROD2mxouVysTaW3OriCcQxODncBjTwhP/TYDCUUMfj qZqtfnXTCnceqeHQRiHYRSBcZBBqxs+oDD9qA1WpbTARLBb1P77fC6+mPoyKnnJH8uX3 gUQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712798875; x=1713403675; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=FCNUo3xMZhX35zfHZziIkwXqPGkz8Qu/w3n5wMfOkBOPDWUe2bc+Xh7ActOynZhkLz NVnaWUdQE1UIruAkqrDA75ppFdHliE0MIpVQwpZEtAq7myWePV8DpSBuTYOfIg9F/vyi e+3ho7IiJmNaRcm7WiuZptf8dNGzQotD8u8CdH7lGxKrvXkP3Vo4BFBvSliODPd882jz irGseXEUkOfCWA1aeUro821sccB3c1LkxHKrneUWPgTwRlK71uS8ovpBM/80EwwXD5mC hh9U7UpD97EGzQ1EDScmbyuq0lCMlM3V8vtBIUzfpFwjvFS75klp57wDv/2cFqcG8AKK FnKw== X-Forwarded-Encrypted: i=1; AJvYcCUZcjbWTb/9LKp3KoAdhiV+S88FtiLzzQewk9pRl9HnIRqbXdpxXYA8OQWVsh4Yc5EX+foDWiO0PFMqXvtbc/BGYOWuNQvB1BMLeQqiUoFK X-Gm-Message-State: AOJu0Yw+hjkUOlCyg4xULOkXmU5ukaTAJ6Dgdmy9Uymp1vXt6I5T0NP6 b57+yO8REIoOzIRwIVdn1u6/2DdlQn3DjKMP7rC3FhMVGqo3Rm2Ux3AvtiwDEdo= X-Google-Smtp-Source: AGHT+IF8lPPFTalL1WPSfnBvduuYhf5K6F9EIeC9RLCCka0Vl/mHkW4wRauCXJubFXwb7faJCr3ffA== X-Received: by 2002:a05:6870:518:b0:22e:bcfd:deb0 with SMTP id j24-20020a056870051800b0022ebcfddeb0mr4667832oao.41.1712798874921; Wed, 10 Apr 2024 18:27:54 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:fcac:9b42:fe81:c62f]) by smtp.gmail.com with ESMTPSA id c1-20020aa78c01000000b006ed38291aebsm289791pfd.178.2024.04.10.18.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 18:27:54 -0700 (PDT) From: Thiago Jung Bauermann To: Samuel Holland Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT In-Reply-To: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> (Samuel Holland's message of "Wed, 10 Apr 2024 20:11:04 -0500") References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 10 Apr 2024 22:27:52 -0300 Message-ID: <87le5kofhj.fsf@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_182756_859590_472853A3 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hello Samuel, Samuel Holland writes: > On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: >> Samuel Holland writes: >>> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>>> >>>> Unfortunately this patch causes build failures on arm with allyesconfig >>>> and allmodconfig. Tested with next-20240410. >> >> >> >>> In both cases, the issue is that the toolchain requires runtime support to >>> convert between `unsigned long long` and `double`, even when hardware FP is >>> enabled. There was some past discussion about GCC inlining some of these >>> conversions[1], but that did not get implemented. >> >> Thank you for the explanation and the bugzilla reference. I added a >> comment there mentioning that the problem came up again with this patch >> series. >> >>> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >>> 32-bit arm until we can provide these runtime library functions. >> >> Does this mean that patch 2 in this series: >> >> [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT >> >> will be dropped? > > No, because later patches in the series (3, 6) depend on the definition of > CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can > find a GPL-2 compatible implementation of the runtime library functions. Ok, thank you for clarifying. Andrew Pinski just responded on the GCC bugzilla and if I understood his point correctly, it seems to be a matter of changing function names to what GCC (or actually the arm EABI) expects... -- Thiago _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D72D2CD11C2 for ; Thu, 11 Apr 2024 01:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FtBrAgCA4tYATSJL1csIciTqv4mPOsC1LZKWrLFXggg=; b=YKzDA+3fnqSqNR ysvY16cBwYxCurwjPM4YWhw+xKvCZfee3g/KZg1/Y+drMAMsKGbZ1RzS5VwIA3fvgwncISqKOCsDc uny2VK42u0c0yAmuJF6a5n75xYbmWnzJAfXJlVvkpZ6xA4qxzjUD/fKpwptwg4Rf8zJqZFFQ0qekw bu3u19e093/tpE9qGirkXhpsDsSC3gpVC7Usn76DSY1M8ePpokXPZcAi0Gqg/GoRJFo/kGdoQpEWL fe5d60SWKkGeXQiWsBJZcZtd67+epGyycGPn34f9DuRgQi1eZgXDot28lZ7sYwLs1pFCkflDNOglG 9AsbnGwm0+ZmX3N4+yHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rujEN-00000009ptd-19d8; Thu, 11 Apr 2024 01:27:59 +0000 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rujEK-00000009pra-38tz for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2024 01:27:58 +0000 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-222b6a05bb1so4011117fac.3 for ; Wed, 10 Apr 2024 18:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712798875; x=1713403675; darn=lists.infradead.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=Dho5xIqj3rvmtrajHHzEGzF1vndJC/QL869/4K1hYXUcJkWFcMADPuybhhYruQnzRg kC8+B+MgD31+TebFXj20wjPmiXyHWrstnhnJfL/XaoTnWS1MUv2AhSrJb/ii0L64vudj sDhQVUl+UfdeNtSddOjaaZ5qhSxiS1/CXThTkBhmYNiaYk3W6+BTzq3nq+7Ut2RMrKjR eYKln2/OYIfWhWuxQ2ltGiuWzUROD2mxouVysTaW3OriCcQxODncBjTwhP/TYDCUUMfj qZqtfnXTCnceqeHQRiHYRSBcZBBqxs+oDD9qA1WpbTARLBb1P77fC6+mPoyKnnJH8uX3 gUQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712798875; x=1713403675; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=kib7voCUVB6cxSTEhS3sGSuQKf0kxqXOknHOt9cPFakzc6z8XdS3PVyHS4T+hYdCHt T97BVYadlK8jZTTh6sSsXjEyVzByO7PAkbKIMbiOq7A9oAO/NIFPkzXLwFzStcG5I1Ao nVyd52t85IrE/lnTRgxDHLlBNf7J4IyLWvvDs28MsgWn+Dfo13wyo3umCYqy8xf4HNv3 Qbx6jcilQn7bTaj6pvOb6J2bVG2EsXmYrGesf8SugCvDqcC5bu5iMiAKgGP9G5YMhA4I mofXztm1AE57NKIKBetbRGcUO+w/rwZVmHpxWgO+sr3qHbNjgvOarB7+bEsglN/sDxw3 hgBA== X-Forwarded-Encrypted: i=1; AJvYcCWbLW4cM4qUtADpr3j/Cb0c+AuaOfWhq9wr1kfSAzPbEOVK9JSdxKKnk/LMRP9LoccJVGG0gChymuoENoxNLA/jOE+LbO5rxBsNYKkf1l0MUdoYHlM= X-Gm-Message-State: AOJu0YxK8gMLRFVunndRbsQtNvY366u0bg/bNTA0dLJv8MN5ft/76USB /LAyaSI3RY0kdhgtHL0z6A+1LWEzb4ubXBnEntHvXqgzm2Ad9NUEypn2xLfpOhk= X-Google-Smtp-Source: AGHT+IF8lPPFTalL1WPSfnBvduuYhf5K6F9EIeC9RLCCka0Vl/mHkW4wRauCXJubFXwb7faJCr3ffA== X-Received: by 2002:a05:6870:518:b0:22e:bcfd:deb0 with SMTP id j24-20020a056870051800b0022ebcfddeb0mr4667832oao.41.1712798874921; Wed, 10 Apr 2024 18:27:54 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:fcac:9b42:fe81:c62f]) by smtp.gmail.com with ESMTPSA id c1-20020aa78c01000000b006ed38291aebsm289791pfd.178.2024.04.10.18.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 18:27:54 -0700 (PDT) From: Thiago Jung Bauermann To: Samuel Holland Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT In-Reply-To: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> (Samuel Holland's message of "Wed, 10 Apr 2024 20:11:04 -0500") References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 10 Apr 2024 22:27:52 -0300 Message-ID: <87le5kofhj.fsf@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_182756_872754_CBDF46D9 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Samuel, Samuel Holland writes: > On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: >> Samuel Holland writes: >>> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>>> >>>> Unfortunately this patch causes build failures on arm with allyesconfig >>>> and allmodconfig. Tested with next-20240410. >> >> >> >>> In both cases, the issue is that the toolchain requires runtime support to >>> convert between `unsigned long long` and `double`, even when hardware FP is >>> enabled. There was some past discussion about GCC inlining some of these >>> conversions[1], but that did not get implemented. >> >> Thank you for the explanation and the bugzilla reference. I added a >> comment there mentioning that the problem came up again with this patch >> series. >> >>> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >>> 32-bit arm until we can provide these runtime library functions. >> >> Does this mean that patch 2 in this series: >> >> [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT >> >> will be dropped? > > No, because later patches in the series (3, 6) depend on the definition of > CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can > find a GPL-2 compatible implementation of the runtime library functions. Ok, thank you for clarifying. Andrew Pinski just responded on the GCC bugzilla and if I understood his point correctly, it seems to be a matter of changing function names to what GCC (or actually the arm EABI) expects... -- Thiago _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB2FFCD11C2 for ; Thu, 11 Apr 2024 01:28:48 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZlSs7Avy; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VFMXv4CGrz3vXr for ; Thu, 11 Apr 2024 11:28:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZlSs7Avy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2001:4860:4864:20::34; helo=mail-oa1-x34.google.com; envelope-from=thiago.bauermann@linaro.org; receiver=lists.ozlabs.org) Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VFMX414dtz3cM4 for ; Thu, 11 Apr 2024 11:28:02 +1000 (AEST) Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-2330f85c2ebso752644fac.1 for ; Wed, 10 Apr 2024 18:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712798875; x=1713403675; darn=lists.ozlabs.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=ZlSs7AvyTsKL75V1yGmur0c/FLJn/UHceAdUYm4oahOXGAi5j8PI3Ml+68hwLckgOa dhRKOqSiL2/Mu6vOD/6jcFQ9f69fxqUIjZoQ4yNcLEq+SWpMm1o8H1YHovsBKik3ixpV s6UDMaX6ChcTzkrhST+z6+vXFSfoGH2s3gRkKQ+IUhIUGMArCTxGZwisj5uAKP0xbk78 18UbKmUMNgQ++upicoOzWg7yYeu979uBiKx11NFMUyxI+1FIndLGPAiv+SprrZze/pg6 orTIFRN3PVvXJhfa5JdBcfUllCEJGpSXu/XQfSqXtoaXnGSMMfIEbEtQ2zAYZMBxZz4o pCEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712798875; x=1713403675; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zY1vBuYzXUVAUPu7RYDaF9UtFORvIFjy44r4Y5Ige4g=; b=nry27vhpu/drKVKmkTHnqOUQgzmwdhz++AHBAuH8oJjlwPCDVzCf67tc5PVtobkcTy ZYjiV6XiGprVLXQOoRH4av7faa4dT33jxX+eIccLDHAi1bKICq9DaZbowhCNc1GNPFfJ epe4uZu/oYY2Xc1Yuj80ihVAb15ijhDTTtAuCR9MHoQFZL2Ybg6yJxJPWgZKMjmpIybb IhCfO1oTcxEDUtBtHGYZDCyUbbMsDsTp3/i8bLYzhtEPAhZRpO2RxQIXu4EJnYNI1q9b j3VqDUUBedeXdstybb4BXKTeGtB7SOLJYdZVekM0mU2pWr9Osrh9Z+k3xm/cO4J1jGUT 8oFQ== X-Forwarded-Encrypted: i=1; AJvYcCX6owenpNqwyB8Ug2vD3RncnuX7ZTY5W0PGXiQgD829qnpIoEiIba7VU/Ib6z5N5ywhRlZhbLGIpA/TjXO7p3VhtCGBydetQRGZDwISJg== X-Gm-Message-State: AOJu0Yx3IghLwRZgaJUMaMgizddnI4eMSjdTHDVJkEIIkO316cH0B0Cv Qt0KsaEdkeGup0Giq4fz0/QT0jXIiByAWMeruUJpJG00iYwXTl3LzbYwSIQSGaA= X-Google-Smtp-Source: AGHT+IF8lPPFTalL1WPSfnBvduuYhf5K6F9EIeC9RLCCka0Vl/mHkW4wRauCXJubFXwb7faJCr3ffA== X-Received: by 2002:a05:6870:518:b0:22e:bcfd:deb0 with SMTP id j24-20020a056870051800b0022ebcfddeb0mr4667832oao.41.1712798874921; Wed, 10 Apr 2024 18:27:54 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:fcac:9b42:fe81:c62f]) by smtp.gmail.com with ESMTPSA id c1-20020aa78c01000000b006ed38291aebsm289791pfd.178.2024.04.10.18.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 18:27:54 -0700 (PDT) From: Thiago Jung Bauermann To: Samuel Holland Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT In-Reply-To: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> (Samuel Holland's message of "Wed, 10 Apr 2024 20:11:04 -0500") References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 10 Apr 2024 22:27:52 -0300 Message-ID: <87le5kofhj.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , loongarch@lists.linux.dev, Alex Deucher , Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello Samuel, Samuel Holland writes: > On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: >> Samuel Holland writes: >>> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>>> >>>> Unfortunately this patch causes build failures on arm with allyesconfig >>>> and allmodconfig. Tested with next-20240410. >> >> >> >>> In both cases, the issue is that the toolchain requires runtime support to >>> convert between `unsigned long long` and `double`, even when hardware FP is >>> enabled. There was some past discussion about GCC inlining some of these >>> conversions[1], but that did not get implemented. >> >> Thank you for the explanation and the bugzilla reference. I added a >> comment there mentioning that the problem came up again with this patch >> series. >> >>> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >>> 32-bit arm until we can provide these runtime library functions. >> >> Does this mean that patch 2 in this series: >> >> [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT >> >> will be dropped? > > No, because later patches in the series (3, 6) depend on the definition of > CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can > find a GPL-2 compatible implementation of the runtime library functions. Ok, thank you for clarifying. Andrew Pinski just responded on the GCC bugzilla and if I understood his point correctly, it seems to be a matter of changing function names to what GCC (or actually the arm EABI) expects... -- Thiago