From: Peter Korsgaard <peter@korsgaard.com>
To: Sen Hastings <sen@hastings.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/scripts/pkg-stats: fix bug when sorting by hashfile
Date: Thu, 02 May 2024 18:29:59 +0200 [thread overview]
Message-ID: <87ikzw5g8o.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240225220544.754965-1-sen@hastings.org> (Sen Hastings's message of "Sun, 25 Feb 2024 14:05:44 -0800")
>>>>> "Sen" == Sen Hastings <sen@hastings.org> writes:
> Because the div_class variable was not reassigned a value,
> cells in the latest_version column were still being assigned
> hash_file classes and so were being picked up as elements in
> the hash_file sort. This lead to execessive grid gap elements
> stacking up and creating huge blank spaces at the top of the page.
> This is very noticable on pages with a large number of packages,
> like the ones the autobuilder creates.
> original behaviour(click the "Hash file" column label twice):
> http://autobuild.buildroot.org/stats/master.html
> demo of fixed behaviour:
> https://sen-h.codeberg.page/pkg-stats-demos/@pages/fix-bug-when-sorting-by-hash-file.html
> Signed-off-by: Sen Hastings <sen@hastings.org>
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-02 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 22:05 [Buildroot] [PATCH 1/1] support/scripts/pkg-stats: fix bug when sorting by hashfile Sen Hastings
2024-04-07 16:00 ` Arnout Vandecappelle via buildroot
2024-05-02 16:29 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikzw5g8o.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=sen@hastings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.