From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89A0912CDA6; Mon, 25 Mar 2024 14:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711377869; cv=none; b=fNT4ZelxTxin8X49u0675JO/DKLeviIYclm64/GOs1Eq6X2DI8YUt8z/fdc1TUF9yUnQ52OTD8jKRMxQk7xnJaeuNCCAfNonfAhTD37V2Wd0gx1OinUPw3eC6lNOHAJPFIwUjSGf337xh/TjT8Zv+wqTa3zPGbTIrg5UEcCsVQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711377869; c=relaxed/simple; bh=fU/W0oKSN3xGYgX5HM/CxAUkFuyJb32zow9lsYvfY4M=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=C6PelP0enjBv7nDUlHFFfwVeoJOHCZjdIQTwT/1tEOvyLom4O7SIrmfXXI1kA4myOuX5Kmutby5KVLBHdp7d/tKD7aWwlwY/8+vq44AGnnZMGoACQaNoboLFzZjEYWL20Iysxmnu9n/w2uCeOD2X1Khu3jREb0E6jO5bK/GdNv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=DHSK08Xp; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uXWNbUCp; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=DHSK08Xp; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uXWNbUCp; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DHSK08Xp"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uXWNbUCp"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DHSK08Xp"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uXWNbUCp" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 96FA434606; Mon, 25 Mar 2024 14:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711377865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FaAsu/bkUs1MMLvqQxw69AEv/iUAnpo7imQC4mE4YLM=; b=DHSK08Xp7o4xg3JPSAWZKyCeb/25iAceNyR6EZOMXgwc2LniAOOdyhZrqNg2VnZQlUEL1m NKu/GTA9jXPp6v+izBslWKbr10/+A2dVlI6l9UtVL3BXz8zO/uPOL/AUtuZOcH5FW8SBZP +Vw31ME6RXv/nup/OCw7e7lcDikMer8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711377865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FaAsu/bkUs1MMLvqQxw69AEv/iUAnpo7imQC4mE4YLM=; b=uXWNbUCpOm7z+XztXYLDvk5YvJnE1IzgU0D03vN8Zl2kBya/zmXm/glFEsvMtsrTHmTKoe T5QvpGJhM3P1DBDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711377865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FaAsu/bkUs1MMLvqQxw69AEv/iUAnpo7imQC4mE4YLM=; b=DHSK08Xp7o4xg3JPSAWZKyCeb/25iAceNyR6EZOMXgwc2LniAOOdyhZrqNg2VnZQlUEL1m NKu/GTA9jXPp6v+izBslWKbr10/+A2dVlI6l9UtVL3BXz8zO/uPOL/AUtuZOcH5FW8SBZP +Vw31ME6RXv/nup/OCw7e7lcDikMer8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711377865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FaAsu/bkUs1MMLvqQxw69AEv/iUAnpo7imQC4mE4YLM=; b=uXWNbUCpOm7z+XztXYLDvk5YvJnE1IzgU0D03vN8Zl2kBya/zmXm/glFEsvMtsrTHmTKoe T5QvpGJhM3P1DBDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5FFEA13503; Mon, 25 Mar 2024 14:44:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id NaPuFcmNAWb0ewAAD6G6ig (envelope-from ); Mon, 25 Mar 2024 14:44:25 +0000 Date: Mon, 25 Mar 2024 15:44:26 +0100 Message-ID: <874jcuxtf9.wl-tiwai@suse.de> From: Takashi Iwai To: duoming@zju.edu.cn Cc: "Takashi Iwai" , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, tiwai@suse.com, perex@perex.cz Subject: Re: [PATCH] ALSA: sh: aica: reorder cleanup operations to avoid UAF bug In-Reply-To: <43e102f3.61dc.18e7601a2f2.Coremail.duoming@zju.edu.cn> References: <20240325033946.47052-1-duoming@zju.edu.cn> <871q7yybeb.wl-tiwai@suse.de> <43e102f3.61dc.18e7601a2f2.Coremail.duoming@zju.edu.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -3.30 X-Spamd-Result: default: False [-3.30 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: Authentication-Results: smtp-out1.suse.de; none X-Spam-Flag: NO On Mon, 25 Mar 2024 15:26:42 +0100, duoming@zju.edu.cn wrote: > > On Mon, 25 Mar 2024 09:16:12 +0100 Takashi Iwai wrote: > > > The dreamcastcard->timer could schedule the spu_dma_work and the > > > spu_dma_work could also arm the dreamcastcard->timer. > > > > > > When the Yamaha AICA card is closing, the dreamcastcard->channel > > > will be deallocated. But it could still be dereferenced in the > > > worker thread. The reason is that del_timer() will return directly > > > regardless of whether the timer handler is running or not and the > > > worker could be rescheduled in the timer handler. As a result, the > > > UAF bug will happen. The racy situation is shown below: > > > > > > (Thread 1) | (Thread 2) > > > snd_aicapcm_pcm_close() | > > > ... | run_spu_dma() //worker > > > | mod_timer() > > > flush_work() | > > > del_timer() | aica_period_elapsed() //timer > > > kfree(dreamcastcard->channel) | schedule_work() > > > | run_spu_dma() //worker > > > ... | dreamcastcard->channel-> //USE > > > > > > In order to mitigate this bug, use timer_shutdown_sync() to shutdown > > > the timer and then use flush_work() to cancel the worker. > > > > > > Fixes: 198de43d758c ("[ALSA] Add ALSA support for the SEGA Dreamcast PCM device") > > > Signed-off-by: Duoming Zhou > > > --- > > > sound/sh/aica.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sound/sh/aica.c b/sound/sh/aica.c > > > index 320ac792c7f..bc68a3903f2 100644 > > > --- a/sound/sh/aica.c > > > +++ b/sound/sh/aica.c > > > @@ -354,8 +354,8 @@ static int snd_aicapcm_pcm_close(struct snd_pcm_substream > > > *substream) > > > { > > > struct snd_card_aica *dreamcastcard = substream->pcm->private_data; > > > + timer_shutdown_sync(&dreamcastcard->timer); > > > > I thought this call invalidates the timer object, hence it can't be > > used again; i.e. it breaks when the stream is re-opened, I suppose? > > > > In general timer_shutdown*() is used for the code path to clean up the > > driver (or the object the timer belongs to). The PCM close is only > > about the PCM stream, and it's not the place. > > > > A proper fix would be rather to implement two things: > > - Call mod_timer() conditionally in run_spu_dma() > > - Implement PCM sync_stop op to cancel/flush the work > > > > The former alone should suffice to fix the UAF in your scenario, > > though. The latter will cover other possible corner cases. > > Thank you for your time and reply! I know using timer_shutdown_sync() > is not proper. In order to solve the problem, I add a shutdown flag > in the struct snd_card_aica and set the flag to true when the PCM > stream is closing. Then call mod_timer() conditionally in run_spu_dma(). > What's more, use del_timer_sync() to stop the timer and put it before > flush_work(). As a result, both timer and worker could be stopped safely. > The detail is shown below: You can use the existing API to check the PCM running state, e.g. --- a/sound/sh/aica.c +++ b/sound/sh/aica.c @@ -278,7 +278,8 @@ static void run_spu_dma(struct work_struct *work) dreamcastcard->clicks++; if (unlikely(dreamcastcard->clicks >= AICA_PERIOD_NUMBER)) dreamcastcard->clicks %= AICA_PERIOD_NUMBER; - mod_timer(&dreamcastcard->timer, jiffies + 1); + if (snd_pcm_running(dreamcastcard->substream)) + mod_timer(&dreamcastcard->timer, jiffies + 1); } } HTH, Takashi