From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755636AbYEIIaf (ORCPT ); Fri, 9 May 2008 04:30:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752287AbYEIIaR (ORCPT ); Fri, 9 May 2008 04:30:17 -0400 Received: from smtp-out03.alice-dsl.net ([88.44.63.5]:59561 "EHLO smtp-out03.alice-dsl.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbYEIIaP (ORCPT ); Fri, 9 May 2008 04:30:15 -0400 To: Linus Torvalds Cc: Alan Cox , Ingo Molnar , "Zhang, Yanmin" , Matthew Wilcox , LKML , Alexander Viro , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" Subject: Re: [patch] speed up / fix the new generic semaphore code (fix AIM7 40% regression with 2.6.26-rc1) From: Andi Kleen References: <1210214696.3453.87.camel@ymzhang> <1210219729.3453.97.camel@ymzhang> <20080508120130.GA2860@elte.hu> <20080508122802.GA4880@elte.hu> <20080508201956.GA2547@elte.hu> <20080508214557.GA13311@elte.hu> <20080509001647.244393bc@core> Date: Fri, 09 May 2008 10:29:14 +0200 In-Reply-To: (Linus Torvalds's message of "Thu, 8 May 2008 16:33:40 -0700 (PDT)") Message-ID: <871w4bnan9.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 09 May 2008 08:22:17.0385 (UTC) FILETIME=[CB088190:01C8B1AD] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds writes: > > Well, it turns out that Ingo's fixed statistics actually put the real cost > in fcntl/ioctl/open/release: > > 310 down <= lock_kernel <= sys_fcntl <= system_call_after_swapgs < That must be ->fasync? If it was file locks the lock_kernel would not be inlined into sys_fcntl. Or is that an truncated back trace? -Andi (wondering if he should plug ->fasync_unlocked again ...)