* [PATCH] target/i386: Add the 'model-id' for Skylake -v3 CPU models
@ 2020-01-23 9:01 Kashyap Chamarthy
2020-01-23 9:27 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Kashyap Chamarthy @ 2020-01-23 9:01 UTC (permalink / raw
To: qemu-devel; +Cc: pbonzini, Kashyap Chamarthy, berrange, ehabkost, rth
This fixes a confusion in the help output. (Although, if you squint
long enough at the '-cpu help' output, you _do_ notice that
"Skylake-Client-noTSX-IBRS" is an alias of "Skylake-Client-v3";
similarly for Skylake-Server-v3.)
Without this patch:
$ qemu-system-x86 -cpu help
...
x86 Skylake-Client-v1 Intel Core Processor (Skylake)
x86 Skylake-Client-v2 Intel Core Processor (Skylake, IBRS)
x86 Skylake-Client-v3 Intel Core Processor (Skylake, IBRS)
...
x86 Skylake-Server-v1 Intel Xeon Processor (Skylake)
x86 Skylake-Server-v2 Intel Xeon Processor (Skylake, IBRS)
x86 Skylake-Server-v3 Intel Xeon Processor (Skylake, IBRS)
...
With this patch:
$ ./qemu-system-x86 -cpu help
...
x86 Skylake-Client-v1 Intel Core Processor (Skylake)
x86 Skylake-Client-v2 Intel Core Processor (Skylake, IBRS)
x86 Skylake-Client-v3 Intel Core Processor (Skylake, IBRS, no TSX)
...
x86 Skylake-Server-v1 Intel Xeon Processor (Skylake)
x86 Skylake-Server-v2 Intel Xeon Processor (Skylake, IBRS)
x86 Skylake-Server-v3 Intel Xeon Processor (Skylake, IBRS, no TSX)
...
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
---
target/i386/cpu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 41f28cebf946c7dd77a066eac55623a7370730d5..821cab7f2a4eda43631359a95f7b3bb301b9788f 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -2905,6 +2905,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
.props = (PropValue[]) {
{ "hle", "off" },
{ "rtm", "off" },
+ { "model-id",
+ "Intel Core Processor (Skylake, IBRS, no TSX)" },
{ /* end of list */ }
}
},
@@ -3028,6 +3030,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
.props = (PropValue[]) {
{ "hle", "off" },
{ "rtm", "off" },
+ { "model-id",
+ "Intel Xeon Processor (Skylake, IBRS, no TSX)" },
{ /* end of list */ }
}
},
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] target/i386: Add the 'model-id' for Skylake -v3 CPU models
2020-01-23 9:01 [PATCH] target/i386: Add the 'model-id' for Skylake -v3 CPU models Kashyap Chamarthy
@ 2020-01-23 9:27 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-01-23 9:27 UTC (permalink / raw
To: Kashyap Chamarthy, qemu-devel; +Cc: berrange, ehabkost, rth
On 23/01/20 10:01, Kashyap Chamarthy wrote:
> This fixes a confusion in the help output. (Although, if you squint
> long enough at the '-cpu help' output, you _do_ notice that
> "Skylake-Client-noTSX-IBRS" is an alias of "Skylake-Client-v3";
> similarly for Skylake-Server-v3.)
>
> Without this patch:
>
> $ qemu-system-x86 -cpu help
> ...
> x86 Skylake-Client-v1 Intel Core Processor (Skylake)
> x86 Skylake-Client-v2 Intel Core Processor (Skylake, IBRS)
> x86 Skylake-Client-v3 Intel Core Processor (Skylake, IBRS)
> ...
> x86 Skylake-Server-v1 Intel Xeon Processor (Skylake)
> x86 Skylake-Server-v2 Intel Xeon Processor (Skylake, IBRS)
> x86 Skylake-Server-v3 Intel Xeon Processor (Skylake, IBRS)
> ...
>
> With this patch:
>
> $ ./qemu-system-x86 -cpu help
> ...
> x86 Skylake-Client-v1 Intel Core Processor (Skylake)
> x86 Skylake-Client-v2 Intel Core Processor (Skylake, IBRS)
> x86 Skylake-Client-v3 Intel Core Processor (Skylake, IBRS, no TSX)
> ...
> x86 Skylake-Server-v1 Intel Xeon Processor (Skylake)
> x86 Skylake-Server-v2 Intel Xeon Processor (Skylake, IBRS)
> x86 Skylake-Server-v3 Intel Xeon Processor (Skylake, IBRS, no TSX)
> ...
>
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> ---
> target/i386/cpu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 41f28cebf946c7dd77a066eac55623a7370730d5..821cab7f2a4eda43631359a95f7b3bb301b9788f 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -2905,6 +2905,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
> .props = (PropValue[]) {
> { "hle", "off" },
> { "rtm", "off" },
> + { "model-id",
> + "Intel Core Processor (Skylake, IBRS, no TSX)" },
> { /* end of list */ }
> }
> },
> @@ -3028,6 +3030,8 @@ static X86CPUDefinition builtin_x86_defs[] = {
> .props = (PropValue[]) {
> { "hle", "off" },
> { "rtm", "off" },
> + { "model-id",
> + "Intel Xeon Processor (Skylake, IBRS, no TSX)" },
> { /* end of list */ }
> }
> },
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-23 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-23 9:01 [PATCH] target/i386: Add the 'model-id' for Skylake -v3 CPU models Kashyap Chamarthy
2020-01-23 9:27 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.