From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE692C48BDF for ; Thu, 10 Jun 2021 10:11:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6B8B6023E for ; Thu, 10 Jun 2021 10:11:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6B8B6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CF0B82CBE; Thu, 10 Jun 2021 12:11:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="aZRNvgin"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 64D2182D15; Thu, 10 Jun 2021 12:11:42 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 773ED819C3 for ; Thu, 10 Jun 2021 12:11:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623319898; bh=EAAIJJtoBA5nFxnTrtbWKhHzNq1POXv4xdCKOUflPbc=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=aZRNvgin3KqD1tX5i4MIwyj/VxRzA19gUiHWSi0av/qGxXfq5pDA11MIGcDrB1Gql KhWvvhEe76ZrFNMCY4mX0ACjeZiFv5dHFW0ONwj/ZQMX9I3sjRQBYA5s31iUavdc7H gim6HkdaAclajNTLzr0bEy1KSg4q7fz9xja6NPrQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([62.143.247.63]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N33Il-1lC4gB0DqX-013NLz; Thu, 10 Jun 2021 12:11:38 +0200 Subject: Re: [PATCH] smbios: Fix BIOS Characteristics Extension Byte 2 To: Ilias Apalodimas Cc: Bin Meng , Simon Glass , Christian Gmeiner , u-boot@lists.denx.de References: <20210609151448.828133-1-ilias.apalodimas@linaro.org> From: Heinrich Schuchardt Message-ID: <838cf80e-1a3f-3ff0-65ce-d7676ec80c87@gmx.de> Date: Thu, 10 Jun 2021 12:11:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210609151448.828133-1-ilias.apalodimas@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Bq3fkmKVzfLQIAAcURrIBgcEuwX907oGTil7I77RISX+3Y8Pocw o6SnRZyTS3fudigMAOPFM9X7ZMjbsHsFjc7CaNRZdv8D5ZppC6y59ORbRbw8Y3QoDxZU6/7 TJPHOr3SuQFRRQi9EDSvk9JZI1HAG1zrPFocB72kndgy3m2Kqnkb/2ja60bCKE01tpR3ora vqMqEM8u4yjGXFSItNWxQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:JZ8Ew70iwJs=:vYNV4n4raPGzRc3VjAHbhn zG5w59oCOykVAn2hCA4AMm6iOMJZEorvoIWhTS7xyfbJFHkqeTYz/g7FAhhuyI2I/qKtAsfen P0Ji//r9fiouRvVfRFL5RPexJMTg6CnOPwgOd623IJ74FEW0amq8yETFs2cjpq21biNzi+YMS SDZqUu8sqIFNhtiqIClV1o8vPZwbZlDq8Y4plM5kivg9BbHd8jUmYxHUaP3gB168fiz4IAS2L BH8EgoVJyAhiXLN5fR1pHO/OMAqLV8INoGJYlM2BMxloEPUydiqr/kAbs5ieNpwmk5+9RX3F5 J68yi803Wy8YByAsagIsQRIC7gQW1pOWzEEqErlaazHs2oSUBFWOAKZq3Z5Iw9YGmLmngL6HT 6pgSmJ5NCw3h9Ln4JacSng0RthSgrYbDWMkvW64aa7ku3rKvt8XkUrlrod0W02x+6RKx8aCqE TRA5C8rB9+K6aF5oVTfKbyxc2Jy1g4Jw3IM3mgH6Yllc44QyAreQRUG2mO5d6arTe2SReEAez YpxjQ8vgYPVZdpVC/YekcCvTOHYtq0daK6rbMI9ed8aSXKEJUIKDmm/fnwziG6Us2XCxu32ab QSD7KSTIpbJDKwqtvGn/E6KWfuUb81r7mypdAMxXC3dgsFO2iCnMRry7ajAYRUZwKXEwzUiZy eSamaZljvuk3X0k7HCdQwoQZ3Fg6sGf/IiSizGtwPz4HNqwYiNoA7S5nVxEu6yy0kTF9oKq7B hIQxjUjt9yazMekW1ozaomakk6C9KEnzYt9S+aReBufD9zN8o9dpJmmSKejuLahHvhmjohH9x jsl4Oare/E5OZ8iRoKrvw8RM0n0jraq2TpDtsPcZvmrLqcAO6dxaNG3ICvmGa+5AH0MuDLI7C lnm0GpnLwex5mjnh9+8aOvj75xfRih5mikh5ZTGQH8MtHmd1KKPckkAC6KBiErcXisg7PKf1T vYh1cMa1BVmctCA4o9Pwoae+a9SRvcgTmJmEl4KXnCv4DgzDLkzASjI6sLxLwPyOvbfrJ+hxl 10CaYvWpnRFs1zH7jOHEzCRypzfLUuqQrN5T2hdIsrrViYD+ChIfDQblkdFOZewfGcf1gRYC+ iTNziC65W9t6vegPHHqRntpgr/YEpiQyEQ1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 6/9/21 5:14 PM, Ilias Apalodimas wrote: > We currently define the EFI support of an SMBIOS table as the third bit = of > "BIOS Characteristics Extension Byte 1". The latest DMTF spec defines i= t > on "BIOS Characteristics Extension Byte 2". > > Signed-off-by: Ilias Apalodimas > --- > include/smbios.h | 2 +- > lib/smbios.c | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/smbios.h b/include/smbios.h > index ffeefb47372d..fc49fc10b9d7 100644 > --- a/include/smbios.h > +++ b/include/smbios.h > @@ -60,7 +60,7 @@ struct __packed smbios_entry { > #define BIOS_CHARACTERISTICS_SELECTABLE_BOOT (1 << 16) > > #define BIOS_CHARACTERISTICS_EXT1_ACPI (1 << 0) > -#define BIOS_CHARACTERISTICS_EXT1_UEFI (1 << 3) > +#define BIOS_CHARACTERISTICS_EXT2_UEFI (1 << 3) > #define BIOS_CHARACTERISTICS_EXT2_TARGET (1 << 2) > > struct __packed smbios_type0 { > diff --git a/lib/smbios.c b/lib/smbios.c > index 9eb226ec9fbd..abdd157a7084 100644 > --- a/lib/smbios.c > +++ b/lib/smbios.c > @@ -214,6 +214,7 @@ static int smbios_write_type0(ulong *current, int ha= ndle, > gd->smbios_version =3D ctx->last_str; > log_debug("smbios_version =3D %p: '%s'\n", gd->smbios_version, > gd->smbios_version); > + t->bios_characteristics_ext2 =3D 0; > #ifdef LOG_DEBUG > print_buffer((ulong)gd->smbios_version, gd->smbios_version, > 1, strlen(gd->smbios_version) + 1, 0); > @@ -229,9 +230,9 @@ static int smbios_write_type0(ulong *current, int ha= ndle, > t->bios_characteristics_ext1 =3D BIOS_CHARACTERISTICS_EXT1_ACPI; This looks fishy. Where is t->bios_characteristics_ext1 initialized if CONFIG_GENERATE_ACPI_TABLE=3Dn? efi_smbios_register() does not zero out the memory. We should initialize the field irrespective of the configuration and then use a bitwise or here. > #endif > #ifdef CONFIG_EFI_LOADER > - t->bios_characteristics_ext1 |=3D BIOS_CHARACTERISTICS_EXT1_UEFI; > + t->bios_characteristics_ext2 |=3D BIOS_CHARACTERISTICS_EXT2_UEFI; > #endif > - t->bios_characteristics_ext2 =3D BIOS_CHARACTERISTICS_EXT2_TARGET; > + t->bios_characteristics_ext2 |=3D BIOS_CHARACTERISTICS_EXT2_TARGET; Where is t->bios_characteristics_ext2 initialized? We don't want random bytes. @Simon: The usage of ulong instead of pointers in this module does not make sense to me. If the sandbox needs to call it, it should map its virtual addresses. We should not spill those conversion into non-sandbox code. Best regards Heinrich > > /* bios_major_release has only one byte, so drop century */ > t->bios_major_release =3D U_BOOT_VERSION_NUM % 100; >