From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B50C3C4345F for ; Mon, 29 Apr 2024 08:24:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F27D410FBAC; Mon, 29 Apr 2024 08:24:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="K5XSw7WV"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by gabe.freedesktop.org (Postfix) with ESMTPS id D452D10FB24 for ; Mon, 29 Apr 2024 08:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2LHdLLOgPo70H60eXhVxWLa/iJAKo65PM3IbKoXY6Zs=; b=K5XSw7WVqGiIoIiGjpDNjld2UM OVD9uUBffcoDYYulYuu80kqs4bWXopQLDAdOUybUXtZe5zNZ6cuxPmUkypKCgJhg0A18je+PoCf5y Js8IEFzZUO9Y+zlAp2l1HuWlb6ieZroVwoFR5A3IZOKomp75TuR2mSdTqBG9owLYNU5qcfR5R8SkV iA2f+0ZYjCTGSu49eY/Gmt/31hRTvgsr5V7McZ8vHOpy/+eM1k8LPcXhte444xgf2ToqDfH9jdQZU QCk6200j37AuzJnTGaoW9rUpn8rETnNFyGrX8/3WHSeKZdTWhz3usW3OexGrJ+GkrwOw6Z9TUG5cW fK7M9mAg==; Received: from [84.65.0.132] (helo=[192.168.0.101]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1s1MIs-001E6j-0u; Mon, 29 Apr 2024 10:24:01 +0200 Message-ID: <804c7344-5cfa-44d3-9ef9-685369cc5019@igalia.com> Date: Mon, 29 Apr 2024 09:24:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/8] drm/v3d: Add modparam for turning off Big/Super Pages Content-Language: en-GB To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Melissa Wen , Iago Toral , Tvrtko Ursulin , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, kernel-dev@igalia.com References: <20240428124426.309096-1-mcanal@igalia.com> <20240428124426.309096-9-mcanal@igalia.com> From: Tvrtko Ursulin In-Reply-To: <20240428124426.309096-9-mcanal@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28/04/2024 13:40, Maíra Canal wrote: > Add a modparam for turning off Big/Super Pages to make sure that if an > user doesn't want Big/Super Pages enabled, it can disabled it by setting > the modparam to false. > > Signed-off-by: Maíra Canal > --- > drivers/gpu/drm/v3d/v3d_drv.c | 7 +++++++ > drivers/gpu/drm/v3d/v3d_gemfs.c | 5 +++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c > index 28b7ddce7747..1a6e01235df6 100644 > --- a/drivers/gpu/drm/v3d/v3d_drv.c > +++ b/drivers/gpu/drm/v3d/v3d_drv.c > @@ -36,6 +36,13 @@ > #define DRIVER_MINOR 0 > #define DRIVER_PATCHLEVEL 0 > > +/* Only expose the `super_pages` modparam if THP is enabled. */ > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +bool super_pages = true; > +module_param_named(super_pages, super_pages, bool, 0400); > +MODULE_PARM_DESC(super_pages, "Enable/Disable Super Pages support."); > +#endif > + > static int v3d_get_param_ioctl(struct drm_device *dev, void *data, > struct drm_file *file_priv) > { > diff --git a/drivers/gpu/drm/v3d/v3d_gemfs.c b/drivers/gpu/drm/v3d/v3d_gemfs.c > index 31cf5bd11e39..0ade02bb7209 100644 > --- a/drivers/gpu/drm/v3d/v3d_gemfs.c > +++ b/drivers/gpu/drm/v3d/v3d_gemfs.c > @@ -11,6 +11,7 @@ void v3d_gemfs_init(struct v3d_dev *v3d) > char huge_opt[] = "huge=within_size"; > struct file_system_type *type; > struct vfsmount *gemfs; > + extern bool super_pages; > > /* > * By creating our own shmemfs mountpoint, we can pass in > @@ -20,6 +21,10 @@ void v3d_gemfs_init(struct v3d_dev *v3d) > if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > goto err; > > + /* The user doesn't want to enable Super Pages */ > + if (!super_pages) > + goto err; > + > type = get_fs_type("tmpfs"); > if (!type) > goto err; Reviewed-by: Tvrtko Ursulin Regards, Tvrtko