All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Jens Axboe <axboe@kernel.dk>, Yu Kuai <yukuai1@huaweicloud.com>,
	Guangwu Zhang <guazhang@redhat.com>,
	linux-block@vger.kernel.org, io-uring@vger.kernel.org,
	Jeff Moyer <jmoyer@redhat.com>, Ming Lei <ming.lei@redhat.com>,
	Jan Kara <jack@suse.cz>, Paolo Valente <paolo.valente@linaro.org>,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [bug report] BUG: kernel NULL pointer dereference, address: 0000000000000048
Date: Wed, 10 May 2023 11:20:46 +0800	[thread overview]
Message-ID: <7def2fca-c854-f88e-3a77-98a999f7b120@huaweicloud.com> (raw)
In-Reply-To: <1155743b-2073-b778-1ec5-906300e0570a@kernel.dk>

Hi, Jens

在 2023/05/10 10:17, Jens Axboe 写道:
> On 5/9/23 8:00?PM, Yu Kuai wrote:
>> Hi,
>>
>> ? 2023/05/10 9:49, Yu Kuai ??:
>>> Hi,
>>>
>>> ? 2023/05/10 9:29, Yu Kuai ??:
>>>> Hi,
>>>>
>>>> ? 2023/05/10 8:49, Guangwu Zhang ??:
>>>>> Hi,
>>>>>
>>>>> We found this kernel NULL pointer issue with latest
>>>>> linux-block/for-next, please check it.
>>>>>
>>>>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>>>>
>>>>>
>>>>> [  112.483804] BUG: kernel NULL pointer dereference, address: 0000000000000048
>>>
>>> Base on this offset, 0x48 match bio->bi_blkg, so I guess this is because
>>> bio is NULL, so the problem is that passthrough request insert into
>>> elevator.
>>>
>> Sorry that attached patch has some problem, please try this one.
> 
> Let's please fix this in bfq, this isn't a core issue and it's not a
> good idea to work around it there.
> 

I can do that, but I'm not sure because it seems passthrough rq is not
supposed to insert into elevator.

Bfq always expect that bio is not NULL, and before this commit
a327c341dc65 ("blk-mq: fix passthrough plugging"), passthrough rq can
never insert into plug, and therefor passthrough rq can never insert
into elevator.

Thanks,
Kuai



  reply	other threads:[~2023-05-10  3:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10  0:49 [bug report] BUG: kernel NULL pointer dereference, address: 0000000000000048 Guangwu Zhang
2023-05-10  1:29 ` Yu Kuai
2023-05-10  1:49   ` Yu Kuai
2023-05-10  2:00     ` Yu Kuai
2023-05-10  2:17       ` Jens Axboe
2023-05-10  3:20         ` Yu Kuai [this message]
     [not found]           ` <CAGS2=YocNy9PkgRzzRdHAK1gGdjMxzA--PYS=sPrX_nCe4U6QA@mail.gmail.com>
2023-05-10  6:39             ` Ming Lei
2023-05-10  6:55               ` Yu Kuai
2023-05-10 12:08               ` Guangwu Zhang
2023-05-10  4:52       ` Guangwu Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7def2fca-c854-f88e-3a77-98a999f7b120@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=axboe@kernel.dk \
    --cc=guazhang@redhat.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=jmoyer@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=paolo.valente@linaro.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.