From: Mat Martineau <martineau@kernel.org>
To: Geliang Tang <geliang@kernel.org>
Cc: mptcp@lists.linux.dev, Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v9 1/8] selftests/bpf: Add RUN_MPTCP_TEST macro
Date: Thu, 18 Apr 2024 09:42:29 -0700 (PDT) [thread overview]
Message-ID: <79b6295b-7536-9b32-1131-c85fac417698@kernel.org> (raw)
In-Reply-To: <87f974d9431af3018c35cbd4db147ea807e3c451.1713321357.git.tanggeliang@kylinos.cn>
On Wed, 17 Apr 2024, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Each MPTCP subtest tests test__start_subtest(suffix), then invokes
> test_suffix(). It makes sense to add a new macro RUN_MPTCP_TEST to
> simpolify the code.
>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
With
https://patchwork.kernel.org/project/mptcp/patch/cc01abb2882608ac5f719e0f7960aa2a2d9fca41.1713404174.git.tanggeliang@kylinos.cn/,
v9 of the series looks good to apply.
The rest of the series is all "squash-to" patches, but for this first
patch:
Reviewed-by: Mat Martineau <martineau@kernel.org>
> ---
> tools/testing/selftests/bpf/prog_tests/mptcp.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
> index cbdb15922949..c29c81239603 100644
> --- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
> +++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
> @@ -653,12 +653,16 @@ static void test_burst(void)
> mptcp_bpf_burst__destroy(burst_skel);
> }
>
> +#define RUN_MPTCP_TEST(suffix) \
> +do { \
> + if (test__start_subtest(#suffix)) \
> + test_##suffix(); \
> +} while (0)
> +
> void test_mptcp(void)
> {
> - if (test__start_subtest("base"))
> - test_base();
> - if (test__start_subtest("mptcpify"))
> - test_mptcpify();
> + RUN_MPTCP_TEST(base);
> + RUN_MPTCP_TEST(mptcpify);
> if (test__start_subtest("default"))
> test_default();
> if (test__start_subtest("first"))
> --
> 2.40.1
>
>
>
next prev parent reply other threads:[~2024-04-18 16:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 2:38 [PATCH mptcp-next v9 0/8] refactor mptcp bpf tests Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 1/8] selftests/bpf: Add RUN_MPTCP_TEST macro Geliang Tang
2024-04-18 16:42 ` Mat Martineau [this message]
2024-04-17 2:38 ` [PATCH mptcp-next v9 2/8] Squash to "selftests/bpf: Add bpf scheduler test" 1 verify Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 3/8] Squash to "selftests/bpf: Add bpf scheduler test" 2 time Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 4/8] Squash to "selftests/bpf: Add bpf_first scheduler & test" Geliang Tang
2024-04-18 0:23 ` Mat Martineau
2024-04-17 2:38 ` [PATCH mptcp-next v9 5/8] Squash to "selftests/bpf: Add bpf_bkup " Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 6/8] Squash to "selftests/bpf: Add bpf_rr " Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 7/8] Squash to "selftests/bpf: Add bpf_red " Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 8/8] Squash to "selftests/bpf: Add bpf_burst " Geliang Tang
2024-04-17 3:25 ` [PATCH mptcp-next v9 0/8] refactor mptcp bpf tests MPTCP CI
2024-04-19 9:58 ` Matthieu Baerts
2024-04-20 0:18 ` Geliang Tang
2024-04-20 9:12 ` Matthieu Baerts
2024-04-22 7:05 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b6295b-7536-9b32-1131-c85fac417698@kernel.org \
--to=martineau@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.