From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D889C13281D for ; Wed, 10 Apr 2024 22:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712789252; cv=none; b=OzMctTqqt9CSeVWIiqbvCHuVNNlR/h9hGaSjm4/kYDPpYSw3dPQpXsd8AjDrmzrE6r2pXu22K/65iVLsxdy4mD/Vd1gmRy1Cab9u9cCa/yV9asxYU+ZesJ1pYEpzFjWNsXisDniT8gLEFE571T1OJGK9iAeZfxM6u/a4rXlAsto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712789252; c=relaxed/simple; bh=uDU3PtkfpbBDGwJOViI0NFiMEmcXnUAvLCRTEusiKVk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tb6uvKxKCxw7GfD8TjuRSQFmyWjHLoDtWcZ6OSjVeey/aZ6LGqtAqLvItnKYV7FT2XxX+wieP+SRARzxBoUv5zqyEzkBlj+rYEeS3AqXIatR7E51xhE6FWa2rbHTtsbtDR9dHxCaDLW/66bSosftzBsLt2geSYDZAPr/e5T6YxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=InxdgZCZ; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="InxdgZCZ" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-22f746c56a2so1400542fac.0 for ; Wed, 10 Apr 2024 15:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712789250; x=1713394050; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=InxdgZCZ3tXHTxDN2HsO5Qj8K94kQvCrSlHJ4gVr0UU4P7owLbbLzxcN5yVcHFP+NH 4Eo//eSwguEo82JBtG2Ns8sya0EkSysyHOUnfp4ou7S7LpxrV0E0/QTH2BFUeHrT3tLS 6FK5+9wDjmXzugmO/o6KpTcqdkdPrsWKjJMeAd6xg11sz1rsdjl7+8jtGpX1iOxhUgtl d46yk0vjJZDHOsDg5ATxjQOZ8lpMLYa6AaflNtnBZMW50Pa4Ilw6TrhHakgd4TMArPoe 2raTiyl9JBb+KJI0nqedu6OhGlEw5rRKcLgKbZxhizQzUJ/ANVW/8gBvTiTNVsVUK/0V zh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712789250; x=1713394050; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=Bz0lM+9E/xdu9wXFr3FOmVQRT1S102JaRlCSi++2NU87CWxwWryc/68zWCE4dI9EJa yEp/uJ17xpVAZV9URPKLux1OemC5TyPR38vj6MrUtIDKxELGxWgC2/Mq4iKeoioLQyVY AEclFd94vUbzkP8UCYEo1vz0JyciT+/9jNlmCctGAe3sAzCqtC+JXwu6Uegvbb5SdbqS rdtcNx/jfwrrA6OxJop1gbvIhQWWu1gvGAKop/FBIjaFQzNoSaQ7Udu+jvNrYFBUR9xu VXcXoVT3RoIYG6CC03HyjjwWmk4C2Uva7Gz8h3ihc4L9n8p/uISA6E7CmpmtLA6ibj2B kf8g== X-Forwarded-Encrypted: i=1; AJvYcCU1TrAEMSyxItG/AIfTYM5XcTc3pcdzKvGtnxo4nNMB0whwVWnSyJpn0WrlOK3Hhc6vs438xZWre9D1e4WJSGtvNs6qWW7RcyLAfxTk X-Gm-Message-State: AOJu0YzIPnFSxZqCvYuQe4w+efiXWciM+/oKadJuTxvZpv6gdfWE20Xp Zcgbw7uWRirQrYUwvvF6tMgl+iP6agSGRHF3koOvZjfbCHi1TbZvfuPBh7RciAc= X-Google-Smtp-Source: AGHT+IHLiKUoeBUB4OwLHReX4a7dcUh2Eqxld9pK8ip3FgSpidJgLmLzuSWt1Fnkq1wrPVQWu86Qjg== X-Received: by 2002:a05:6871:80a:b0:22d:f859:2225 with SMTP id q10-20020a056871080a00b0022df8592225mr3914938oap.6.1712789249782; Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id lf3-20020a0568700c4300b0022eba51882fsm75970oab.53.2024.04.10.15.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Message-ID: <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> Date: Wed, 10 Apr 2024 17:47:27 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4oo3y.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Thiago, On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: > >> Now that all previously-supported architectures select >> ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead >> of the existing list of architectures. It can also take advantage of the >> common kernel-mode FPU API and method of adjusting CFLAGS. >> >> Acked-by: Alex Deucher >> Reviewed-by: Christoph Hellwig >> Signed-off-by: Samuel Holland > > Unfortunately this patch causes build failures on arm with allyesconfig > and allmodconfig. Tested with next-20240410. > > Error with allyesconfig: > > $ make -j 8 \ > O=$HOME/.cache/builds/linux-cross-arm \ > ARCH=arm \ > CROSS_COMPILE=arm-linux-gnueabihf- > make[1]: Entering directory '/home/bauermann/.cache/builds/linux-cross-arm' > ⋮ > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.o: in function `dcn20_populate_dml_pipes_from_context': > dcn20_fpu.c:(.text+0x20f4): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x210c): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x2124): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x213c): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.o: in function `pipe_ctx_to_e2e_pipe_params': > dcn_calcs.c:(.text+0x390): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.o:dcn_calcs.c:(.text+0x3a4): more undefined references to `__aeabi_l2d' follow > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.o: in function `optimize_configuration': > dml2_wrapper.c:(.text+0xcbc): undefined reference to `__aeabi_d2ulz' > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.o: in function `populate_dml_plane_cfg_from_plane_state': > dml2_translation_helper.c:(.text+0x9e4): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa20): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa58): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa90): undefined reference to `__aeabi_l2d' > make[3]: *** [/home/bauermann/src/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1 > make[2]: *** [/home/bauermann/src/linux/Makefile:1165: vmlinux] Error 2 > make[1]: *** [/home/bauermann/src/linux/Makefile:240: __sub-make] Error 2 > make[1]: Leaving directory '/home/bauermann/.cache/builds/linux-cross-arm' > make: *** [Makefile:240: __sub-make] Error 2 > > The error with allmodconfig is slightly different: > > $ make -j 8 \ > O=$HOME/.cache/builds/linux-cross-arm \ > ARCH=arm \ > CROSS_COMPILE=arm-linux-gnueabihf- > make[1]: Entering directory '/home/bauermann/.cache/builds/linux-cross-arm' > ⋮ > ERROR: modpost: "__aeabi_d2ulz" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "__aeabi_l2d" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > make[3]: *** [/home/bauermann/src/linux/scripts/Makefile.modpost:145: Module.symvers] Error 1 > make[2]: *** [/home/bauermann/src/linux/Makefile:1876: modpost] Error 2 > make[1]: *** [/home/bauermann/src/linux/Makefile:240: __sub-make] Error 2 > make[1]: Leaving directory '/home/bauermann/.cache/builds/linux-cross-arm' > make: *** [Makefile:240: __sub-make] Error 2 In both cases, the issue is that the toolchain requires runtime support to convert between `unsigned long long` and `double`, even when hardware FP is enabled. There was some past discussion about GCC inlining some of these conversions[1], but that did not get implemented. The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for 32-bit arm until we can provide these runtime library functions. Regards, Samuel [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91970 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1BB7CD11C2 for ; Wed, 10 Apr 2024 22:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lFHiRPbE0rnckKs1hGDLrYEb1q+PR/J6TbG6BfeVQAQ=; b=Mnu8bbDI4twjHV XibNRxEw0md+jpCBKsGMjMjGKVQrLvz7d7MLhYbMYP0RUGoP2AHHkml8X0czn79u3X4a3L0ShuRQA nV4vRiU5NE1sBJF2uVfoj9iGT42enP1J2ia2C1FLjB699WO9h2HK8OmI5qLKcW5/YWkGzG6CbSpbf nvfHDvn8SfatAo3eoBW/IZhXtp5R8pPgJ2uwrMAAIyiezZ4+drUHPiszSu+dtrbu9BXb9AEgGJyXM Lb8JpFVi2/i2m3bY38pSffeFfp3AlyGw/aEApUhZ2YWdGvN/qJQS6Oq+Nu3drRsIXTTMC63AHxuZ5 01w11ot2yeCx7b/QzsCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rugjK-00000009IO8-34LE; Wed, 10 Apr 2024 22:47:46 +0000 Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rugj5-00000009IFr-1wy4 for linux-riscv@lists.infradead.org; Wed, 10 Apr 2024 22:47:44 +0000 Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-229661f57cbso3742000fac.1 for ; Wed, 10 Apr 2024 15:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712789250; x=1713394050; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=BseC60YZh/heyg+ZO69oe2aXT/eY+OVNFOfXi33XAxAgGPEN/PzkuWInrvpZXsqBst yFs896q+AVZ4uQfmPpz7Fb84JdNiUaYB8YHzuPV+XwHI4xPE5SoKYjynTOqMlghGv6mj 0HMpUcn3UOm1r9Sja6vOUEk0cKkHA1Cuqmugiq1e9sLHjgFRuAqqDhXKN/jPIu9KKys4 3SwLVmCBLMQbQcNUy5B7QtqbYbdN13wyhm+E9RghygcxiezVFDftzYnyrjc8t6zVqRTF SLPgBPGPAqJwyFHXnfxR/M7VM0qvCSeU6ngmyQuxOPaecFpXiPvWgEQ37yaw/uo6gPqf t/wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712789250; x=1713394050; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=rnFm1LSN9EGWFikjgmptpWoD2U8MH61cgDRWKoYiH+fjqt/bmTZUwQl1JEoi0vJJxk KJhi2PAOFXjtqWnknzx6uQtY81D1AaR95l8QbANSg5aKth07N18YTBsLcMBAxcPmr4ZO XYKacE0GORCF6Hs/gJmYJRLv0Z7c2DVos7LPe+fFdD4KUX9Zm882rAm9ejX53ktDWaOt Korhot3lYukZs2XtQjugrd+tTI+zdDESGE4k9s5piqRGJTOriPeZcvgc6/W4l/6GAEAh AlEMNX4G+DSzXql7UcxIDzHA5S7m49AEQMsBkZCSKao3J+oOj6z/WFr5fmlLF+cIJRlr 3Hgw== X-Forwarded-Encrypted: i=1; AJvYcCUTCQ/I99bmNbQ0TziCjE1riSwJ8sfzXNd61chZ4UXZIY+CAyKzDTLGwGDLICkC2sm1PHFTvqlOkZMNi4HlKW6o0fkvFXRPZp+p0S7X35ZI X-Gm-Message-State: AOJu0YyCOihPuqCKzt8QM07os7KBlVco2m0r5/HISk0zQRZkpAC6ehrn OwJOQpz4r6kKQ9K5Wh5mF2Qa6mnIXorHYN8SewunzpTVWrMnFz4WcscWSf1+yRc= X-Google-Smtp-Source: AGHT+IHLiKUoeBUB4OwLHReX4a7dcUh2Eqxld9pK8ip3FgSpidJgLmLzuSWt1Fnkq1wrPVQWu86Qjg== X-Received: by 2002:a05:6871:80a:b0:22d:f859:2225 with SMTP id q10-20020a056871080a00b0022df8592225mr3914938oap.6.1712789249782; Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id lf3-20020a0568700c4300b0022eba51882fsm75970oab.53.2024.04.10.15.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Message-ID: <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> Date: Wed, 10 Apr 2024 17:47:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4oo3y.fsf@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_154731_710366_CAF30581 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgVGhpYWdvLAoKT24gMjAyNC0wNC0xMCA1OjIxIFBNLCBUaGlhZ28gSnVuZyBCYXVlcm1hbm4g d3JvdGU6Cj4gU2FtdWVsIEhvbGxhbmQgPHNhbXVlbC5ob2xsYW5kQHNpZml2ZS5jb20+IHdyaXRl czoKPiAKPj4gTm93IHRoYXQgYWxsIHByZXZpb3VzbHktc3VwcG9ydGVkIGFyY2hpdGVjdHVyZXMg c2VsZWN0Cj4+IEFSQ0hfSEFTX0tFUk5FTF9GUFVfU1VQUE9SVCwgdGhpcyBjb2RlIGNhbiBkZXBl bmQgb24gdGhhdCBzeW1ib2wgaW5zdGVhZAo+PiBvZiB0aGUgZXhpc3RpbmcgbGlzdCBvZiBhcmNo aXRlY3R1cmVzLiBJdCBjYW4gYWxzbyB0YWtlIGFkdmFudGFnZSBvZiB0aGUKPj4gY29tbW9uIGtl cm5lbC1tb2RlIEZQVSBBUEkgYW5kIG1ldGhvZCBvZiBhZGp1c3RpbmcgQ0ZMQUdTLgo+Pgo+PiBB Y2tlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+PiBSZXZp ZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+Cj4+IFNpZ25lZC1vZmYtYnk6 IFNhbXVlbCBIb2xsYW5kIDxzYW11ZWwuaG9sbGFuZEBzaWZpdmUuY29tPgo+IAo+IFVuZm9ydHVu YXRlbHkgdGhpcyBwYXRjaCBjYXVzZXMgYnVpbGQgZmFpbHVyZXMgb24gYXJtIHdpdGggYWxseWVz Y29uZmlnCj4gYW5kIGFsbG1vZGNvbmZpZy4gVGVzdGVkIHdpdGggbmV4dC0yMDI0MDQxMC4KPiAK PiBFcnJvciB3aXRoIGFsbHllc2NvbmZpZzoKPiAKPiAkIG1ha2UgLWogOCBcCj4gICAgIE89JEhP TUUvLmNhY2hlL2J1aWxkcy9saW51eC1jcm9zcy1hcm0gXAo+ICAgICBBUkNIPWFybSBcCj4gICAg IENST1NTX0NPTVBJTEU9YXJtLWxpbnV4LWdudWVhYmloZi0KPiBtYWtlWzFdOiBFbnRlcmluZyBk aXJlY3RvcnkgJy9ob21lL2JhdWVybWFubi8uY2FjaGUvYnVpbGRzL2xpbnV4LWNyb3NzLWFybScK PiAgICAg4ouuCj4gYXJtLWxpbnV4LWdudWVhYmloZi1sZDogZHJpdmVycy9ncHUvZHJtL2FtZC9k aXNwbGF5L2RjL2RtbC9kY24yMC9kY24yMF9mcHUubzogaW4gZnVuY3Rpb24gYGRjbjIwX3BvcHVs YXRlX2RtbF9waXBlc19mcm9tX2NvbnRleHQnOgo+IGRjbjIwX2ZwdS5jOigudGV4dCsweDIwZjQp OiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgtZ251ZWFi aWhmLWxkOiBkY24yMF9mcHUuYzooLnRleHQrMHgyMTBjKTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0 byBgX19hZWFiaV9sMmQnCj4gYXJtLWxpbnV4LWdudWVhYmloZi1sZDogZGNuMjBfZnB1LmM6KC50 ZXh0KzB4MjEyNCk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYF9fYWVhYmlfbDJkJwo+IGFybS1s aW51eC1nbnVlYWJpaGYtbGQ6IGRjbjIwX2ZwdS5jOigudGV4dCsweDIxM2MpOiB1bmRlZmluZWQg cmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgtZ251ZWFiaWhmLWxkOiBkcml2 ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZG1sL2NhbGNzL2Rjbl9jYWxjcy5vOiBpbiBmdW5j dGlvbiBgcGlwZV9jdHhfdG9fZTJlX3BpcGVfcGFyYW1zJzoKPiBkY25fY2FsY3MuYzooLnRleHQr MHgzOTApOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgt Z251ZWFiaWhmLWxkOiBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZG1sL2NhbGNzL2Rj bl9jYWxjcy5vOmRjbl9jYWxjcy5jOigudGV4dCsweDNhNCk6IG1vcmUgdW5kZWZpbmVkIHJlZmVy ZW5jZXMgdG8gYF9fYWVhYmlfbDJkJyBmb2xsb3cKPiBhcm0tbGludXgtZ251ZWFiaWhmLWxkOiBk cml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZG1sMi9kbWwyX3dyYXBwZXIubzogaW4gZnVu Y3Rpb24gYG9wdGltaXplX2NvbmZpZ3VyYXRpb24nOgo+IGRtbDJfd3JhcHBlci5jOigudGV4dCsw eGNiYyk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYF9fYWVhYmlfZDJ1bHonCj4gYXJtLWxpbnV4 LWdudWVhYmloZi1sZDogZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RtbDIvZG1sMl90 cmFuc2xhdGlvbl9oZWxwZXIubzogaW4gZnVuY3Rpb24gYHBvcHVsYXRlX2RtbF9wbGFuZV9jZmdf ZnJvbV9wbGFuZV9zdGF0ZSc6Cj4gZG1sMl90cmFuc2xhdGlvbl9oZWxwZXIuYzooLnRleHQrMHg5 ZTQpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgtZ251 ZWFiaWhmLWxkOiBkbWwyX3RyYW5zbGF0aW9uX2hlbHBlci5jOigudGV4dCsweGEyMCk6IHVuZGVm aW5lZCByZWZlcmVuY2UgdG8gYF9fYWVhYmlfbDJkJwo+IGFybS1saW51eC1nbnVlYWJpaGYtbGQ6 IGRtbDJfdHJhbnNsYXRpb25faGVscGVyLmM6KC50ZXh0KzB4YTU4KTogdW5kZWZpbmVkIHJlZmVy ZW5jZSB0byBgX19hZWFiaV9sMmQnCj4gYXJtLWxpbnV4LWdudWVhYmloZi1sZDogZG1sMl90cmFu c2xhdGlvbl9oZWxwZXIuYzooLnRleHQrMHhhOTApOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBf X2FlYWJpX2wyZCcKPiBtYWtlWzNdOiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvc2Ny aXB0cy9NYWtlZmlsZS52bWxpbnV4OjM3OiB2bWxpbnV4XSBFcnJvciAxCj4gbWFrZVsyXTogKioq IFsvaG9tZS9iYXVlcm1hbm4vc3JjL2xpbnV4L01ha2VmaWxlOjExNjU6IHZtbGludXhdIEVycm9y IDIKPiBtYWtlWzFdOiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvTWFrZWZpbGU6MjQw OiBfX3N1Yi1tYWtlXSBFcnJvciAyCj4gbWFrZVsxXTogTGVhdmluZyBkaXJlY3RvcnkgJy9ob21l L2JhdWVybWFubi8uY2FjaGUvYnVpbGRzL2xpbnV4LWNyb3NzLWFybScKPiBtYWtlOiAqKiogW01h a2VmaWxlOjI0MDogX19zdWItbWFrZV0gRXJyb3IgMgo+IAo+IFRoZSBlcnJvciB3aXRoIGFsbG1v ZGNvbmZpZyBpcyBzbGlnaHRseSBkaWZmZXJlbnQ6Cj4gCj4gJCBtYWtlIC1qIDggXAo+ICAgICBP PSRIT01FLy5jYWNoZS9idWlsZHMvbGludXgtY3Jvc3MtYXJtIFwKPiAgICAgQVJDSD1hcm0gXAo+ ICAgICBDUk9TU19DT01QSUxFPWFybS1saW51eC1nbnVlYWJpaGYtCj4gbWFrZVsxXTogRW50ZXJp bmcgZGlyZWN0b3J5ICcvaG9tZS9iYXVlcm1hbm4vLmNhY2hlL2J1aWxkcy9saW51eC1jcm9zcy1h cm0nCj4gICAgIOKLrgo+IEVSUk9SOiBtb2Rwb3N0OiAiX19hZWFiaV9kMnVseiIgW2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5rb10gdW5kZWZpbmVkIQo+IEVSUk9SOiBtb2Rwb3N0 OiAiX19hZWFiaV9sMmQiIFtkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUua29dIHVu ZGVmaW5lZCEKPiBtYWtlWzNdOiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvc2NyaXB0 cy9NYWtlZmlsZS5tb2Rwb3N0OjE0NTogTW9kdWxlLnN5bXZlcnNdIEVycm9yIDEKPiBtYWtlWzJd OiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvTWFrZWZpbGU6MTg3NjogbW9kcG9zdF0g RXJyb3IgMgo+IG1ha2VbMV06ICoqKiBbL2hvbWUvYmF1ZXJtYW5uL3NyYy9saW51eC9NYWtlZmls ZToyNDA6IF9fc3ViLW1ha2VdIEVycm9yIDIKPiBtYWtlWzFdOiBMZWF2aW5nIGRpcmVjdG9yeSAn L2hvbWUvYmF1ZXJtYW5uLy5jYWNoZS9idWlsZHMvbGludXgtY3Jvc3MtYXJtJwo+IG1ha2U6ICoq KiBbTWFrZWZpbGU6MjQwOiBfX3N1Yi1tYWtlXSBFcnJvciAyCgpJbiBib3RoIGNhc2VzLCB0aGUg aXNzdWUgaXMgdGhhdCB0aGUgdG9vbGNoYWluIHJlcXVpcmVzIHJ1bnRpbWUgc3VwcG9ydCB0bwpj b252ZXJ0IGJldHdlZW4gYHVuc2lnbmVkIGxvbmcgbG9uZ2AgYW5kIGBkb3VibGVgLCBldmVuIHdo ZW4gaGFyZHdhcmUgRlAgaXMKZW5hYmxlZC4gVGhlcmUgd2FzIHNvbWUgcGFzdCBkaXNjdXNzaW9u IGFib3V0IEdDQyBpbmxpbmluZyBzb21lIG9mIHRoZXNlCmNvbnZlcnNpb25zWzFdLCBidXQgdGhh dCBkaWQgbm90IGdldCBpbXBsZW1lbnRlZC4KClRoZSBzaG9ydC10ZXJtIGZpeCB3b3VsZCBiZSB0 byBkcm9wIHRoZSBgc2VsZWN0IEFSQ0hfSEFTX0tFUk5FTF9GUFVfU1VQUE9SVGAgZm9yCjMyLWJp dCBhcm0gdW50aWwgd2UgY2FuIHByb3ZpZGUgdGhlc2UgcnVudGltZSBsaWJyYXJ5IGZ1bmN0aW9u cy4KClJlZ2FyZHMsClNhbXVlbAoKWzFdOiBodHRwczovL2djYy5nbnUub3JnL2J1Z3ppbGxhL3No b3dfYnVnLmNnaT9pZD05MTk3MAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64896CD1284 for ; Wed, 10 Apr 2024 22:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IfkJw66uJQVKs6Jj1z56sBFJdi7oudwAIr7yH2mQQ5c=; b=KbDpQoCFJqI82R ZOxEWhmmaVVtpLkkYdUY22gCY8jUECzA+YIZxHnHDZ6TLB77s+56y6FpQ/SE6A5VVUBOM+9fvKZ1/ KKE7C6yiOQhNfb9BKiInQFFcpuJ3fDkVb6PNssDHe3YWfrxQPKEpzb7d3hvCjwMEaHMkEDx55RxBJ IQLYIAvEHZj2lXatnQXtDehpwfTh5yVGvowqarXN+/xmS3WJDvMYlPLjnYeKv9Lp0b3dvCQsECR3K yIEBZPOgx1XHZxbHKtin5FRNQkQciekTkEaPMNP2Eya9ST8RYrS0pWIQEgaXXtLWMaaQBIbFrxFYu ivP612yFy2cq4bMqg/ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rugjJ-00000009INK-2XiE; Wed, 10 Apr 2024 22:47:45 +0000 Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rugj5-00000009IFq-1P3u for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 22:47:43 +0000 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-22f746c56a2so1400543fac.0 for ; Wed, 10 Apr 2024 15:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712789250; x=1713394050; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=BseC60YZh/heyg+ZO69oe2aXT/eY+OVNFOfXi33XAxAgGPEN/PzkuWInrvpZXsqBst yFs896q+AVZ4uQfmPpz7Fb84JdNiUaYB8YHzuPV+XwHI4xPE5SoKYjynTOqMlghGv6mj 0HMpUcn3UOm1r9Sja6vOUEk0cKkHA1Cuqmugiq1e9sLHjgFRuAqqDhXKN/jPIu9KKys4 3SwLVmCBLMQbQcNUy5B7QtqbYbdN13wyhm+E9RghygcxiezVFDftzYnyrjc8t6zVqRTF SLPgBPGPAqJwyFHXnfxR/M7VM0qvCSeU6ngmyQuxOPaecFpXiPvWgEQ37yaw/uo6gPqf t/wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712789250; x=1713394050; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=QO7klPknDROm+liIt4O27XYmhBhG0xmcmqUyWdjHpntLWKTKqBnu0Y7FMTwqrZ3qmB 5lIA4pvIHoNkOtOcgQ2QLnXcdZE8pDn1KNt6SwyIdQ6pfxSv92uNo4owvQOw4wwzAEv4 OGE6RMx2JUMx391xqfFBiYxKKynbvnYt2dOYrodHhaK8shuXyFqj0uSNWX8mMeilqXkY C85RPCxm6i0k4NzMYhAcuhSLnl8UMH4rJ8WguMfsgANBV+w/mLcNkIMMCISrsQSVOM6D 18nInuSHhD0YjL298vaFrUc6Btt+yOy7QVf+xg2Wv6ZjzrYAVm1BeZiaM/ycKmKknnRq 0+AA== X-Forwarded-Encrypted: i=1; AJvYcCXJf3blVrl/Lrql6HP97bAaicrlUXYZ5WWCDsO/utXqHuukka0oScB68+3Xar1fi6QgfbYMjyIKsUEjlK768Q0iArfUlLiEShfRLLYnbpJUQgxCHFQ= X-Gm-Message-State: AOJu0YxpUQNWkW12eAJwI91OvdtKfQX28S23cIskuzZq/6ZLvg4NoZsP beEwGUOwgnN6PPbCjQiZd8Imiao5RPCtBov4wwhHvXXeKkPs48Tcr2ptk0dJ5SkpNCo7qOdfcxn e X-Google-Smtp-Source: AGHT+IHLiKUoeBUB4OwLHReX4a7dcUh2Eqxld9pK8ip3FgSpidJgLmLzuSWt1Fnkq1wrPVQWu86Qjg== X-Received: by 2002:a05:6871:80a:b0:22d:f859:2225 with SMTP id q10-20020a056871080a00b0022df8592225mr3914938oap.6.1712789249782; Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id lf3-20020a0568700c4300b0022eba51882fsm75970oab.53.2024.04.10.15.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Message-ID: <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> Date: Wed, 10 Apr 2024 17:47:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4oo3y.fsf@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_154731_702985_82C6C5C6 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVGhpYWdvLAoKT24gMjAyNC0wNC0xMCA1OjIxIFBNLCBUaGlhZ28gSnVuZyBCYXVlcm1hbm4g d3JvdGU6Cj4gU2FtdWVsIEhvbGxhbmQgPHNhbXVlbC5ob2xsYW5kQHNpZml2ZS5jb20+IHdyaXRl czoKPiAKPj4gTm93IHRoYXQgYWxsIHByZXZpb3VzbHktc3VwcG9ydGVkIGFyY2hpdGVjdHVyZXMg c2VsZWN0Cj4+IEFSQ0hfSEFTX0tFUk5FTF9GUFVfU1VQUE9SVCwgdGhpcyBjb2RlIGNhbiBkZXBl bmQgb24gdGhhdCBzeW1ib2wgaW5zdGVhZAo+PiBvZiB0aGUgZXhpc3RpbmcgbGlzdCBvZiBhcmNo aXRlY3R1cmVzLiBJdCBjYW4gYWxzbyB0YWtlIGFkdmFudGFnZSBvZiB0aGUKPj4gY29tbW9uIGtl cm5lbC1tb2RlIEZQVSBBUEkgYW5kIG1ldGhvZCBvZiBhZGp1c3RpbmcgQ0ZMQUdTLgo+Pgo+PiBB Y2tlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+PiBSZXZp ZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3QuZGU+Cj4+IFNpZ25lZC1vZmYtYnk6 IFNhbXVlbCBIb2xsYW5kIDxzYW11ZWwuaG9sbGFuZEBzaWZpdmUuY29tPgo+IAo+IFVuZm9ydHVu YXRlbHkgdGhpcyBwYXRjaCBjYXVzZXMgYnVpbGQgZmFpbHVyZXMgb24gYXJtIHdpdGggYWxseWVz Y29uZmlnCj4gYW5kIGFsbG1vZGNvbmZpZy4gVGVzdGVkIHdpdGggbmV4dC0yMDI0MDQxMC4KPiAK PiBFcnJvciB3aXRoIGFsbHllc2NvbmZpZzoKPiAKPiAkIG1ha2UgLWogOCBcCj4gICAgIE89JEhP TUUvLmNhY2hlL2J1aWxkcy9saW51eC1jcm9zcy1hcm0gXAo+ICAgICBBUkNIPWFybSBcCj4gICAg IENST1NTX0NPTVBJTEU9YXJtLWxpbnV4LWdudWVhYmloZi0KPiBtYWtlWzFdOiBFbnRlcmluZyBk aXJlY3RvcnkgJy9ob21lL2JhdWVybWFubi8uY2FjaGUvYnVpbGRzL2xpbnV4LWNyb3NzLWFybScK PiAgICAg4ouuCj4gYXJtLWxpbnV4LWdudWVhYmloZi1sZDogZHJpdmVycy9ncHUvZHJtL2FtZC9k aXNwbGF5L2RjL2RtbC9kY24yMC9kY24yMF9mcHUubzogaW4gZnVuY3Rpb24gYGRjbjIwX3BvcHVs YXRlX2RtbF9waXBlc19mcm9tX2NvbnRleHQnOgo+IGRjbjIwX2ZwdS5jOigudGV4dCsweDIwZjQp OiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgtZ251ZWFi aWhmLWxkOiBkY24yMF9mcHUuYzooLnRleHQrMHgyMTBjKTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0 byBgX19hZWFiaV9sMmQnCj4gYXJtLWxpbnV4LWdudWVhYmloZi1sZDogZGNuMjBfZnB1LmM6KC50 ZXh0KzB4MjEyNCk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYF9fYWVhYmlfbDJkJwo+IGFybS1s aW51eC1nbnVlYWJpaGYtbGQ6IGRjbjIwX2ZwdS5jOigudGV4dCsweDIxM2MpOiB1bmRlZmluZWQg cmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgtZ251ZWFiaWhmLWxkOiBkcml2 ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZG1sL2NhbGNzL2Rjbl9jYWxjcy5vOiBpbiBmdW5j dGlvbiBgcGlwZV9jdHhfdG9fZTJlX3BpcGVfcGFyYW1zJzoKPiBkY25fY2FsY3MuYzooLnRleHQr MHgzOTApOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgt Z251ZWFiaWhmLWxkOiBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZG1sL2NhbGNzL2Rj bl9jYWxjcy5vOmRjbl9jYWxjcy5jOigudGV4dCsweDNhNCk6IG1vcmUgdW5kZWZpbmVkIHJlZmVy ZW5jZXMgdG8gYF9fYWVhYmlfbDJkJyBmb2xsb3cKPiBhcm0tbGludXgtZ251ZWFiaWhmLWxkOiBk cml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZG1sMi9kbWwyX3dyYXBwZXIubzogaW4gZnVu Y3Rpb24gYG9wdGltaXplX2NvbmZpZ3VyYXRpb24nOgo+IGRtbDJfd3JhcHBlci5jOigudGV4dCsw eGNiYyk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYF9fYWVhYmlfZDJ1bHonCj4gYXJtLWxpbnV4 LWdudWVhYmloZi1sZDogZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RtbDIvZG1sMl90 cmFuc2xhdGlvbl9oZWxwZXIubzogaW4gZnVuY3Rpb24gYHBvcHVsYXRlX2RtbF9wbGFuZV9jZmdf ZnJvbV9wbGFuZV9zdGF0ZSc6Cj4gZG1sMl90cmFuc2xhdGlvbl9oZWxwZXIuYzooLnRleHQrMHg5 ZTQpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBfX2FlYWJpX2wyZCcKPiBhcm0tbGludXgtZ251 ZWFiaWhmLWxkOiBkbWwyX3RyYW5zbGF0aW9uX2hlbHBlci5jOigudGV4dCsweGEyMCk6IHVuZGVm aW5lZCByZWZlcmVuY2UgdG8gYF9fYWVhYmlfbDJkJwo+IGFybS1saW51eC1nbnVlYWJpaGYtbGQ6 IGRtbDJfdHJhbnNsYXRpb25faGVscGVyLmM6KC50ZXh0KzB4YTU4KTogdW5kZWZpbmVkIHJlZmVy ZW5jZSB0byBgX19hZWFiaV9sMmQnCj4gYXJtLWxpbnV4LWdudWVhYmloZi1sZDogZG1sMl90cmFu c2xhdGlvbl9oZWxwZXIuYzooLnRleHQrMHhhOTApOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBf X2FlYWJpX2wyZCcKPiBtYWtlWzNdOiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvc2Ny aXB0cy9NYWtlZmlsZS52bWxpbnV4OjM3OiB2bWxpbnV4XSBFcnJvciAxCj4gbWFrZVsyXTogKioq IFsvaG9tZS9iYXVlcm1hbm4vc3JjL2xpbnV4L01ha2VmaWxlOjExNjU6IHZtbGludXhdIEVycm9y IDIKPiBtYWtlWzFdOiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvTWFrZWZpbGU6MjQw OiBfX3N1Yi1tYWtlXSBFcnJvciAyCj4gbWFrZVsxXTogTGVhdmluZyBkaXJlY3RvcnkgJy9ob21l L2JhdWVybWFubi8uY2FjaGUvYnVpbGRzL2xpbnV4LWNyb3NzLWFybScKPiBtYWtlOiAqKiogW01h a2VmaWxlOjI0MDogX19zdWItbWFrZV0gRXJyb3IgMgo+IAo+IFRoZSBlcnJvciB3aXRoIGFsbG1v ZGNvbmZpZyBpcyBzbGlnaHRseSBkaWZmZXJlbnQ6Cj4gCj4gJCBtYWtlIC1qIDggXAo+ICAgICBP PSRIT01FLy5jYWNoZS9idWlsZHMvbGludXgtY3Jvc3MtYXJtIFwKPiAgICAgQVJDSD1hcm0gXAo+ ICAgICBDUk9TU19DT01QSUxFPWFybS1saW51eC1nbnVlYWJpaGYtCj4gbWFrZVsxXTogRW50ZXJp bmcgZGlyZWN0b3J5ICcvaG9tZS9iYXVlcm1hbm4vLmNhY2hlL2J1aWxkcy9saW51eC1jcm9zcy1h cm0nCj4gICAgIOKLrgo+IEVSUk9SOiBtb2Rwb3N0OiAiX19hZWFiaV9kMnVseiIgW2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5rb10gdW5kZWZpbmVkIQo+IEVSUk9SOiBtb2Rwb3N0 OiAiX19hZWFiaV9sMmQiIFtkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUua29dIHVu ZGVmaW5lZCEKPiBtYWtlWzNdOiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvc2NyaXB0 cy9NYWtlZmlsZS5tb2Rwb3N0OjE0NTogTW9kdWxlLnN5bXZlcnNdIEVycm9yIDEKPiBtYWtlWzJd OiAqKiogWy9ob21lL2JhdWVybWFubi9zcmMvbGludXgvTWFrZWZpbGU6MTg3NjogbW9kcG9zdF0g RXJyb3IgMgo+IG1ha2VbMV06ICoqKiBbL2hvbWUvYmF1ZXJtYW5uL3NyYy9saW51eC9NYWtlZmls ZToyNDA6IF9fc3ViLW1ha2VdIEVycm9yIDIKPiBtYWtlWzFdOiBMZWF2aW5nIGRpcmVjdG9yeSAn L2hvbWUvYmF1ZXJtYW5uLy5jYWNoZS9idWlsZHMvbGludXgtY3Jvc3MtYXJtJwo+IG1ha2U6ICoq KiBbTWFrZWZpbGU6MjQwOiBfX3N1Yi1tYWtlXSBFcnJvciAyCgpJbiBib3RoIGNhc2VzLCB0aGUg aXNzdWUgaXMgdGhhdCB0aGUgdG9vbGNoYWluIHJlcXVpcmVzIHJ1bnRpbWUgc3VwcG9ydCB0bwpj b252ZXJ0IGJldHdlZW4gYHVuc2lnbmVkIGxvbmcgbG9uZ2AgYW5kIGBkb3VibGVgLCBldmVuIHdo ZW4gaGFyZHdhcmUgRlAgaXMKZW5hYmxlZC4gVGhlcmUgd2FzIHNvbWUgcGFzdCBkaXNjdXNzaW9u IGFib3V0IEdDQyBpbmxpbmluZyBzb21lIG9mIHRoZXNlCmNvbnZlcnNpb25zWzFdLCBidXQgdGhh dCBkaWQgbm90IGdldCBpbXBsZW1lbnRlZC4KClRoZSBzaG9ydC10ZXJtIGZpeCB3b3VsZCBiZSB0 byBkcm9wIHRoZSBgc2VsZWN0IEFSQ0hfSEFTX0tFUk5FTF9GUFVfU1VQUE9SVGAgZm9yCjMyLWJp dCBhcm0gdW50aWwgd2UgY2FuIHByb3ZpZGUgdGhlc2UgcnVudGltZSBsaWJyYXJ5IGZ1bmN0aW9u cy4KClJlZ2FyZHMsClNhbXVlbAoKWzFdOiBodHRwczovL2djYy5nbnUub3JnL2J1Z3ppbGxhL3No b3dfYnVnLmNnaT9pZD05MTk3MAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01AAACD1284 for ; Wed, 10 Apr 2024 22:48:21 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=fCiUu5BC; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VFHzm4fvNz3vY2 for ; Thu, 11 Apr 2024 08:48:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=fCiUu5BC; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sifive.com (client-ip=2607:f8b0:4864:20::c2b; helo=mail-oo1-xc2b.google.com; envelope-from=samuel.holland@sifive.com; receiver=lists.ozlabs.org) Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VFHys4wG0z2yD6 for ; Thu, 11 Apr 2024 08:47:33 +1000 (AEST) Received: by mail-oo1-xc2b.google.com with SMTP id 006d021491bc7-5aa17c29ba0so2684049eaf.3 for ; Wed, 10 Apr 2024 15:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712789250; x=1713394050; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=fCiUu5BC1Wjpx6dIiCw/igd5R0omTTPHgm8+2m9+sdNDefRYgYBm0/NUMOUrTCFoVl SpGEXyFkNWIxQitLECg6KceoFzMdUB7B5upmOO18xiCkhFVbn+Ggimcpf+JtDeUum0wC 3qpb+UMIHEJxI6Bg0rQV/q9j+qo8YoQ6kvECN/DS5POwKJXx4NOIYlGNwWRaZyEBqjEu V5TG+18aSPkXQVLpPiTULhunONOVCs8UzVTIKAg3uEqUc5fkZbviLKN64mD8xv7ON09j zl6FqiT8kYbp2lq3lQ3W7/4vKBF4JxeZSIF+7n+zBeYLEIyijX+DdavYlvGeDV4vH87v zwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712789250; x=1713394050; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jexQJX0oM9fCmEvziBSolme7TKZ0EEYhwHpwJAChgvs=; b=PGAbCQF+VjoNYaNec0q/XgAAo1/Xfq6/EL2GlTYxSDjBfBgyquFyTt84xmy570AnS5 X4qEfHnC4d+gb/ab4O6f/QkKD+L3OIeFpVIGYCyHyC555AYQeDBAJ3Iin7PTITalIG8Z pVCj9f0pAjqlIYLA8ryXtn4KzJCp1tavFnwxeL58fYuD6v7/fq6dpnx2AeEqrvJuMSoW y4HSQAVDi8auACb3CMHYf3YXaYEtTJiXGbfAJIQaksNQEYn0GsBEviFa/iqHayPzTRjx AgQjPhrrt3DgBcaOvHp0nRDy719787B5WSttimZwQUV4Z640WDfN5nvS6EpOtBY+JW0U Cj+Q== X-Forwarded-Encrypted: i=1; AJvYcCXFIAqIMpJivA7GBabjXuRR4Qu5FmQ4E3v4Gu/1Z22nbtfDQOvc2MoQf8CF3gypbOymhleNMp1lJiuiT0CaYQDWWwiSGtnvy712RR57fA== X-Gm-Message-State: AOJu0YzX92XbwgjciXly1r/ukyY5haGGWPwE9wH8cDM+Geg1JgUe9qxO S3ZbZlePV5iOa4yLd4VAv9EXUXRXRRcGNtpb4z5ECrklvM3Jq9Xub2+Vl5WykRQ= X-Google-Smtp-Source: AGHT+IHLiKUoeBUB4OwLHReX4a7dcUh2Eqxld9pK8ip3FgSpidJgLmLzuSWt1Fnkq1wrPVQWu86Qjg== X-Received: by 2002:a05:6871:80a:b0:22d:f859:2225 with SMTP id q10-20020a056871080a00b0022df8592225mr3914938oap.6.1712789249782; Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id lf3-20020a0568700c4300b0022eba51882fsm75970oab.53.2024.04.10.15.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 15:47:29 -0700 (PDT) Message-ID: <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> Date: Wed, 10 Apr 2024 17:47:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4oo3y.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , loongarch@lists.linux.dev, Alex Deucher , Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Thiago, On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: > >> Now that all previously-supported architectures select >> ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead >> of the existing list of architectures. It can also take advantage of the >> common kernel-mode FPU API and method of adjusting CFLAGS. >> >> Acked-by: Alex Deucher >> Reviewed-by: Christoph Hellwig >> Signed-off-by: Samuel Holland > > Unfortunately this patch causes build failures on arm with allyesconfig > and allmodconfig. Tested with next-20240410. > > Error with allyesconfig: > > $ make -j 8 \ > O=$HOME/.cache/builds/linux-cross-arm \ > ARCH=arm \ > CROSS_COMPILE=arm-linux-gnueabihf- > make[1]: Entering directory '/home/bauermann/.cache/builds/linux-cross-arm' > ⋮ > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.o: in function `dcn20_populate_dml_pipes_from_context': > dcn20_fpu.c:(.text+0x20f4): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x210c): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x2124): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x213c): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.o: in function `pipe_ctx_to_e2e_pipe_params': > dcn_calcs.c:(.text+0x390): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.o:dcn_calcs.c:(.text+0x3a4): more undefined references to `__aeabi_l2d' follow > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.o: in function `optimize_configuration': > dml2_wrapper.c:(.text+0xcbc): undefined reference to `__aeabi_d2ulz' > arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.o: in function `populate_dml_plane_cfg_from_plane_state': > dml2_translation_helper.c:(.text+0x9e4): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa20): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa58): undefined reference to `__aeabi_l2d' > arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa90): undefined reference to `__aeabi_l2d' > make[3]: *** [/home/bauermann/src/linux/scripts/Makefile.vmlinux:37: vmlinux] Error 1 > make[2]: *** [/home/bauermann/src/linux/Makefile:1165: vmlinux] Error 2 > make[1]: *** [/home/bauermann/src/linux/Makefile:240: __sub-make] Error 2 > make[1]: Leaving directory '/home/bauermann/.cache/builds/linux-cross-arm' > make: *** [Makefile:240: __sub-make] Error 2 > > The error with allmodconfig is slightly different: > > $ make -j 8 \ > O=$HOME/.cache/builds/linux-cross-arm \ > ARCH=arm \ > CROSS_COMPILE=arm-linux-gnueabihf- > make[1]: Entering directory '/home/bauermann/.cache/builds/linux-cross-arm' > ⋮ > ERROR: modpost: "__aeabi_d2ulz" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "__aeabi_l2d" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > make[3]: *** [/home/bauermann/src/linux/scripts/Makefile.modpost:145: Module.symvers] Error 1 > make[2]: *** [/home/bauermann/src/linux/Makefile:1876: modpost] Error 2 > make[1]: *** [/home/bauermann/src/linux/Makefile:240: __sub-make] Error 2 > make[1]: Leaving directory '/home/bauermann/.cache/builds/linux-cross-arm' > make: *** [Makefile:240: __sub-make] Error 2 In both cases, the issue is that the toolchain requires runtime support to convert between `unsigned long long` and `double`, even when hardware FP is enabled. There was some past discussion about GCC inlining some of these conversions[1], but that did not get implemented. The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for 32-bit arm until we can provide these runtime library functions. Regards, Samuel [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91970