* Disapproval of revision b8e46b797b32111526a2116d020fdd9e1c079965
@ 2008-05-08 6:58 Koen Kooi
2008-05-08 11:21 ` Rolf Leggewie
0 siblings, 1 reply; 4+ messages in thread
From: Koen Kooi @ 2008-05-08 6:58 UTC (permalink / raw
To: openembedded-devel
Hello,
This morning I get:
File "/OE/bitbake/lib/bb/build.py", line 136, in exec_func_python
utils.better_exec(comp, g, tmp, bbfile)
File "/OE/bitbake/lib/bb/utils.py", line 144, in better_exec
exec code in context
File "patch_do_patch", line 100, in <module>
File "patch_do_patch", line 98, in patch_do_patch
File "<bb>", line 339, in Resolve
__builtin__.CmdError: Command Error: exit status: 1 Output:
Applying patch amd64.patch
patching file longlong.h
Hunk #1 FAILED at 715.
1 out of 1 hunk FAILED -- rejects in file longlong.h
Patch amd64.patch does not apply (enforce with -f)
So I look at the commits:
Commit by Laibsch on org.oe.dev :: rb8e46b79... / (14 files in 7 dirs):
gmp: consolidate common patches unchanged across versions into files/
koen@lieve:/OE/org.openembedded.dev/packages/gmp$ find . | grep amd64
./files/amd64.patch
Ok, so there really is only one patch. Let's do an experiment:
koen@lieve:/OE/org.openembedded.dev/packages/gmp$ mtn up -r f3aafac3
mtn: expanded selector 'f3aafac3' -> 'i:f3aafac3'
mtn: expanding selection 'f3aafac3'
mtn: expanded to 'f3aafac33dd3d98133bfd91efdee783ccd8da959'
mtn: selected update target f3aafac33dd3d98133bfd91efdee783ccd8da959
mtn: [left] 71c3bbc5e67f712d2f13eedc29e54d1d2e9c64c8
mtn: [right] f3aafac33dd3d98133bfd91efdee783ccd8da959
mtn: renaming packages/gmp/files/amd64.patch to
packages/gmp/gmp-4.1.2/amd64.patch
mtn: adding packages/gmp/gmp-4.1.4/amd64.patch
mtn: renaming packages/gmp/files/sh4-asmfix.patch to
packages/gmp/gmp-4.1.4/sh4-asmfix.patch
mtn: adding packages/gmp/gmp-4.2.1/amd64.patch
mtn: adding packages/gmp/gmp-4.2.1/sh4-asmfix.patch
mtn: renaming packages/gmp/files/x86-fat.diff to
packages/gmp/gmp-4.2.1/x86-fat.diff
mtn: adding packages/gmp/gmp-4.2.2/amd64.patch
mtn: adding packages/gmp/gmp-4.2.2/sh4-asmfix.patch
mtn: adding packages/gmp/gmp-4.2.2/x86-fat.diff
mtn: dropping packages/gmp/files
mtn: updated to base revision f3aafac33dd3d98133bfd91efdee783ccd8da959
koen@lieve:/OE/org.openembedded.dev/packages/gmp$ find . | grep amd64
./gmp-4.1.2/amd64.patch
./gmp-4.1.4/amd64.patch
./gmp-4.2.1/amd64.patch
./gmp-4.2.2/amd64.patch
OK, so I have the patches back, now see if they are all the same, as
claimed by the commit:
koen@lieve:/OE/org.openembedded.dev/packages/gmp$ find . | grep amd64 |
xargs md5sum
9c015f16636e1fd0d2f374672b7004a5 ./gmp-4.1.2/amd64.patch
a9876747e7ae95ee64f505022b92bb10 ./gmp-4.1.4/amd64.patch
a9876747e7ae95ee64f505022b92bb10 ./gmp-4.2.1/amd64.patch
a9876747e7ae95ee64f505022b92bb10 ./gmp-4.2.2/amd64.patch
Nope they aren't. Revision disapproved to unbreak my build.
This is the second time this week[1] that a 'cleanup' breaks the build.
Please pay more attention (e.g. 'for bb in *.bb ; do bitbake -b $bb -c
patch ; done') when doing things like this.
[1]
http://lists.linuxtogo.org/pipermail/openembedded-commits/2008-May/014437.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Disapproval of revision b8e46b797b32111526a2116d020fdd9e1c079965
2008-05-08 6:58 Disapproval of revision b8e46b797b32111526a2116d020fdd9e1c079965 Koen Kooi
@ 2008-05-08 11:21 ` Rolf Leggewie
2008-05-08 12:34 ` pHilipp Zabel
0 siblings, 1 reply; 4+ messages in thread
From: Rolf Leggewie @ 2008-05-08 11:21 UTC (permalink / raw
To: openembedded-devel
Koen,
thank you for continuing to keep such a close watch on every single
commit I make and raising hell every time you find a chance.
My apologies for the breakage. I did md5sum those files, but I must
have overlooked the odd-man out.
I don't take breaking things lightly and you all know that I put in
great effort to get OE into better shape every time I touch it. But
additional breakage will happen from time to time (and yes, cleaning up
after others is *NOT* the greatest fun in the world!). What's important
is that breakage is dealt with after it occurred and I guess my record
is clean there.
So, yes, thank you, too.
Regards
Rolf
PS: As you are all aware, my CPU resources are quite limited and all the
time in the world spent compiling will still let some things slip through.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Disapproval of revision b8e46b797b32111526a2116d020fdd9e1c079965
2008-05-08 11:21 ` Rolf Leggewie
@ 2008-05-08 12:34 ` pHilipp Zabel
2008-05-08 13:25 ` Koen Kooi
0 siblings, 1 reply; 4+ messages in thread
From: pHilipp Zabel @ 2008-05-08 12:34 UTC (permalink / raw
To: openembedded-devel; +Cc: openembedded-devel
On Thu, May 8, 2008 at 1:21 PM, Rolf Leggewie
<no2spam@nospam.arcornews.de> wrote:
> Koen,
>
> thank you for continuing to keep such a close watch on every single
> commit I make and raising hell every time you find a chance.
Actually, I was just about to do the same thing (reverting, sending a
notification, wouldn't call that raising hell) when I noticed Koen's
disapproval, so thanks for the quick fix.
Just saying, this is because gmp is a pretty prominent package, not
because Koen is closely watching your every step. Of course the latter
part is only an assumption.
> My apologies for the breakage. I did md5sum those files, but I must
> have overlooked the odd-man out.
The good thing is that you kept that odd-man out by accident, because
otherwise it probably wouldn't have been noticed so quickly.
> I don't take breaking things lightly and you all know that I put in
> great effort to get OE into better shape every time I touch it. But
> additional breakage will happen from time to time (and yes, cleaning up
> after others is *NOT* the greatest fun in the world!). What's important
> is that breakage is dealt with after it occurred and I guess my record
> is clean there.
>
> So, yes, thank you, too.
>
> Regards
>
> Rolf
>
>
> PS: As you are all aware, my CPU resources are quite limited and all the
> time in the world spent compiling will still let some things slip through.
>
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Disapproval of revision b8e46b797b32111526a2116d020fdd9e1c079965
2008-05-08 12:34 ` pHilipp Zabel
@ 2008-05-08 13:25 ` Koen Kooi
0 siblings, 0 replies; 4+ messages in thread
From: Koen Kooi @ 2008-05-08 13:25 UTC (permalink / raw
To: openembedded-devel
pHilipp Zabel wrote:
> On Thu, May 8, 2008 at 1:21 PM, Rolf Leggewie
> <no2spam@nospam.arcornews.de> wrote:
>> Koen,
>>
>> thank you for continuing to keep such a close watch on every single
>> commit I make and raising hell every time you find a chance.
>
> Actually, I was just about to do the same thing (reverting, sending a
> notification, wouldn't call that raising hell) when I noticed Koen's
> disapproval, so thanks for the quick fix.
> Just saying, this is because gmp is a pretty prominent package, not
> because Koen is closely watching your every step. Of course the latter
> part is only an assumption.
I've been (trying) to build x11-image from scratch for various targets
the past week and fix any breakages I encounter. If you check the commit
messages you'll see that I'm also raising hell for the breakage Mickeyl
was so kind to add (removing packages that angstrom has as
PREFERRED_VERSION, etc).
It's nothing personal, Rolf just happened to be the person that made the
same mistake twice in a week.
FWIW: bitbake -c patch is IO limited, no cpu limited.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-08 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-08 6:58 Disapproval of revision b8e46b797b32111526a2116d020fdd9e1c079965 Koen Kooi
2008-05-08 11:21 ` Rolf Leggewie
2008-05-08 12:34 ` pHilipp Zabel
2008-05-08 13:25 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.