From: Yonghong Song <yhs@fb.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: Martin KaFai Lau <kafai@fb.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH bpf-next 00/17] Clean up and document RCU-based object protection for XDP_REDIRECT
Date: Wed, 9 Jun 2021 17:18:48 -0700 [thread overview]
Message-ID: <6f212b89-7b55-0545-7154-f75e93b3e076@fb.com> (raw)
In-Reply-To: <20210609103326.278782-1-toke@redhat.com>
On 6/9/21 3:33 AM, Toke Høiland-Jørgensen wrote:
> During the discussion[0] of Hangbin's multicast patch series, Martin pointed out
> that the lifetime of the RCU-protected map entries used by XDP_REDIRECT is by
> no means obvious. I promised to look into cleaning this up, and Paul helpfully
> provided some hints and a new unrcu_pointer() helper to aid in this.
>
> This is mostly a documentation exercise, clearing up the description of the
> lifetime expectations and adding __rcu annotations so sparse and lockdep can
> help verify it.
>
> Patches 1-2 are prepatory: Patch 1 adds Paul's unrcu_pointer() helper (which has
> already been added to his tree) and patch 2 is a small fix for
> dev_get_by_index_rcu() so lockdep understands _bh-disabled access to it. Patch 3
> is the main bit that adds the __rcu annotations and updates documentation
> comments, and the rest are patches updating the drivers, with one patch per
> distinct maintainer.
>
> Unfortunately I don't have any hardware to test any of the driver patches;
> Jesper helpfully verified that it doesn't break anything on i40e, but the rest
> of the driver patches are only compile-tested.
>
> [0] https://lore.kernel.org/bpf/20210415173551.7ma4slcbqeyiba2r@kafai-mbp.dhcp.thefacebook.com/
>
> Paul E. McKenney (1):
> rcu: Create an unrcu_pointer() to remove __rcu from a pointer
>
> Toke Høiland-Jørgensen (16):
> bpf: allow RCU-protected lookups to happen from bh context
> dev: add rcu_read_lock_bh_held() as a valid check when getting a RCU
> dev ref
> xdp: add proper __rcu annotations to redirect map entries
> ena: remove rcu_read_lock() around XDP program invocation
> bnxt: remove rcu_read_lock() around XDP program invocation
> thunderx: remove rcu_read_lock() around XDP program invocation
> freescale: remove rcu_read_lock() around XDP program invocation
> net: intel: remove rcu_read_lock() around XDP program invocation
> marvell: remove rcu_read_lock() around XDP program invocation
> mlx4: remove rcu_read_lock() around XDP program invocation
> nfp: remove rcu_read_lock() around XDP program invocation
> qede: remove rcu_read_lock() around XDP program invocation
> sfc: remove rcu_read_lock() around XDP program invocation
> netsec: remove rcu_read_lock() around XDP program invocation
> stmmac: remove rcu_read_lock() around XDP program invocation
> net: ti: remove rcu_read_lock() around XDP program invocation
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 --
> drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 2 -
> .../net/ethernet/cavium/thunder/nicvf_main.c | 2 -
> .../net/ethernet/freescale/dpaa/dpaa_eth.c | 8 +--
> .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 --
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 -
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 6 +--
> drivers/net/ethernet/intel/ice/ice_txrx.c | 6 +--
> drivers/net/ethernet/intel/ice/ice_xsk.c | 6 +--
> drivers/net/ethernet/intel/igb/igb_main.c | 2 -
> drivers/net/ethernet/intel/igc/igc_main.c | 7 +--
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 -
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 6 +--
> .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 -
> drivers/net/ethernet/marvell/mvneta.c | 2 -
> .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 --
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 8 +--
> .../ethernet/netronome/nfp/nfp_net_common.c | 2 -
> drivers/net/ethernet/qlogic/qede/qede_fp.c | 6 ---
> drivers/net/ethernet/sfc/rx.c | 9 +---
> drivers/net/ethernet/socionext/netsec.c | 3 --
> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 10 +---
> drivers/net/ethernet/ti/cpsw_priv.c | 10 +---
> include/linux/rcupdate.h | 14 +++++
> include/net/xdp_sock.h | 2 +-
> kernel/bpf/cpumap.c | 14 +++--
> kernel/bpf/devmap.c | 52 ++++++++-----------
> kernel/bpf/hashtab.c | 21 +++++---
> kernel/bpf/helpers.c | 6 +--
> kernel/bpf/lpm_trie.c | 6 ++-
> net/core/dev.c | 2 +-
> net/core/filter.c | 28 ++++++++++
> net/xdp/xsk.c | 4 +-
> net/xdp/xsk.h | 4 +-
> net/xdp/xskmap.c | 29 ++++++-----
> 35 files changed, 134 insertions(+), 159 deletions(-)
Martin, could you help review this patch set? You had participated
in early discussions related to this patch. Thanks!
prev parent reply other threads:[~2021-06-10 0:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 10:33 [PATCH bpf-next 00/17] Clean up and document RCU-based object protection for XDP_REDIRECT Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 01/17] rcu: Create an unrcu_pointer() to remove __rcu from a pointer Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 02/17] bpf: allow RCU-protected lookups to happen from bh context Toke Høiland-Jørgensen
2021-06-10 18:38 ` Alexei Starovoitov
2021-06-10 21:24 ` Daniel Borkmann
2021-06-10 22:27 ` Toke Høiland-Jørgensen
2021-06-10 19:33 ` Martin KaFai Lau
2021-06-09 10:33 ` [PATCH bpf-next 03/17] dev: add rcu_read_lock_bh_held() as a valid check when getting a RCU dev ref Toke Høiland-Jørgensen
2021-06-10 19:37 ` Martin KaFai Lau
2021-06-10 23:05 ` Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 04/17] xdp: add proper __rcu annotations to redirect map entries Toke Høiland-Jørgensen
2021-06-10 21:09 ` Martin KaFai Lau
2021-06-10 23:19 ` Toke Høiland-Jørgensen
2021-06-10 23:32 ` Martin KaFai Lau
2021-06-10 23:41 ` Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 05/17] ena: remove rcu_read_lock() around XDP program invocation Toke Høiland-Jørgensen
2021-06-09 13:57 ` Paul E. McKenney
2021-06-09 10:33 ` [PATCH bpf-next 06/17] bnxt: " Toke Høiland-Jørgensen
2021-06-09 13:58 ` Paul E. McKenney
2021-06-10 8:47 ` Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 07/17] thunderx: " Toke Høiland-Jørgensen
2021-06-09 10:33 ` Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 08/17] freescale: " Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 09/17] net: intel: " Toke Høiland-Jørgensen
2021-06-09 10:33 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2021-06-09 10:33 ` [PATCH bpf-next 10/17] marvell: " Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 11/17] mlx4: " Toke Høiland-Jørgensen
2021-06-10 7:10 ` Tariq Toukan
2021-06-09 10:33 ` [PATCH bpf-next 12/17] nfp: " Toke Høiland-Jørgensen
2021-06-11 16:30 ` Simon Horman
2021-06-09 10:33 ` [PATCH bpf-next 13/17] qede: " Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 14/17] sfc: " Toke Høiland-Jørgensen
2021-06-09 12:15 ` Edward Cree
2021-06-09 10:33 ` [PATCH bpf-next 15/17] netsec: " Toke Høiland-Jørgensen
2021-06-10 5:30 ` Ilias Apalodimas
2021-06-09 10:33 ` [PATCH bpf-next 16/17] stmmac: " Toke Høiland-Jørgensen
2021-06-09 10:33 ` [PATCH bpf-next 17/17] net: ti: " Toke Høiland-Jørgensen
2021-06-09 17:04 ` Grygorii Strashko
2021-06-10 0:18 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f212b89-7b55-0545-7154-f75e93b3e076@fb.com \
--to=yhs@fb.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=kafai@fb.com \
--cc=liuhangbin@gmail.com \
--cc=magnus.karlsson@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.