From: "Paul E. McKenney" <paulmck@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Daniel Sneddon <daniel.sneddon@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [BUG] objtool complains about missing __noreturn__ on x64_sys_call() and ia32_sys_call()
Date: Thu, 18 Apr 2024 17:22:26 -0700 [thread overview]
Message-ID: <6dba9b32-db2c-4e6d-9500-7a08852f17a3@paulmck-laptop> (raw)
Hello!
Recent -next kernels, including next-20240418, get the following objtool
build errors:
vmlinux.o: warning: objtool: x64_sys_call+0x2804: __x64_sys_exit() is missing a __noreturn annotation
vmlinux.o: warning: objtool: ia32_sys_call+0x29b6: __ia32_sys_exit_group() is missing a __noreturn annotation
These functions appear to have been added to -next and mainline by
commit 1e3ad78334a6 ("x86/syscall: Don't force use of indirect calls
for system calls"). But the diagnostic does not make much sense because
both functions always return unless the system call itself doesn't return.
Adding annotate_unreachable() to the end of each function did not help,
header comment notwithstanding. On the other hand, these objtool errors
were from Ubuntu clang version 14.0.0-1ubuntu1.1 rather than GCC.
I also freely confess that I don't understand the "};" at the end of
both functions.
Thoughts?
Thanx, Paul
next reply other threads:[~2024-04-19 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 0:22 Paul E. McKenney [this message]
2024-04-19 7:10 ` [BUG] objtool complains about missing __noreturn__ on x64_sys_call() and ia32_sys_call() Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dba9b32-db2c-4e6d-9500-7a08852f17a3@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=daniel.sneddon@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.