* Access to ieee80211_conn_settings in the driver?
@ 2024-03-23 18:55 Ben Greear
2024-03-23 19:10 ` Ben Greear
2024-03-25 9:47 ` Johannes Berg
0 siblings, 2 replies; 4+ messages in thread
From: Ben Greear @ 2024-03-23 18:55 UTC (permalink / raw
To: linux-wireless@vger.kernel.org
Hello,
I'm interested in getting access to ieee80211_conn_settings
struct in drivers. Specifically, so I can deal with disabling
160Mhz in mt76 even if peer is 160Mhz for instance, on a per-station vdev basis.
Is this of general interest, and if so, any suggestions for you
you'd like to see it implemented?
Maybe put a copy of that struct into ieee80211_link_sta struct
during association so that the driver can find it?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Access to ieee80211_conn_settings in the driver?
2024-03-23 18:55 Access to ieee80211_conn_settings in the driver? Ben Greear
@ 2024-03-23 19:10 ` Ben Greear
2024-03-25 9:47 ` Johannes Berg
1 sibling, 0 replies; 4+ messages in thread
From: Ben Greear @ 2024-03-23 19:10 UTC (permalink / raw
To: linux-wireless@vger.kernel.org
On 3/23/24 11:55, Ben Greear wrote:
> Hello,
>
> I'm interested in getting access to ieee80211_conn_settings
> struct in drivers. Specifically, so I can deal with disabling
> 160Mhz in mt76 even if peer is 160Mhz for instance, on a per-station vdev basis.
Actually, 160Mhz is bad example, but in case I want to pass other
association config info into the driver, like disabling as much of
OFDMA or MU-MIMO as possible.
Looks like maybe Johannes' existing changes already make it a lot
easier to limit bandwidth in the association path...
Thanks,
Ben
>
> Is this of general interest, and if so, any suggestions for you
> you'd like to see it implemented?
>
> Maybe put a copy of that struct into ieee80211_link_sta struct
> during association so that the driver can find it?
>
> Thanks,
> Ben
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Access to ieee80211_conn_settings in the driver?
2024-03-23 18:55 Access to ieee80211_conn_settings in the driver? Ben Greear
2024-03-23 19:10 ` Ben Greear
@ 2024-03-25 9:47 ` Johannes Berg
2024-03-25 14:32 ` Ben Greear
1 sibling, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2024-03-25 9:47 UTC (permalink / raw
To: Ben Greear, linux-wireless@vger.kernel.org
Hi Ben
> I'm interested in getting access to ieee80211_conn_settings
> struct in drivers.
My first instinct here is to say no. This thing was only introduced
recently, and it was ... difficult ... to do. I don't even want to
imagine I'd have had to worry about a whole bunch of drivers using it
for random purposes as well.
> Specifically, so I can deal with disabling
> 160Mhz in mt76 even if peer is 160Mhz for instance, on a per-station vdev basis.
Not sure how that even makes sense? You have the min_def in the chandef
though, so you could do some bandwidth tricks there for AP side?
> Actually, 160Mhz is bad example, but in case I want to pass other
> association config info into the driver, like disabling as much of
> OFDMA or MU-MIMO as possible.
No idea what that means ... I mean I guess we could add somewhere
(bss_conf?) a flag indicating "things" are needed, e.g. if you're
connecting 160 MHz is it VHT or HE or EHT, to set things accordingly?
> Is this of general interest, and if so, any suggestions for you
> you'd like to see it implemented?
I'd like to _not_ see it implemented :)
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Access to ieee80211_conn_settings in the driver?
2024-03-25 9:47 ` Johannes Berg
@ 2024-03-25 14:32 ` Ben Greear
0 siblings, 0 replies; 4+ messages in thread
From: Ben Greear @ 2024-03-25 14:32 UTC (permalink / raw
To: Johannes Berg, linux-wireless@vger.kernel.org
On 3/25/24 02:47, Johannes Berg wrote:
> Hi Ben
>
>> I'm interested in getting access to ieee80211_conn_settings
>> struct in drivers.
>
> My first instinct here is to say no. This thing was only introduced
> recently, and it was ... difficult ... to do. I don't even want to
> imagine I'd have had to worry about a whole bunch of drivers using it
> for random purposes as well.
>
>> Specifically, so I can deal with disabling
>> 160Mhz in mt76 even if peer is 160Mhz for instance, on a per-station vdev basis.
>
> Not sure how that even makes sense? You have the min_def in the chandef
> though, so you could do some bandwidth tricks there for AP side?
>
>> Actually, 160Mhz is bad example, but in case I want to pass other
>> association config info into the driver, like disabling as much of
>> OFDMA or MU-MIMO as possible.
>
> No idea what that means ... I mean I guess we could add somewhere
> (bss_conf?) a flag indicating "things" are needed, e.g. if you're
> connecting 160 MHz is it VHT or HE or EHT, to set things accordingly?
From what I can tell, mt76 figures out to disable ofdma or similar
by looking at beacon IEs. That is painful, but I guess it works.
But I want similar ability to tweak STA side connections without
resorting to debugfs or module param hacks.
>
>
>> Is this of general interest, and if so, any suggestions for you
>> you'd like to see it implemented?
>
> I'd like to _not_ see it implemented :)
Ok, I'll keep it my private hacks. I at least got it to compile copying
the conn_settings. I'll get everything rebased and make sure it works.
To actually make it all work one needs to add a way to
send new flags down through netlink...I figure that part would face resistance
as well...
Thanks,
Ben
>
> johannes
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-25 14:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-23 18:55 Access to ieee80211_conn_settings in the driver? Ben Greear
2024-03-23 19:10 ` Ben Greear
2024-03-25 9:47 ` Johannes Berg
2024-03-25 14:32 ` Ben Greear
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.