From: Ivan Vecera <ivecera@redhat.com>
To: Michal Schmidt <mschmidt@redhat.com>, intel-wired-lan@lists.osuosl.org
Cc: Jiri Pirko <jiri@resnulli.us>,
"Temerkhanov, Sergey" <sergey.temerkhanov@intel.com>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Karol Kolacinski <karol.kolacinski@intel.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 0/3] ice: lighter locking for PTP time reading
Date: Tue, 26 Mar 2024 10:51:44 +0100 [thread overview]
Message-ID: <65b02586-1322-4eb3-b46d-36cf4bf6a3bf@redhat.com> (raw)
In-Reply-To: <20240325232039.76836-1-mschmidt@redhat.com>
On 26. 03. 24 0:20, Michal Schmidt wrote:
> This series removes the use of the heavy-weight PTP hardware semaphore
> in the gettimex64 path. Instead, serialization of access to the time
> register is done using a host-side spinlock. The timer hardware is
> shared between PFs on the PCI adapter, so the spinlock must be shared
> between ice_pf instances too.
>
> Replacing the PTP hardware semaphore entirely with a mutex is also
> possible and you can see it done in my git branch[1], but I am not
> posting those patches yet to keep the scope of this series limited.
>
> [1] https://gitlab.com/mschmidt2/linux/-/commits/ice-ptp-host-side-lock-10
>
> v4:
> - Patch 1: Use named GENMASK macros and FIELD_PREP.
>
> v3:
> - Longer variable name ("a" -> "adapter").
> - Propagate xarray error in ice_adapter_get with ERR_PTR.
> - Added kernel-doc comments for ice_adapter_{get,put}.
>
> v2:
> - Patch 1: Rely on xarray's own lock. (Suggested by Jiri Pirko)
> - Patch 2: Do not use *_irqsave with ptp_gltsyn_time_lock, as it's used
> only in process contexts.
>
>
> Michal Schmidt (3):
> ice: add ice_adapter for shared data across PFs on the same NIC
> ice: avoid the PTP hardware semaphore in gettimex64 path
> ice: fold ice_ptp_read_time into ice_ptp_gettimex64
>
> drivers/net/ethernet/intel/ice/Makefile | 3 +-
> drivers/net/ethernet/intel/ice/ice.h | 2 +
> drivers/net/ethernet/intel/ice/ice_adapter.c | 116 +++++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_adapter.h | 28 +++++
> drivers/net/ethernet/intel/ice/ice_main.c | 8 ++
> drivers/net/ethernet/intel/ice/ice_ptp.c | 33 +-----
> drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 3 +
> 7 files changed, 163 insertions(+), 30 deletions(-)
> create mode 100644 drivers/net/ethernet/intel/ice/ice_adapter.c
> create mode 100644 drivers/net/ethernet/intel/ice/ice_adapter.h
>
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
prev parent reply other threads:[~2024-03-26 9:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 23:20 [PATCH net-next v4 0/3] ice: lighter locking for PTP time reading Michal Schmidt
2024-03-25 23:20 ` [Intel-wired-lan] " Michal Schmidt
2024-03-25 23:20 ` [PATCH net-next v4 1/3] ice: add ice_adapter for shared data across PFs on the same NIC Michal Schmidt
2024-03-25 23:20 ` [Intel-wired-lan] " Michal Schmidt
2024-03-29 4:57 ` Pucha, HimasekharX Reddy
2024-03-29 4:57 ` Pucha, HimasekharX Reddy
2024-03-25 23:20 ` [PATCH net-next v4 2/3] ice: avoid the PTP hardware semaphore in gettimex64 path Michal Schmidt
2024-03-25 23:20 ` [Intel-wired-lan] " Michal Schmidt
2024-03-29 5:01 ` Pucha, HimasekharX Reddy
2024-03-29 5:01 ` Pucha, HimasekharX Reddy
2024-03-25 23:20 ` [PATCH net-next v4 3/3] ice: fold ice_ptp_read_time into ice_ptp_gettimex64 Michal Schmidt
2024-03-25 23:20 ` [Intel-wired-lan] " Michal Schmidt
2024-03-26 14:46 ` Sai Krishna Gajula
2024-03-26 14:46 ` [Intel-wired-lan] " Sai Krishna Gajula
2024-03-29 5:03 ` Pucha, HimasekharX Reddy
2024-03-29 5:03 ` Pucha, HimasekharX Reddy
2024-03-29 8:35 ` Kalesh Anakkur Purayil
2024-03-29 8:35 ` [Intel-wired-lan] " Kalesh Anakkur Purayil
2024-03-26 9:51 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b02586-1322-4eb3-b46d-36cf4bf6a3bf@redhat.com \
--to=ivecera@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=karol.kolacinski@intel.com \
--cc=marcin.szycik@linux.intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sergey.temerkhanov@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.