From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19F2C2C8 for ; Mon, 29 Apr 2024 08:44:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714380289; cv=none; b=XEM81o7o/SG04zrHcdc+ANGNtIa8MpDzJLNjlLICq6tutNHDmtVtG1b0cahLvAukCMQkTC0S0dCTIvPIV35keDcQNiaOUelU/q58LTfUBNGfUyiK3pw+Dl5M6A4+BDKn5620dCWoOaAI8D3DuCdMrUHlaClgLox9KGeZiu40JGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714380289; c=relaxed/simple; bh=wF0kDbdYtUJuWt7K00viF38Od1XcZftI/0Gm7eiFcR8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OSMi6myInk++xbKpuncHhMEWohI8iksk7KgJAd64uFlmJDNgcewaqe/Pok0nuTlAo3c4IZTlRuqaYajHoQ902sSLGrAYFNACWyPkyund+Boi2uEgWbqi5yugelfMYTYLjpkSAG7W7P4Wu9JKPThc40qXS7ICCJP45FFURHRGBu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BfHwmZpr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BfHwmZpr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714380286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=so+wJdf4QBXfJtLjFUPAXghc2OBsJOAJaZ0LhApDlUI=; b=BfHwmZprLM07ijsCmrTyAQaWUodgD/Cu779P+MslgUPlT45dRMVVzjMAfWqwneAhYLpV/+ FtZqVqEIIf0mYwv0/7tNrajAqMMw1mkW1U2IncTVc/c2+KBDL6DE7w96myOE5rneWLg37z LfXWyB1khVIYCXy8UuL87qWcwTZZJRA= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-e0ov1PAvP-ys8uYUtt4q5A-1; Mon, 29 Apr 2024 04:44:43 -0400 X-MC-Unique: e0ov1PAvP-ys8uYUtt4q5A-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a57bf8ae2fcso251820166b.3 for ; Mon, 29 Apr 2024 01:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714380282; x=1714985082; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=so+wJdf4QBXfJtLjFUPAXghc2OBsJOAJaZ0LhApDlUI=; b=eM/ly9YelfGeHgK7YbVCPPAtw5ij/vM9oEbygTJ1zYsIAPxO3QKzDVeoAVVLCE6Fhx bam0jZSLu2Fcgp1S72HOYdsUxgP5HfLqW6fmb0a8oOhtVZ3czP3Dc8ttvViHLhReh1tB RhwENG+fx3Kib+Q5t0CtOjZtg2JhNXRvFcpI9IWTyWXeAca/2fw0Gefj72CTTvJ/t+fM FG29yUPdng+oz+tgq0+xG6kN8pYx9OLIUnMHDsbApQJJjRi5gd0CaTmydgK9SH91YHPb qPVbt0F9zOciNM8LoLmD6NX41twN31crS1mn5LQDM0Ur6mrDIHNQF5/h4ie1YtGN9tbc hHvA== X-Gm-Message-State: AOJu0Yz31MM01TZ3pmHTkGWYt9Pyyw2JB1VY8pLRkUR1dNafD146Efuk idyzOXXVcAYOGt8L0uzDFgSmWsKbpD9Kh52HfnB6HUbT/2OUX0W8wFxOLQmy4J8brCnzp8XG/By BlueABLFpDXgRCF6jzRo5D5rdih49/y0T2oLY+qnUzqeWQsVqR1c= X-Received: by 2002:a17:906:33cf:b0:a58:bdfa:c2b1 with SMTP id w15-20020a17090633cf00b00a58bdfac2b1mr6562859eja.9.1714380281915; Mon, 29 Apr 2024 01:44:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiv24mRwDyD/c73Y2SoNQB96iLq1QRsY4OnJzvjs388PeX7aS5r11050EUxTn4bC4gjvfCDw== X-Received: by 2002:a17:906:33cf:b0:a58:bdfa:c2b1 with SMTP id w15-20020a17090633cf00b00a58bdfac2b1mr6562851eja.9.1714380281580; Mon, 29 Apr 2024 01:44:41 -0700 (PDT) Received: from [10.40.98.157] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id a7-20020a170906670700b00a522bef9f06sm13610877ejp.181.2024.04.29.01.44.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 01:44:41 -0700 (PDT) Message-ID: <5c7952f2-65ee-4b36-acdb-69098bee51e3@redhat.com> Date: Mon, 29 Apr 2024 10:44:40 +0200 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [jic23-iio:testing 6/16] drivers/iio/industrialio-acpi.c:29: warning: Function parameter or struct member 'orientation' not described in 'iio_read_acpi_mount_matrix' To: Jonathan Cameron , kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, jic23@kernel.org References: <202404290216.Uf6waaF1-lkp@intel.com> <20240429094054.000021d3@Huawei.com> From: Hans de Goede In-Reply-To: <20240429094054.000021d3@Huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 4/29/24 10:40 AM, Jonathan Cameron wrote: > On Mon, 29 Apr 2024 02:53:19 +0800 > kernel test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing >> head: 383e66c0de06c77c053a899a9cbc4a9f0c9a5f65 >> commit: 600b6de8062fe195d936971170fd9a57b6fcb57e [6/16] iio: core: Add iio_read_acpi_mount_matrix() helper function >> config: riscv-defconfig (https://download.01.org/0day-ci/archive/20240429/202404290216.Uf6waaF1-lkp@intel.com/config) >> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 5ef5eb66fb428aaf61fb51b709f065c069c11242) >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240429/202404290216.Uf6waaF1-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202404290216.Uf6waaF1-lkp@intel.com/ >> >> All warnings (new ones prefixed by >>): >> >>>> drivers/iio/industrialio-acpi.c:29: warning: Function parameter or struct member 'orientation' not described in 'iio_read_acpi_mount_matrix' >>>> drivers/iio/industrialio-acpi.c:29: warning: Function parameter or struct member 'acpi_method' not described in 'iio_read_acpi_mount_matrix' >>>> drivers/iio/industrialio-acpi.c:29: warning: Excess function parameter 'matrix' description in 'iio_read_acpi_mount_matrix' >>>> drivers/iio/industrialio-acpi.c:29: warning: Excess function parameter 'method_name' description in 'iio_read_acpi_mount_matrix' >> >> >> vim +29 drivers/iio/industrialio-acpi.c > > I'll fix these up when I'm next on the right computer. Thanks. I did test-build the docs, but I did not notice this my bad. Regards, Hans >> 8 >> 9 /** >> 10 * iio_read_acpi_mount_matrix() - Read accelerometer mount matrix info from ACPI >> 11 * @dev: Device structure >> 12 * @matrix: iio_mount_matrix struct to fill >> 13 * @method_name: ACPI method name to read the matrix from, usually "ROTM" >> 14 * >> 15 * Try to read the mount-matrix by calling the specified method on the device's >> 16 * ACPI firmware-node. If the device has no ACPI firmware-node; or the method >> 17 * does not exist then this will fail silently. This expects the method to >> 18 * return data in the ACPI "ROTM" format defined by Microsoft: >> 19 * https://learn.microsoft.com/en-us/windows-hardware/drivers/sensors/sensors-acpi-entries >> 20 * This is a Microsoft extension and not part of the official ACPI spec. >> 21 * The method name is configurable because some dual-accel setups define 2 mount >> 22 * matrices in a single ACPI device using separate "ROMK" and "ROMS" methods. >> 23 * >> 24 * Returns: true if the matrix was successfully, false otherwise. >> 25 */ >> 26 bool iio_read_acpi_mount_matrix(struct device *dev, >> 27 struct iio_mount_matrix *orientation, >> 28 char *acpi_method) >> > 29 { >> >