From: Dmitry Antipov <dmantipov@yandex.ru>
To: Armin Wolf <W_Armin@gmx.de>
Cc: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: ACPI BIOS bug and memory leak?
Date: Tue, 2 Apr 2024 21:26:07 +0300 [thread overview]
Message-ID: <56f94776-484f-48c0-8855-dba8e6a7793b@yandex.ru> (raw)
In-Reply-To: <cb9c17e4-53f0-4579-879a-0a8fa1352fb9@gmx.de>
On 3/31/24 05:46, Armin Wolf wrote:
> i thing the memory leak happens in acpi_ps_get_next_arg(). After allocating an acpi_parse_object in line 820 of psargs.c,
> calling of acpi_ps_get_next_namepath() fails due to to the missing symbol. The code now returns the error without freeing
> the acpi_parse_object, causing a memory leak.
>
> IMHO the solution would be to call acpi_ps_free_op() in case of an error before returning said error code. I attached an
> experimental patch which might fix this, but it is still untested. If you want you can test if it solves the problem.
This seems fixes the leak indeed (running upstream as of 026e680b0a08a62b1d948e5a8ca78700bfac0e6e).
Feel free to resubmit with Tested-by: <me>, including the following if needed:
Tested on HP ProBook 450 G8 Notebook PC (2X7X3EA#ABB), with 'dmidecode -t bios' as shown below:
Vendor: HP
Version: T87 Ver. 01.12.00
Release Date: 01/03/2023
Address: 0xF0000
Runtime Size: 64 kB
ROM Size: 32 MB
Characteristics:
PCI is supported
PC Card (PCMCIA) is supported
BIOS is upgradeable
BIOS shadowing is allowed
Boot from CD is supported
Selectable boot is supported
EDD is supported
Print screen service is supported (int 5h)
8042 keyboard services are supported (int 9h)
Serial services are supported (int 14h)
Printer services are supported (int 17h)
ACPI is supported
USB legacy is supported
Smart battery is supported
BIOS boot specification is supported
Function key-initiated network boot is supported
Targeted content distribution is supported
UEFI is supported
BIOS Revision: 12.0
Firmware Revision: 84.22
Dmitry
prev parent reply other threads:[~2024-04-02 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 10:48 ACPI BIOS bug and memory leak? Dmitry Antipov
2024-03-31 2:46 ` Armin Wolf
2024-04-02 18:26 ` Dmitry Antipov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56f94776-484f-48c0-8855-dba8e6a7793b@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=W_Armin@gmx.de \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.