All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
@ 2014-10-13 13:48 Ard Biesheuvel
       [not found] ` <1413208113-16374-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2014-10-13 13:48 UTC (permalink / raw
  To: leif.lindholm-QSEj5FYQhm4dnm+yROfE0A,
	roy.franz-QSEj5FYQhm4dnm+yROfE0A,
	matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A
  Cc: Suravee.Suthikulpanit-5C7GfCeVMHo, Ard Biesheuvel

Version 3.0 of the DTMF SMBIOS reference spec defines a new entry point
type that supports a 64-bit address for the SMBIOS structure table. This
is needed by platforms whose system RAM resides above the 4 GB physical
address boundary, such as upcoming 64-bit ARM platforms.

This is a preliminary RFC implementation, as there is no definition available
yet for SMBIOS3_TABLE_GUID, which the (currently still in draft) SMBIOS v3.0
spec refers to.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/firmware/dmi_scan.c | 70 +++++++++++++++++++++++++++++++++++++++++++--
 drivers/firmware/efi/efi.c  |  4 +++
 include/linux/efi.h         |  6 +++-
 3 files changed, 77 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 17afc51f3054..6e33072c3ac3 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -93,6 +93,12 @@ static void dmi_table(u8 *buf, int len, int num,
 		const struct dmi_header *dm = (const struct dmi_header *)data;
 
 		/*
+		 * 7.45 End-of-Table (Type 127) [SMBIOS reference spec v3.0.0]
+		 */
+		if (dm->type == 127)
+			break;
+
+		/*
 		 *  We want to know the total length (formatted area and
 		 *  strings) before decoding to make sure we won't run off the
 		 *  table in dmi_decode or dmi_string
@@ -107,7 +113,7 @@ static void dmi_table(u8 *buf, int len, int num,
 	}
 }
 
-static u32 dmi_base;
+static phys_addr_t dmi_base;
 static u16 dmi_len;
 static u16 dmi_num;
 
@@ -514,12 +520,72 @@ static int __init dmi_present(const u8 *buf)
 	return 1;
 }
 
+/*
+ * Check for the SMBIOS 3.0 64-bit entry point signature. Unlike the legacy
+ * 32-bit entry point, there is no embedded DMI header (_DMI_) in here.
+ */
+static int __init dmi_smbios3_present(const u8 *buf)
+{
+	if (memcmp(buf, "_SM3_", 5) == 0 &&
+	    buf[6] < 32 && dmi_checksum(buf, buf[6])) {
+		dmi_ver = get_unaligned_be16(buf + 7);
+		dmi_len = get_unaligned_le32(buf + 12);
+		dmi_base = get_unaligned_le64(buf + 16);
+
+		/*
+		 * The 64-bit SMBIOS 3.0 entry point no longer has a field
+		 * containing the number of structures present in the table.
+		 * Instead, it defines the table size as a maximum size, and
+		 * relies on the end-of-table structure type (#127) to be used
+		 * to signal the end of the table.
+		 * So let's define dmi_num as an upper bound as well: each
+		 * structure has a 4 byte header, so dmi_len / 4 is an upper
+		 * bound of the number of structures in the table.
+		 */
+		dmi_num = dmi_len / 4;
+
+		if (dmi_walk_early(dmi_decode) == 0) {
+			pr_info("SMBIOS %d.%d present.\n",
+			        dmi_ver >> 8, dmi_ver & 0xFF);
+			dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
+			printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string);
+			return 0;
+		}
+	}
+	return 1;
+}
+
 void __init dmi_scan_machine(void)
 {
 	char __iomem *p, *q;
 	char buf[32];
 
 	if (efi_enabled(EFI_CONFIG_TABLES)) {
+		/*
+		 * According to the DTMF SMBIOS reference spec v3.0.0, it is
+		 * allowed to define both the 64-bit entry point (smbios3) and
+		 * the 32-bit entry point (smbios), in which case they should
+		 * either both point to the same SMBIOS structure table, or the
+		 * table pointed to by the 64-bit entry point should contain a
+		 * superset of the table contents pointed to by the 32-bit entry
+		 * point (section 5.2)
+		 * This implies that the 64-bit entry point should have
+		 * precedence if it is defined and supported by the OS. If we
+		 * have the 64-bit entry point, but fail to decode it, fall
+		 * back to the legacy one (if available)
+		 */
+		if (efi.smbios3 != EFI_INVALID_TABLE_ADDR) {
+			p = dmi_early_remap(efi.smbios3, 32);
+			if (p == NULL)
+				goto error;
+			memcpy_fromio(buf, p, 32);
+			dmi_early_unmap(p, 32);
+
+			if (!dmi_smbios3_present(buf)) {
+				dmi_available = 1;
+				goto out;
+			}
+		}
 		if (efi.smbios == EFI_INVALID_TABLE_ADDR)
 			goto error;
 
@@ -552,7 +618,7 @@ void __init dmi_scan_machine(void)
 		memset(buf, 0, 16);
 		for (q = p; q < p + 0x10000; q += 16) {
 			memcpy_fromio(buf + 16, q, 16);
-			if (!dmi_present(buf)) {
+			if (!dmi_smbios3_present(buf) || !dmi_present(buf)) {
 				dmi_available = 1;
 				dmi_early_unmap(p, 0x10000);
 				goto out;
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 8590099ac148..9035c1b74d58 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -30,6 +30,7 @@ struct efi __read_mostly efi = {
 	.acpi       = EFI_INVALID_TABLE_ADDR,
 	.acpi20     = EFI_INVALID_TABLE_ADDR,
 	.smbios     = EFI_INVALID_TABLE_ADDR,
+	.smbios3    = EFI_INVALID_TABLE_ADDR,
 	.sal_systab = EFI_INVALID_TABLE_ADDR,
 	.boot_info  = EFI_INVALID_TABLE_ADDR,
 	.hcdp       = EFI_INVALID_TABLE_ADDR,
@@ -86,6 +87,8 @@ static ssize_t systab_show(struct kobject *kobj,
 		str += sprintf(str, "ACPI=0x%lx\n", efi.acpi);
 	if (efi.smbios != EFI_INVALID_TABLE_ADDR)
 		str += sprintf(str, "SMBIOS=0x%lx\n", efi.smbios);
+	if (efi.smbios3 != EFI_INVALID_TABLE_ADDR)
+		str += sprintf(str, "SMBIOS3=0x%lx\n", efi.smbios3);
 	if (efi.hcdp != EFI_INVALID_TABLE_ADDR)
 		str += sprintf(str, "HCDP=0x%lx\n", efi.hcdp);
 	if (efi.boot_info != EFI_INVALID_TABLE_ADDR)
@@ -260,6 +263,7 @@ static __initdata efi_config_table_type_t common_tables[] = {
 	{MPS_TABLE_GUID, "MPS", &efi.mps},
 	{SAL_SYSTEM_TABLE_GUID, "SALsystab", &efi.sal_systab},
 	{SMBIOS_TABLE_GUID, "SMBIOS", &efi.smbios},
+	{SMBIOS3_TABLE_GUID, "SMBIOS 3.0", &efi.smbios3},
 	{UGA_IO_PROTOCOL_GUID, "UGA", &efi.uga},
 	{NULL_GUID, NULL, NULL},
 };
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 0949f9c7e872..7704f587fc15 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -547,6 +547,9 @@ void efi_native_runtime_setup(void);
 #define SMBIOS_TABLE_GUID    \
     EFI_GUID(  0xeb9d2d31, 0x2d88, 0x11d3, 0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d )
 
+#define SMBIOS3_TABLE_GUID    \
+    EFI_GUID(  0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 )
+
 #define SAL_SYSTEM_TABLE_GUID    \
     EFI_GUID(  0xeb9d2d32, 0x2d88, 0x11d3, 0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d )
 
@@ -810,7 +813,8 @@ extern struct efi {
 	unsigned long mps;		/* MPS table */
 	unsigned long acpi;		/* ACPI table  (IA64 ext 0.71) */
 	unsigned long acpi20;		/* ACPI table  (ACPI 2.0) */
-	unsigned long smbios;		/* SM BIOS table */
+	unsigned long smbios;		/* SM BIOS table (32 bit entry point) */
+	unsigned long smbios3;		/* SM BIOS table (64 bit entry point) */
 	unsigned long sal_systab;	/* SAL system table */
 	unsigned long boot_info;	/* boot info table */
 	unsigned long hcdp;		/* HCDP table */
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found] ` <1413208113-16374-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2014-10-13 14:01   ` Suravee Suthikulanit
       [not found]     ` <543BDB38.6030807-5C7GfCeVMHo@public.gmane.org>
  2014-10-14 10:59   ` Leif Lindholm
  1 sibling, 1 reply; 9+ messages in thread
From: Suravee Suthikulanit @ 2014-10-13 14:01 UTC (permalink / raw
  To: Ard Biesheuvel, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A,
	roy.franz-QSEj5FYQhm4dnm+yROfE0A,
	matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A

On 10/13/2014 8:48 AM, Ard Biesheuvel wrote:
> +#define SMBIOS3_TABLE_GUID    \
> +    EFI_GUID(  0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 )
> +

Ard,

I believe the new SMBIOS3_TABLE_GUILD has already been accepted by the USWG.

#define SMBIOS3_TABLE_GUID \
    {0xf2fd1544, 0x9794, 0x4a2c, 0x99, 0x2e, 0xe5, 0xbb, 0xcf, 0x20,
0xe3, 0x94}

Thanks,

Suravee

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found]     ` <543BDB38.6030807-5C7GfCeVMHo@public.gmane.org>
@ 2014-10-13 14:07       ` Ard Biesheuvel
       [not found]         ` <1B8BA5BD-37A2-4447-AD3A-B138F7518C87-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  2014-10-14 14:15       ` Suravee Suthikulanit
  1 sibling, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2014-10-13 14:07 UTC (permalink / raw
  To: Suravee Suthikulanit
  Cc: <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	<roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	<x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>




> On 13 okt. 2014, at 16:01, Suravee Suthikulanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org> wrote:
> 
>> On 10/13/2014 8:48 AM, Ard Biesheuvel wrote:
>> +#define SMBIOS3_TABLE_GUID    \
>> +    EFI_GUID(  0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 )
>> +
> 
> Ard,
> 
> I believe the new SMBIOS3_TABLE_GUILD has already been accepted by the USWG.
> 
> #define SMBIOS3_TABLE_GUID \
>   {0xf2fd1544, 0x9794, 0x4a2c, 0x99, 0x2e, 0xe5, 0xbb, 0xcf, 0x20,
> 0xe3, 0x94}
> 

ah, good. got a link?


> Thanks,
> 
> Suravee
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found]         ` <1B8BA5BD-37A2-4447-AD3A-B138F7518C87-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2014-10-13 14:29           ` Suravee Suthikulanit
  0 siblings, 0 replies; 9+ messages in thread
From: Suravee Suthikulanit @ 2014-10-13 14:29 UTC (permalink / raw
  To: Ard Biesheuvel
  Cc: <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	<roy.franz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	<x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On 10/13/2014 9:07 AM, Ard Biesheuvel wrote:
>
>
>
>> On 13 okt. 2014, at 16:01, Suravee Suthikulanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org> wrote:
>>
>>> On 10/13/2014 8:48 AM, Ard Biesheuvel wrote:
>>> +#define SMBIOS3_TABLE_GUID    \
>>> +    EFI_GUID(  0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 )
>>> +
>>
>> Ard,
>>
>> I believe the new SMBIOS3_TABLE_GUILD has already been accepted by the USWG.
>>
>> #define SMBIOS3_TABLE_GUID \
>>    {0xf2fd1544, 0x9794, 0x4a2c, 0x99, 0x2e, 0xe5, 0xbb, 0xcf, 0x20,
>> 0xe3, 0x94}
>>
>
> ah, good. got a link?

I have been told that this is defined in the USWG CR 1191. Not sure how 
to access this info.

Suravee

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found] ` <1413208113-16374-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  2014-10-13 14:01   ` Suravee Suthikulanit
@ 2014-10-14 10:59   ` Leif Lindholm
       [not found]     ` <20141014105951.GE22224-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
  1 sibling, 1 reply; 9+ messages in thread
From: Leif Lindholm @ 2014-10-14 10:59 UTC (permalink / raw
  To: Ard Biesheuvel
  Cc: roy.franz-QSEj5FYQhm4dnm+yROfE0A,
	matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A,
	Suravee.Suthikulpanit-5C7GfCeVMHo

On Mon, Oct 13, 2014 at 03:48:33PM +0200, Ard Biesheuvel wrote:
> Version 3.0 of the DTMF SMBIOS reference spec defines a new entry point
> type that supports a 64-bit address for the SMBIOS structure table. This
> is needed by platforms whose system RAM resides above the 4 GB physical
> address boundary, such as upcoming 64-bit ARM platforms.
> 
> This is a preliminary RFC implementation, as there is no definition available
> yet for SMBIOS3_TABLE_GUID, which the (currently still in draft) SMBIOS v3.0
> spec refers to.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  				goto out;
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 8590099ac148..9035c1b74d58 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -30,6 +30,7 @@ struct efi __read_mostly efi = {
>  	.acpi       = EFI_INVALID_TABLE_ADDR,
>  	.acpi20     = EFI_INVALID_TABLE_ADDR,
>  	.smbios     = EFI_INVALID_TABLE_ADDR,
> +	.smbios3    = EFI_INVALID_TABLE_ADDR,

Is there any particular need to add a separate pointer for v3?
In both cases, the pointer is a physical address stored as an unsigned
long.

/
    Leif

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found]     ` <20141014105951.GE22224-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
@ 2014-10-14 12:20       ` Ard Biesheuvel
  0 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2014-10-14 12:20 UTC (permalink / raw
  To: Leif Lindholm
  Cc: Roy Franz, Matt Fleming,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Suravee Suthikulpanit

On 14 October 2014 12:59, Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Mon, Oct 13, 2014 at 03:48:33PM +0200, Ard Biesheuvel wrote:
>> Version 3.0 of the DTMF SMBIOS reference spec defines a new entry point
>> type that supports a 64-bit address for the SMBIOS structure table. This
>> is needed by platforms whose system RAM resides above the 4 GB physical
>> address boundary, such as upcoming 64-bit ARM platforms.
>>
>> This is a preliminary RFC implementation, as there is no definition available
>> yet for SMBIOS3_TABLE_GUID, which the (currently still in draft) SMBIOS v3.0
>> spec refers to.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>                               goto out;
>> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
>> index 8590099ac148..9035c1b74d58 100644
>> --- a/drivers/firmware/efi/efi.c
>> +++ b/drivers/firmware/efi/efi.c
>> @@ -30,6 +30,7 @@ struct efi __read_mostly efi = {
>>       .acpi       = EFI_INVALID_TABLE_ADDR,
>>       .acpi20     = EFI_INVALID_TABLE_ADDR,
>>       .smbios     = EFI_INVALID_TABLE_ADDR,
>> +     .smbios3    = EFI_INVALID_TABLE_ADDR,
>
> Is there any particular need to add a separate pointer for v3?
> In both cases, the pointer is a physical address stored as an unsigned
> long.
>

Yes, but they point to different header types, and the firmware could
legally provide either type or both (in which case, they may point to
the same SMBIOS structure table, or to distinct ones), and it is up to
DMI to interpret that, not EFI.

At the DMI level, we should be strict IMO and only interpret the new
_SM3_ entry point header if it was supplied using the
SMBIOS3_TABLE_GUID, so even if we use the same table pointer, we would
need to store additional data regarding which GUID was used.

-- 
Ard.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found]     ` <543BDB38.6030807-5C7GfCeVMHo@public.gmane.org>
  2014-10-13 14:07       ` Ard Biesheuvel
@ 2014-10-14 14:15       ` Suravee Suthikulanit
       [not found]         ` <543D3019.1020404-5C7GfCeVMHo@public.gmane.org>
  1 sibling, 1 reply; 9+ messages in thread
From: Suravee Suthikulanit @ 2014-10-14 14:15 UTC (permalink / raw
  To: Ard Biesheuvel, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A,
	roy.franz-QSEj5FYQhm4dnm+yROfE0A,
	matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A

On 10/13/2014 9:01 AM, Suravee Suthikulanit wrote:
> On 10/13/2014 8:48 AM, Ard Biesheuvel wrote:
>> +#define SMBIOS3_TABLE_GUID    \
>> +    EFI_GUID(  0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00,
>> 0x00, 0x00, 0x00, 0x00 )
>> +
>
> Ard,
>
> I believe the new SMBIOS3_TABLE_GUILD has already been accepted by the
> USWG.
>
> #define SMBIOS3_TABLE_GUID \
>     {0xf2fd1544, 0x9794, 0x4a2c, 0x99, 0x2e, 0xe5, 0xbb, 0xcf, 0x20,
> 0xe3, 0x94}
>
> Thanks,
>
> Suravee

Hi All,

With Yi's original patch + this patch + changes for the the ID above, I 
am able to parse the SMBIOS information (shown below).

bios_date = 12/12/2012
bios_vendor = American Megatrends Inc.
bios_version = 5.6.5
board_asset_tag = Defaultstring
board_name = Defaultstring
board_serial = Defaultstring
board_vendor = Defaultstring
board_version = Defaultstring
chassis_asset_tag = Defaultstring
chassis_serial = Defaultstring
chassis_type = 3
chassis_vendor = Defaultstring
chassis_version = Defaultstring
modalias = 
dmi:bvnAmericanMegatrendsInc.:bvr5.6.5:bd12/12/2012:svnDefaultstring:pnDefaultstring:pvrDefaultstring:rvnDefaultstring:rnDefaultstring:rvrDefaultstring:cvnDefaultstring:ct3:cvrDefaultstring:
cat: power: Is a directory
power =
product_name = Defaultstring
product_serial = Defaultstring
product_uuid = 00020003-0004-0005-0006-000700080009
product_version = Defaultstring
cat: subsystem: Is a directory
subsystem =
sys_vendor = Defaultstring
uevent = 
MODALIAS=dmi:bvnAmericanMegatrendsInc.:bvr5.6.5:bd12/12/2012:svnDefaultstring:pnDefaultstring:pvrDefaultstring:rvnDefaultstring:rnDefaultstring:rvrDefaultstring:cvnDefaultstring:ct3:cvrDefaultstring:

Also:

[root@acadia-snap4 sys]# find . | grep dmi
./devices/virtual/dmi
./devices/virtual/dmi/id
./devices/virtual/dmi/id/product_name
./devices/virtual/dmi/id/product_uuid
./devices/virtual/dmi/id/board_name
./devices/virtual/dmi/id/board_asset_tag
./devices/virtual/dmi/id/power
./devices/virtual/dmi/id/chassis_serial
./devices/virtual/dmi/id/product_version
./devices/virtual/dmi/id/chassis_vendor
./devices/virtual/dmi/id/modalias
./devices/virtual/dmi/id/chassis_version
./devices/virtual/dmi/id/bios_date
./devices/virtual/dmi/id/bios_version
./devices/virtual/dmi/id/product_serial
./devices/virtual/dmi/id/sys_vendor
./devices/virtual/dmi/id/subsystem
./devices/virtual/dmi/id/bios_vendor
./devices/virtual/dmi/id/board_serial
./devices/virtual/dmi/id/uevent
./devices/virtual/dmi/id/chassis_asset_tag
./devices/virtual/dmi/id/chassis_type
./devices/virtual/dmi/id/board_vendor
./devices/virtual/dmi/id/board_version
./class/dmi
./class/dmi/id
./firmware/dmi
./firmware/dmi/entries
./firmware/dmi/entries/0-0
./firmware/dmi/entries/0-0/raw
./firmware/dmi/entries/0-0/type
./firmware/dmi/entries/0-0/position
./firmware/dmi/entries/0-0/handle
./firmware/dmi/entries/0-0/length
./firmware/dmi/entries/0-0/instance
./firmware/dmi/entries/1-0
./firmware/dmi/entries/1-0/raw
./firmware/dmi/entries/1-0/type
./firmware/dmi/entries/1-0/position
./firmware/dmi/entries/1-0/handle
./firmware/dmi/entries/1-0/length
./firmware/dmi/entries/1-0/instance
.....

Thanks for working on adding this support.

Suravee

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found]         ` <543D3019.1020404-5C7GfCeVMHo@public.gmane.org>
@ 2014-10-14 14:19           ` Ard Biesheuvel
       [not found]             ` <CAKv+Gu95g=wUtQOJtx4kNVOZ6qJmcZTVukNNQQ_vJNW074tQwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2014-10-14 14:19 UTC (permalink / raw
  To: Suravee Suthikulanit
  Cc: Leif Lindholm, Roy Franz, Matt Fleming,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

On 14 October 2014 16:15, Suravee Suthikulanit
<suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org> wrote:
> On 10/13/2014 9:01 AM, Suravee Suthikulanit wrote:
>>
>> On 10/13/2014 8:48 AM, Ard Biesheuvel wrote:
>>>
>>> +#define SMBIOS3_TABLE_GUID    \
>>> +    EFI_GUID(  0x00000000, 0x0000, 0x0000, 0x00, 0x00, 0x00, 0x00,
>>> 0x00, 0x00, 0x00, 0x00 )
>>> +
>>
>>
>> Ard,
>>
>> I believe the new SMBIOS3_TABLE_GUILD has already been accepted by the
>> USWG.
>>
>> #define SMBIOS3_TABLE_GUID \
>>     {0xf2fd1544, 0x9794, 0x4a2c, 0x99, 0x2e, 0xe5, 0xbb, 0xcf, 0x20,
>> 0xe3, 0x94}
>>
>> Thanks,
>>
>> Suravee
>
>
> Hi All,
>
> With Yi's original patch + this patch + changes for the the ID above, I am
> able to parse the SMBIOS information (shown below).
>

Great news! May I add your tested-by to the patches?

Regards,
Ard.

> bios_date = 12/12/2012
> bios_vendor = American Megatrends Inc.
> bios_version = 5.6.5
> board_asset_tag = Defaultstring
> board_name = Defaultstring
> board_serial = Defaultstring
> board_vendor = Defaultstring
> board_version = Defaultstring
> chassis_asset_tag = Defaultstring
> chassis_serial = Defaultstring
> chassis_type = 3
> chassis_vendor = Defaultstring
> chassis_version = Defaultstring
> modalias =
> dmi:bvnAmericanMegatrendsInc.:bvr5.6.5:bd12/12/2012:svnDefaultstring:pnDefaultstring:pvrDefaultstring:rvnDefaultstring:rnDefaultstring:rvrDefaultstring:cvnDefaultstring:ct3:cvrDefaultstring:
> cat: power: Is a directory
> power =
> product_name = Defaultstring
> product_serial = Defaultstring
> product_uuid = 00020003-0004-0005-0006-000700080009
> product_version = Defaultstring
> cat: subsystem: Is a directory
> subsystem =
> sys_vendor = Defaultstring
> uevent =
> MODALIAS=dmi:bvnAmericanMegatrendsInc.:bvr5.6.5:bd12/12/2012:svnDefaultstring:pnDefaultstring:pvrDefaultstring:rvnDefaultstring:rnDefaultstring:rvrDefaultstring:cvnDefaultstring:ct3:cvrDefaultstring:
>
> Also:
>
> [root@acadia-snap4 sys]# find . | grep dmi
> ./devices/virtual/dmi
> ./devices/virtual/dmi/id
> ./devices/virtual/dmi/id/product_name
> ./devices/virtual/dmi/id/product_uuid
> ./devices/virtual/dmi/id/board_name
> ./devices/virtual/dmi/id/board_asset_tag
> ./devices/virtual/dmi/id/power
> ./devices/virtual/dmi/id/chassis_serial
> ./devices/virtual/dmi/id/product_version
> ./devices/virtual/dmi/id/chassis_vendor
> ./devices/virtual/dmi/id/modalias
> ./devices/virtual/dmi/id/chassis_version
> ./devices/virtual/dmi/id/bios_date
> ./devices/virtual/dmi/id/bios_version
> ./devices/virtual/dmi/id/product_serial
> ./devices/virtual/dmi/id/sys_vendor
> ./devices/virtual/dmi/id/subsystem
> ./devices/virtual/dmi/id/bios_vendor
> ./devices/virtual/dmi/id/board_serial
> ./devices/virtual/dmi/id/uevent
> ./devices/virtual/dmi/id/chassis_asset_tag
> ./devices/virtual/dmi/id/chassis_type
> ./devices/virtual/dmi/id/board_vendor
> ./devices/virtual/dmi/id/board_version
> ./class/dmi
> ./class/dmi/id
> ./firmware/dmi
> ./firmware/dmi/entries
> ./firmware/dmi/entries/0-0
> ./firmware/dmi/entries/0-0/raw
> ./firmware/dmi/entries/0-0/type
> ./firmware/dmi/entries/0-0/position
> ./firmware/dmi/entries/0-0/handle
> ./firmware/dmi/entries/0-0/length
> ./firmware/dmi/entries/0-0/instance
> ./firmware/dmi/entries/1-0
> ./firmware/dmi/entries/1-0/raw
> ./firmware/dmi/entries/1-0/type
> ./firmware/dmi/entries/1-0/position
> ./firmware/dmi/entries/1-0/handle
> ./firmware/dmi/entries/1-0/length
> ./firmware/dmi/entries/1-0/instance
> .....
>
> Thanks for working on adding this support.
>
> Suravee
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point
       [not found]             ` <CAKv+Gu95g=wUtQOJtx4kNVOZ6qJmcZTVukNNQQ_vJNW074tQwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-10-14 14:35               ` Suravee Suthikulanit
  0 siblings, 0 replies; 9+ messages in thread
From: Suravee Suthikulanit @ 2014-10-14 14:35 UTC (permalink / raw
  To: Ard Biesheuvel
  Cc: Leif Lindholm, Roy Franz, Matt Fleming,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

On 10/14/2014 9:19 AM, Ard Biesheuvel wrote:
>> >Hi All,
>> >
>> >With Yi's original patch + this patch + changes for the the ID above, I am
>> >able to parse the SMBIOS information (shown below).
>> >
> Great news! May I add your tested-by to the patches?
>
> Regards,
> Ard.
>

<tested-by> Suravee Suthikulpanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-10-14 14:35 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-13 13:48 [RFC PATCH] dmi: add support for SMBIOS 3.0 64-bit entry point Ard Biesheuvel
     [not found] ` <1413208113-16374-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-10-13 14:01   ` Suravee Suthikulanit
     [not found]     ` <543BDB38.6030807-5C7GfCeVMHo@public.gmane.org>
2014-10-13 14:07       ` Ard Biesheuvel
     [not found]         ` <1B8BA5BD-37A2-4447-AD3A-B138F7518C87-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-10-13 14:29           ` Suravee Suthikulanit
2014-10-14 14:15       ` Suravee Suthikulanit
     [not found]         ` <543D3019.1020404-5C7GfCeVMHo@public.gmane.org>
2014-10-14 14:19           ` Ard Biesheuvel
     [not found]             ` <CAKv+Gu95g=wUtQOJtx4kNVOZ6qJmcZTVukNNQQ_vJNW074tQwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-14 14:35               ` Suravee Suthikulanit
2014-10-14 10:59   ` Leif Lindholm
     [not found]     ` <20141014105951.GE22224-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
2014-10-14 12:20       ` Ard Biesheuvel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.