* [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined
@ 2014-09-02 11:02 Irina Tirdea
2014-09-06 12:12 ` Hartmut Knaack
0 siblings, 1 reply; 4+ messages in thread
From: Irina Tirdea @ 2014-09-02 11:02 UTC (permalink / raw
To: Jonathan Cameron, linux-iio
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
Srinivas Pandruvada, linux-kernel, Irina Tirdea
When CONFIG_PM_RUNTIME is not defined and bmg160 tries to power
off the device, bmg160_set_power_state will call pm_runtime_put_autosuspend,
which is not implemented (wil return -ENOSYS).
Only call bmg160_set_power_state when CONFIG_PM_RUNTIME is defined.
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/gyro/bmg160.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/gyro/bmg160.c b/drivers/iio/gyro/bmg160.c
index 7524698..e41d6b5 100644
--- a/drivers/iio/gyro/bmg160.c
+++ b/drivers/iio/gyro/bmg160.c
@@ -235,6 +235,7 @@ static int bmg160_chip_init(struct bmg160_data *data)
return 0;
}
+#ifdef CONFIG_PM_RUNTIME
static int bmg160_set_power_state(struct bmg160_data *data, bool on)
{
int ret;
@@ -254,6 +255,12 @@ static int bmg160_set_power_state(struct bmg160_data *data, bool on)
return 0;
}
+#else
+static int bmg160_set_power_state(struct bmg160_data *data, bool on)
+{
+ return 0;
+}
+#endif
static int bmg160_setup_any_motion_interrupt(struct bmg160_data *data,
bool status)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined
2014-09-02 11:02 [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined Irina Tirdea
@ 2014-09-06 12:12 ` Hartmut Knaack
2014-09-08 13:50 ` Tirdea, Irina
0 siblings, 1 reply; 4+ messages in thread
From: Hartmut Knaack @ 2014-09-06 12:12 UTC (permalink / raw
To: Irina Tirdea, Jonathan Cameron, linux-iio
Cc: Lars-Peter Clausen, Peter Meerwald, Srinivas Pandruvada,
linux-kernel
Irina Tirdea schrieb:
> When CONFIG_PM_RUNTIME is not defined and bmg160 tries to power
> off the device, bmg160_set_power_state will call pm_runtime_put_autosuspend,
> which is not implemented (wil return -ENOSYS).
>
> Only call bmg160_set_power_state when CONFIG_PM_RUNTIME is defined.
Unless there is anything more to come, what about putting the #ifdef into first line inside bmg160_set_power_state() and just an #endif before the return 0 at the end? Saves 5 lines.
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/iio/gyro/bmg160.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/gyro/bmg160.c b/drivers/iio/gyro/bmg160.c
> index 7524698..e41d6b5 100644
> --- a/drivers/iio/gyro/bmg160.c
> +++ b/drivers/iio/gyro/bmg160.c
> @@ -235,6 +235,7 @@ static int bmg160_chip_init(struct bmg160_data *data)
> return 0;
> }
>
> +#ifdef CONFIG_PM_RUNTIME
> static int bmg160_set_power_state(struct bmg160_data *data, bool on)
> {
> int ret;
> @@ -254,6 +255,12 @@ static int bmg160_set_power_state(struct bmg160_data *data, bool on)
>
> return 0;
> }
> +#else
> +static int bmg160_set_power_state(struct bmg160_data *data, bool on)
> +{
> + return 0;
> +}
> +#endif
>
> static int bmg160_setup_any_motion_interrupt(struct bmg160_data *data,
> bool status)
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined
2014-09-06 12:12 ` Hartmut Knaack
@ 2014-09-08 13:50 ` Tirdea, Irina
0 siblings, 0 replies; 4+ messages in thread
From: Tirdea, Irina @ 2014-09-08 13:50 UTC (permalink / raw
To: Hartmut Knaack
Cc: Lars-Peter Clausen, Peter Meerwald, Srinivas Pandruvada,
linux-kernel@vger.kernel.org, Jonathan Cameron,
linux-iio@vger.kernel.org
> -----Original Message-----
> From: linux-iio-owner@vger.kernel.org [mailto:linux-iio-owner@vger.kernel.org] On Behalf Of Hartmut Knaack
> Sent: 06 September, 2014 15:12
> To: Tirdea, Irina; Jonathan Cameron; linux-iio@vger.kernel.org
> Cc: Lars-Peter Clausen; Peter Meerwald; Srinivas Pandruvada; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined
>
> Irina Tirdea schrieb:
> > When CONFIG_PM_RUNTIME is not defined and bmg160 tries to power
> > off the device, bmg160_set_power_state will call pm_runtime_put_autosuspend,
> > which is not implemented (wil return -ENOSYS).
> >
> > Only call bmg160_set_power_state when CONFIG_PM_RUNTIME is defined.
> Unless there is anything more to come, what about putting the #ifdef into first line inside bmg160_set_power_state() and just an
> #endif before the return 0 at the end? Saves 5 lines.
Thanks for the suggestion! Will fix it in v2.
> > Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > ---
Thanks,
Irina
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined
@ 2014-09-08 13:50 ` Tirdea, Irina
0 siblings, 0 replies; 4+ messages in thread
From: Tirdea, Irina @ 2014-09-08 13:50 UTC (permalink / raw
To: Hartmut Knaack
Cc: Lars-Peter Clausen, Peter Meerwald, Srinivas Pandruvada,
linux-kernel@vger.kernel.org, Jonathan Cameron,
linux-iio@vger.kernel.org
> -----Original Message-----
> From: linux-iio-owner@vger.kernel.org [mailto:linux-iio-owner@vger.kernel=
.org] On Behalf Of Hartmut Knaack
> Sent: 06 September, 2014 15:12
> To: Tirdea, Irina; Jonathan Cameron; linux-iio@vger.kernel.org
> Cc: Lars-Peter Clausen; Peter Meerwald; Srinivas Pandruvada; linux-kernel=
@vger.kernel.org
> Subject: Re: [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIM=
E is defined
>=20
> Irina Tirdea schrieb:
> > When CONFIG_PM_RUNTIME is not defined and bmg160 tries to power
> > off the device, bmg160_set_power_state will call pm_runtime_put_autosus=
pend,
> > which is not implemented (wil return -ENOSYS).
> >
> > Only call bmg160_set_power_state when CONFIG_PM_RUNTIME is defined.
> Unless there is anything more to come, what about putting the #ifdef into=
first line inside bmg160_set_power_state() and just an
> #endif before the return 0 at the end? Saves 5 lines.
Thanks for the suggestion! Will fix it in v2.
> > Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > ---
Thanks,
Irina
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-08 13:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 11:02 [PATCH] iio: gyro: bmg160: only set power state if PM_RUNTIME is defined Irina Tirdea
2014-09-06 12:12 ` Hartmut Knaack
2014-09-08 13:50 ` Tirdea, Irina
2014-09-08 13:50 ` Tirdea, Irina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.