* [merged] cciss-set-max-scatter-gather-entries-to-32-on-p600.patch removed from -mm tree
@ 2013-09-12 19:42 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2013-09-12 19:42 UTC (permalink / raw
To: mm-commits, thenzl, steve.cameron, bubrown, axboe, mike.miller
Subject: [merged] cciss-set-max-scatter-gather-entries-to-32-on-p600.patch removed from -mm tree
To: mike.miller@hp.com,axboe@kernel.dk,bubrown@redhat.com,steve.cameron@hp.com,thenzl@redhat.com,mm-commits@vger.kernel.org
From: akpm@linux-foundation.org
Date: Thu, 12 Sep 2013 12:42:07 -0700
The patch titled
Subject: cciss: set max scatter gather entries to 32 on P600
has been removed from the -mm tree. Its filename was
cciss-set-max-scatter-gather-entries-to-32-on-p600.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Mike Miller <mike.miller@hp.com>
Subject: cciss: set max scatter gather entries to 32 on P600
At one time we used to set the maximum number of scatter gather elements
on all Smart Array controllers to 32. At some point in time the firmware
began to write the "appropriate" value for each controller into the config
table. The cciss driver would then read that and set h->maxsgentries.
h->maxsgentries = readl(&(h->cfgtable->MaxSGElements);
On the P600 that value is 544. Under some workloads a significant
performance reduction may result. This patch forces the P600 to use only
32 scatter gather elements. Other controllers are not affected.
Signed-off-by: Mike Miller <mike.miller@hp.com>
Signed-off-by: Dwight (Bud) Brown <bubrown@redhat.com>
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Acked-by: Stephen M. Cameron <steve.cameron@hp.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/block/cciss.c | 7 +++++++
1 file changed, 7 insertions(+)
diff -puN drivers/block/cciss.c~cciss-set-max-scatter-gather-entries-to-32-on-p600 drivers/block/cciss.c
--- a/drivers/block/cciss.c~cciss-set-max-scatter-gather-entries-to-32-on-p600
+++ a/drivers/block/cciss.c
@@ -4258,6 +4258,13 @@ static void cciss_find_board_params(ctlr
h->nr_cmds = h->max_commands - 4 - cciss_tape_cmds;
h->maxsgentries = readl(&(h->cfgtable->MaxSGElements));
/*
+ * The P600 may exhibit poor performnace under some workloads
+ * if we use the value in the configuration table. Limit this
+ * controller to MAXSGENTRIES (32) instead.
+ */
+ if (h->board_id == 0x3225103C)
+ h->maxsgentries = MAXSGENTRIES;
+ /*
* Limit in-command s/g elements to 32 save dma'able memory.
* Howvever spec says if 0, use 31
*/
_
Patches currently in -mm which might be from mike.miller@hp.com are
origin.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-09-12 19:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-12 19:42 [merged] cciss-set-max-scatter-gather-entries-to-32-on-p600.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.