From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcma: do not initialize deactivated PCIe cores
Date: Mon, 08 Oct 2012 00:01:15 +0200 [thread overview]
Message-ID: <5071FBAB.3020909@hauke-m.de> (raw)
In-Reply-To: <CACna6rw73feYKY7=5MyNjBeYjaC=Q+JmTeR7nfkmh9XxfKeJjw@mail.gmail.com>
On 10/07/2012 09:48 AM, Rafał Miłecki wrote:
> 2012/10/1 Hauke Mehrtens <hauke@hauke-m.de>:
>> @@ -396,6 +391,11 @@ void __devinit bcma_core_pci_hostmode_init(struct bcma_drv_pci *pc)
>>
>> bcma_info(bus, "PCIEcore in host mode found\n");
>>
>> + if (bus->sprom.boardflags_lo & BCMA_CORE_PCI_BFL_NOPCI) {
>> + bcma_info(bus, "This PCIE core is disabled and not working\n");
>> + return;
>> + }
>> +
>
> I wonder if this bit is also valid for client mode PCIe core. Maybe
> this check should be put directly in bcma_core_pci_init?
I put it into the host mode code, because I do not want to interfere
with some wrongly programed client mode pcie devices. I have just seen a
SoC with a PCIe device in hostmode where this option was set. I would
have no problem with moving this into bcma_core_pci_init if someone with
some cards could test it before.
Hauke
prev parent reply other threads:[~2012-10-07 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 22:12 [PATCH] bcma: do not initialize deactivated PCIe cores Hauke Mehrtens
2012-10-07 7:48 ` Rafał Miłecki
2012-10-07 22:01 ` Hauke Mehrtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5071FBAB.3020909@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.