From: Georgi Djakov <djakov@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
konrad.dybcio@linaro.org, dmitry.baryshkov@linaro.org,
quic_anusha@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v10 1/6] interconnect: icc-clk: Allow user to specify master/slave ids
Date: Mon, 29 Apr 2024 14:09:43 +0300 [thread overview]
Message-ID: <4dadb3e5-e2e9-4a42-8020-51104ddca0e1@kernel.org> (raw)
In-Reply-To: <20240429091314.761900-2-quic_varada@quicinc.com>
On 29.04.24 12:13, Varadarajan Narayanan wrote:
> Presently, icc-clk driver autogenerates the master and slave ids.
> However, devices with multiple nodes on the interconnect could
> have other constraints and may not match with the auto generated
> node ids. Hence, allow the driver to provide the preferred master
> and slave ids.
>
> Also, update clk-cbf-8996 accordingly.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
Acked-by: Georgi Djakov <djakov@kernel.org>
> ---
> v9: squash cbf-msm8996 change into this
> v8: Per review feedback, set master/slave ids explicitly. Dont autogenerate
> https://lore.kernel.org/linux-arm-msm/f1b0d280-6986-4055-a611-2caceb15867d@linaro.org/
> ---
> drivers/clk/qcom/clk-cbf-8996.c | 7 ++++++-
> drivers/interconnect/icc-clk.c | 6 +++---
> include/linux/interconnect-clk.h | 2 ++
> 3 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-cbf-8996.c b/drivers/clk/qcom/clk-cbf-8996.c
> index fe24b4abeab4..a077d4403967 100644
> --- a/drivers/clk/qcom/clk-cbf-8996.c
> +++ b/drivers/clk/qcom/clk-cbf-8996.c
> @@ -237,7 +237,12 @@ static int qcom_msm8996_cbf_icc_register(struct platform_device *pdev, struct cl
> struct device *dev = &pdev->dev;
> struct clk *clk = devm_clk_hw_get_clk(dev, cbf_hw, "cbf");
> const struct icc_clk_data data[] = {
> - { .clk = clk, .name = "cbf", },
> + {
> + .clk = clk,
> + .name = "cbf",
> + .master_id = MASTER_CBF_M4M,
> + .slave_id = SLAVE_CBF_M4M,
> + },
> };
> struct icc_provider *provider;
>
> diff --git a/drivers/interconnect/icc-clk.c b/drivers/interconnect/icc-clk.c
> index d787f2ea36d9..2be193fd7d8f 100644
> --- a/drivers/interconnect/icc-clk.c
> +++ b/drivers/interconnect/icc-clk.c
> @@ -108,7 +108,7 @@ struct icc_provider *icc_clk_register(struct device *dev,
> for (i = 0, j = 0; i < num_clocks; i++) {
> qp->clocks[i].clk = data[i].clk;
>
> - node = icc_node_create(first_id + j);
> + node = icc_node_create(first_id + data[i].master_id);
> if (IS_ERR(node)) {
> ret = PTR_ERR(node);
> goto err;
> @@ -118,10 +118,10 @@ struct icc_provider *icc_clk_register(struct device *dev,
> node->data = &qp->clocks[i];
> icc_node_add(node, provider);
> /* link to the next node, slave */
> - icc_link_create(node, first_id + j + 1);
> + icc_link_create(node, first_id + data[i].slave_id);
> onecell->nodes[j++] = node;
>
> - node = icc_node_create(first_id + j);
> + node = icc_node_create(first_id + data[i].slave_id);
> if (IS_ERR(node)) {
> ret = PTR_ERR(node);
> goto err;
> diff --git a/include/linux/interconnect-clk.h b/include/linux/interconnect-clk.h
> index 0cd80112bea5..170898faaacb 100644
> --- a/include/linux/interconnect-clk.h
> +++ b/include/linux/interconnect-clk.h
> @@ -11,6 +11,8 @@ struct device;
> struct icc_clk_data {
> struct clk *clk;
> const char *name;
> + unsigned int master_id;
> + unsigned int slave_id;
> };
>
> struct icc_provider *icc_clk_register(struct device *dev,
next prev parent reply other threads:[~2024-04-29 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 9:13 [PATCH v10 0/6] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-04-29 9:13 ` [PATCH v10 1/6] interconnect: icc-clk: Allow user to specify master/slave ids Varadarajan Narayanan
2024-04-29 11:08 ` Bryan O'Donoghue
2024-04-30 6:30 ` Varadarajan Narayanan
2024-04-29 11:09 ` Georgi Djakov [this message]
2024-04-29 9:13 ` [PATCH v10 2/6] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-04-29 11:10 ` Georgi Djakov
2024-04-29 9:13 ` [PATCH v10 3/6] interconnect: icc-clk: Add devm_icc_clk_register Varadarajan Narayanan
2024-04-29 11:10 ` Georgi Djakov
2024-04-29 9:13 ` [PATCH v10 4/6] clk: qcom: common: Add interconnect clocks support Varadarajan Narayanan
2024-04-29 9:13 ` [PATCH v10 5/6] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks Varadarajan Narayanan
2024-04-29 9:13 ` [PATCH v10 6/6] arm64: dts: qcom: ipq9574: Add icc provider ability to gcc Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dadb3e5-e2e9-4a42-8020-51104ddca0e1@kernel.org \
--to=djakov@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.