From: Peter Rajnoha <prajnoha@redhat.com>
To: Patrick Plenefisch <simonpatp@gmail.com>, lvm-devel@lists.linux.dev
Subject: Re: udev rule bug: LUKS on LVM doesn't expose labels
Date: Mon, 25 Mar 2024 10:33:17 +0100 [thread overview]
Message-ID: <4d6e9fa9-b777-4373-a880-f24f529bc109@redhat.com> (raw)
In-Reply-To: <CAOCpoWfYjOVNJNt+cnOVXDHiDq2wRogTqBijcUoa7chqOLRa5Q@mail.gmail.com>
On 3/22/24 19:18, Patrick Plenefisch wrote:
> Hi,
>
> I noticed that my LUKS-on-LVM setup wasn't generating
> /dev/disk/by-label symlinks. After some poking around, I realized that
> the udev rule doesn't include crypto devices:
>
> udev/13-dm-disk.rules.in:40
>
> ENV{ID_FS_USAGE}=="filesystem|other", ENV{ID_FS_LABEL_ENC}=="?*",
> SYMLINK+="disk/by-label/$env{ID_FS_LABEL_ENC}"
>
> In contrast, the uuid rule does support crypto devices:
>
> udev/13-dm-disk.rules.in:39
>
> ENV{ID_FS_USAGE}=="filesystem|other|crypto",
> ENV{ID_FS_UUID_ENC}=="?*",
> SYMLINK+="disk/by-uuid/$env{ID_FS_UUID_ENC}"
>
> Adding "|crypto" to the label rule and everything seems to work fine
> on my end. Is there some other behavior I'm missing here, or is this a
> bug in the udev rules?
Yes, indeed, it's missing. Thank you for reporting that!
Fixed here: https://gitlab.com/lvmteam/lvm2/-/commit/f09a9927207f81b33b9eee8ac5660d90e695dad1
--
Peter
prev parent reply other threads:[~2024-03-25 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 18:18 udev rule bug: LUKS on LVM doesn't expose labels Patrick Plenefisch
2024-03-25 9:33 ` Peter Rajnoha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6e9fa9-b777-4373-a880-f24f529bc109@redhat.com \
--to=prajnoha@redhat.com \
--cc=lvm-devel@lists.linux.dev \
--cc=simonpatp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.