From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2A46FD9 for ; Thu, 11 Apr 2024 01:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712797868; cv=none; b=lOCMQPuDDv8RiO1uwgkS2AKb0L54ZlK79i4GwKS4OI3Q2sw52R/oDIZS2AJtkLsQ9/elUP00P32n6bnini9l/kyVUSLf8TcLbJtkyi3FDTHoEFfNaJM/Dxjxet6WEcY3jTGkom91sHZcMcnqPbX0KdpnIk0aq1baREOZbCDCl+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712797868; c=relaxed/simple; bh=9YyH9BgEo3s56+nSbcPZpFNHGs99BC+E0EcZLKOsSQ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FfizrOctEZ0w3lauxFua1CRWOmIVYpJ5b8tzQbPo+7MtL93LTyij1ty2GRiFRXngWHhGQO/oA9vOBoP5JTfPrMG28Hma0h2oZf66L3ULZ5jGdg48P8uTkQb2MIzllr1ALpP6t4nfHC5TQgDGIQ1HWkRnrFoWnuynEslXF+oyvQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=XPbVJIBA; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="XPbVJIBA" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5aa27dba8a1so2546662eaf.0 for ; Wed, 10 Apr 2024 18:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712797866; x=1713402666; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=XPbVJIBA5sKDJg5tWzuNq6eZ8A32Qn9WAAu5sC8HAvddiaj0Gjjrj1CWwPyBlUsalv WG0BrPJiDk2YzjvMDDsesu/1yKqg6dwghb+i4Yl6wgvOBndvZP2R0DsPx+oGXdyh0NjZ EDIrEWHhJRYI9lafNcbMvdPXhuS7gRxg5XWC4YF3T27jH08fCxqH+ZllmZ9fiYm2/h3e NDsgQiMAIFKQF+WVNT4Wo+ZPBmAkoi6DifFrhaI40WPnXXJLehz6mbU+BUc95rW5ZwGq a8e+R+CZzHQIkYIwhZf5iw/bXtrTF3wAZQtDqCyWoHYtAKaP8LCvYgT0qKp9NfUkfJIu W+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712797866; x=1713402666; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=oixfyIUaOw/i7GTX8fFVfDIGnL63FVidyvB7Z/WPjiQ79f1qBhZX2GGd3hwYSfYnTp aFDZ3XRg0FIEtJzGPoKw4tHOXFrTmerm7D1zsXc3zD+tVZLmOhDOPAPhYwDcfVBm1JP1 l05EvblErVdwP0xZIXhO4JBjMU64rRn2i5DURMb6kTxChpPqlKcHhFdCZ407m4hsK0qR zk99RFMo/h8rICySkaUGdvR07BKJ0JRC/bL+kLGCBe4DNuZJkIbTSOXjCmsOG9N1gop5 mkMgNwE8v04Gge9pWWY/nvcMi7MXKB7DGzWASFgv8OYVNFxQAf+80u+FXWQtl8HbzG+a NiRA== X-Forwarded-Encrypted: i=1; AJvYcCVT+Ibj+wu6BqrLscYxXoHapIH8lP9ap+IyA1CZD5NkZR0N/1L8o9kXpl0wTcM8726vgroXHbd2mdhxiLw58E8VJHeGq7P8JprWCrTA X-Gm-Message-State: AOJu0Yz3pWZZW1TH7gjPwIv9enpyGfulyoEelQL5K9yM69B9xtU2Vkfh d7fyuttaiWHYkoxdJSBiXX6YePwTcadtZQw4gMEPXajoEtBfO6kWR1E+DtmzrPA= X-Google-Smtp-Source: AGHT+IFvdAWGolMk2tEZ8bM2BAlC1TsYZtb/fNUYXyTQY+hWEfuiEC430lr0paNhGs3so4u/3MehIA== X-Received: by 2002:a4a:e9f3:0:b0:5aa:6a28:27ea with SMTP id w19-20020a4ae9f3000000b005aa6a2827eamr3725829ooc.6.1712797866523; Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id db1-20020a056820270100b005a4bc907f0asm113158oob.15.2024.04.10.18.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Message-ID: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> Date: Wed, 10 Apr 2024 20:11:04 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4ogoe.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Thiago, On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: >> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>> >>> Unfortunately this patch causes build failures on arm with allyesconfig >>> and allmodconfig. Tested with next-20240410. > > > >> In both cases, the issue is that the toolchain requires runtime support to >> convert between `unsigned long long` and `double`, even when hardware FP is >> enabled. There was some past discussion about GCC inlining some of these >> conversions[1], but that did not get implemented. > > Thank you for the explanation and the bugzilla reference. I added a > comment there mentioning that the problem came up again with this patch > series. > >> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >> 32-bit arm until we can provide these runtime library functions. > > Does this mean that patch 2 in this series: > > [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT > > will be dropped? No, because later patches in the series (3, 6) depend on the definition of CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can find a GPL-2 compatible implementation of the runtime library functions. Regards, Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEB37CD11C2 for ; Thu, 11 Apr 2024 01:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xl8NnO8hTQq2TbwBhM+fKnwpZiqNx6SwQMqtQlqANlg=; b=KjwNhfofFaA0SR omMeMWqtztiSmaPuVHi6COROgZLJqAoBxHPM9S83OIXr5Sp5rcodOA/EQ6YluZJ3rq2jkAcmid7rf l9bqdAnQ4P3Hnoqgd9IFgnb8TDcj8dxR/oqGq0uchVPR2FCMfXfAqzAdGpkzXOk0k5IR5jDVYJxDr PBdyv7vVeZC3cmoH5zPL2bPAXh27C07I4o201daVdeLQ8gALoLM163Ot3dhKWpjwrKdkq1yKKJbED 6OisR5JyYhWQbG6wgqEZiKq/6QLF4GB/qbxzspCfb9tI2O9AULvjd9Q/kRvYeZRg54ojkydfWOpy2 WJKWVvMVVdXKXjlXZG9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruiy8-00000009mra-3Acr; Thu, 11 Apr 2024 01:11:12 +0000 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruiy6-00000009mqX-0Woj for linux-riscv@lists.infradead.org; Thu, 11 Apr 2024 01:11:11 +0000 Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-5a9c875ceecso4060511eaf.2 for ; Wed, 10 Apr 2024 18:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712797866; x=1713402666; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=dulEynRC5znoxF5D0nIzYbbmUHPTKkKUPV0zJkkVhez+0O6RvMTeDvGEbgNMpXti3N iVXIQWtE1qPSCh0HkV8lDcYWQ6EZH9pbzk9AI4T9KgF67JBpJlrnbfOWdg58lAauXA5s qnNY29Z/tpfiP/jzcjHcKFRLS9hV9Ei2nelwirs0w6p1B6hkhz6fkh+uF+NE9jpVcsmp jgsZ0Zu33lCqVwUEtjutGraSln8CexqcBET5xlgIpjyEHi/NdRz9IjppTle3/7W7UbE9 U7d4tu71NNUllcFscHrytYK3dpSkK1eBRsXMMv5FaVbZe7Xkd2hUxYS2Jgo++8h6/El4 uGVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712797866; x=1713402666; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=ETW9I7RNeUaPBaBpdCdnCKPtt2IoJWU/cBYZzoC2+Omxo4wp7d/85dSdaS0AnsiYTR YHqjlycqKNst4oQIz7gJtiZav0Vj4faj2viuoobEoSK25KC193bsGDzQbqlWHXadyjTA cYv1HJDjd3xf9fL5U9RdnW8I3bzjibkW0Ab4CfoaYav9oK/+a0+f7Hcu/Ro8An6S2KJB EGTU9sSNQ2BIcAhw5lsMpr+imETn/xFxhRAHyNVj5+DGdv/c5L29pnSozU5IcJP1zTxw BRHw2bZ4BrQstE4+wVxuMyzVsvVsSJlMXv99smdRAQ4Os4xEz/oWMGMr9ZbwQ+3UONYA dRaA== X-Forwarded-Encrypted: i=1; AJvYcCUB+2lwYLQcj+mQdolhQVBsD1YeWMd/K5syMRikr3hfXYYo2sFJs61llw0xbywn4qs5AvJ244bFBuR476DsBsCt8AN0G8kvDGHOmNkW9WiU X-Gm-Message-State: AOJu0YxZvOKv2DcgkTUDgmZFHPR9Kx/ybnUn0Ico/2dqqlY/3pBfV/0X Dwp7iVei0jVpMs/yodnM2mDbXaig2eALYZmE6zzabQe9FvkHr9FJRo4T49xysGM= X-Google-Smtp-Source: AGHT+IFvdAWGolMk2tEZ8bM2BAlC1TsYZtb/fNUYXyTQY+hWEfuiEC430lr0paNhGs3so4u/3MehIA== X-Received: by 2002:a4a:e9f3:0:b0:5aa:6a28:27ea with SMTP id w19-20020a4ae9f3000000b005aa6a2827eamr3725829ooc.6.1712797866523; Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id db1-20020a056820270100b005a4bc907f0asm113158oob.15.2024.04.10.18.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Message-ID: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> Date: Wed, 10 Apr 2024 20:11:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4ogoe.fsf@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_181110_179811_1CCCDD75 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Thiago, On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: >> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>> >>> Unfortunately this patch causes build failures on arm with allyesconfig >>> and allmodconfig. Tested with next-20240410. > > > >> In both cases, the issue is that the toolchain requires runtime support to >> convert between `unsigned long long` and `double`, even when hardware FP is >> enabled. There was some past discussion about GCC inlining some of these >> conversions[1], but that did not get implemented. > > Thank you for the explanation and the bugzilla reference. I added a > comment there mentioning that the problem came up again with this patch > series. > >> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >> 32-bit arm until we can provide these runtime library functions. > > Does this mean that patch 2 in this series: > > [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT > > will be dropped? No, because later patches in the series (3, 6) depend on the definition of CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can find a GPL-2 compatible implementation of the runtime library functions. Regards, Samuel _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CB5FCD11C2 for ; Thu, 11 Apr 2024 01:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5B5t6n2AcNgzteqtvJzyH+qdgsejqDLOWvus2n+WwpA=; b=QFu6HtZVQa6Maq 90RuqxYQ8Ku68OCJMAWhboLh61Rolb7DofEiMZX96zKGdBu8lnB/5Abwj6lKRTroAlTnPvFbN9B5e K0BuzSFLsrD+f1p4cQvOIs7WVKQD5ChTgvKGPchzET6dyALkQMCbtZu+wRoLSZFwjIYzTbG07Kste /1he5b5T3k9GiWYShy210NeSCEFLt2v3kq7u2ZU1fN/49UMbAYDtbSVO7E4Nsw649yUqjlR0uW9AF JRjbpklkyjuVA5YU0lWQBmefqW0L7eBS6i0DlnWKyyKt7UwVfTxyPfxa8BCH5buLI2ModX5rai74F NIt9XgkOt26kOPQJpyMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruiy7-00000009mrK-3eJo; Thu, 11 Apr 2024 01:11:11 +0000 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruiy4-00000009mqQ-2BwI for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2024 01:11:10 +0000 Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-5a4f7a648dbso4024624eaf.3 for ; Wed, 10 Apr 2024 18:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712797866; x=1713402666; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=dulEynRC5znoxF5D0nIzYbbmUHPTKkKUPV0zJkkVhez+0O6RvMTeDvGEbgNMpXti3N iVXIQWtE1qPSCh0HkV8lDcYWQ6EZH9pbzk9AI4T9KgF67JBpJlrnbfOWdg58lAauXA5s qnNY29Z/tpfiP/jzcjHcKFRLS9hV9Ei2nelwirs0w6p1B6hkhz6fkh+uF+NE9jpVcsmp jgsZ0Zu33lCqVwUEtjutGraSln8CexqcBET5xlgIpjyEHi/NdRz9IjppTle3/7W7UbE9 U7d4tu71NNUllcFscHrytYK3dpSkK1eBRsXMMv5FaVbZe7Xkd2hUxYS2Jgo++8h6/El4 uGVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712797866; x=1713402666; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=nZFyKlUYzO/2Ee68OnQsgbkUleXIwuyO9uTywD+0tLYkgFG7xpA7Y3+MmvLQpapt+6 SKMYIsR8AHChisJYAIieH2qn/uQ6ULeJSBVQTCA2E3APlxJxlnRRyDQKr0lDy8J5i9oF vmGttinOuUQblLgmtbjs8DaXbiBrkp+3cAPFJvXFPlSX3jFl14fsuEXpA8IUFFzL7Gn4 Ee3GBkxEicMpzAFTJgWJvlvAPzESY4qkC4fjfYFiUQFp7vt17rxyY1hFA2rdfEGAu/Ne q5Kxv90M82Y5MfOXYve4q8RYahohQb2Ji8n69ryMDAULTD6aJl+6zu5oTkuvkiDUbYHR 8u+w== X-Forwarded-Encrypted: i=1; AJvYcCWv+E2MKqqGf57v35PTnj5HLx+KDsDx9ScPuotIXKrLxdVtKLa67uGf28snVlxFHnOuSjK1ZCy+uW3Deu/1ZZHU3kMOelJBBv5ufn4FYSBHTzMCxZo= X-Gm-Message-State: AOJu0YyHMrFKo7ozJYmZxO0oAzpzBmf88xmnAEQ/vkE6k1ZoCymgvdOJ yEcsSGxVOxEB4g9sB82pkOUWHyQNqT/08xpD7Uvcga6pXew8ntZGj0QPOKqoIF0q79UWCw6yFoF T X-Google-Smtp-Source: AGHT+IFvdAWGolMk2tEZ8bM2BAlC1TsYZtb/fNUYXyTQY+hWEfuiEC430lr0paNhGs3so4u/3MehIA== X-Received: by 2002:a4a:e9f3:0:b0:5aa:6a28:27ea with SMTP id w19-20020a4ae9f3000000b005aa6a2827eamr3725829ooc.6.1712797866523; Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id db1-20020a056820270100b005a4bc907f0asm113158oob.15.2024.04.10.18.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Message-ID: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> Date: Wed, 10 Apr 2024 20:11:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4ogoe.fsf@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_181108_895975_383FBA8C X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Thiago, On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: >> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>> >>> Unfortunately this patch causes build failures on arm with allyesconfig >>> and allmodconfig. Tested with next-20240410. > > > >> In both cases, the issue is that the toolchain requires runtime support to >> convert between `unsigned long long` and `double`, even when hardware FP is >> enabled. There was some past discussion about GCC inlining some of these >> conversions[1], but that did not get implemented. > > Thank you for the explanation and the bugzilla reference. I added a > comment there mentioning that the problem came up again with this patch > series. > >> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >> 32-bit arm until we can provide these runtime library functions. > > Does this mean that patch 2 in this series: > > [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT > > will be dropped? No, because later patches in the series (3, 6) depend on the definition of CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can find a GPL-2 compatible implementation of the runtime library functions. Regards, Samuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62817CD11C2 for ; Thu, 11 Apr 2024 01:11:57 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=fRzeCsRT; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VFM9R735fz3vbL for ; Thu, 11 Apr 2024 11:11:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=fRzeCsRT; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sifive.com (client-ip=2607:f8b0:4864:20::c31; helo=mail-oo1-xc31.google.com; envelope-from=samuel.holland@sifive.com; receiver=lists.ozlabs.org) Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VFM8c3lvXz3cRB for ; Thu, 11 Apr 2024 11:11:10 +1000 (AEST) Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-5aa1bf6cb40so2410744eaf.1 for ; Wed, 10 Apr 2024 18:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1712797866; x=1713402666; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=fRzeCsRTjGzwoYBcGpzq00SB6L8L2qnFIIefycg7NSRWkZFt4gSQjgclMkhu36i0R3 zxLebed7YuZFqWIzE6kdEIPYWM2K4sOJuXOD4f3IlB9eiU36RJOJVR1Prb9+EhyHyjfV MVyRVJl1Y31abS26yz+CM1v7PE3ZTn8SuPiEZvCTx18wXBAUwCenBeuxAaFhHEPKR/YV Ztjw3dLKhwGmeJ4m+LRdnrNms+h54gHy8Nzzap7lhR/SQHthim4AHDHDJmvrBQ41im1D t7YMdmM0izqfjf08hGejEIQLxrILffeRf2ItiuhcjlQOdhSvxe2U2m0F3P1eFhvw2V30 gwJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712797866; x=1713402666; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K7z1/Srv4eZ2vooDSDvwwBej5oDKDz5itKY0SDj8VoQ=; b=Gy7KRxHcURMMmfiHAQCD5D6h6mOtuPkLep8NscM9fkcUWi0xm5QVoP6rgbn6h5jUSm 7C1arMMe59OAMdSrgsH1OSeb9jmkPIpUBw67GOVYmsHRRsj09YyoSz7rNTwWB8luCYls G0AA3N1sjrHRK9JlYbz/tSXlkFv30tywg6OKrtReBUkCgug8zwoOxrJfi82KZZGdKy2t /BEa/EVamujogRVGzLkQZ0wbW9ofTFQfGYZ5piNdNbrfZvymIz3u38j0w/fztPUPJ8Xp MgIZhCstT0PUwosBKe9IRVVM8/oFnhV7aWSfw1zOVkDlLyyezmfpvnxKZeJXTq8FiLCt zKxA== X-Forwarded-Encrypted: i=1; AJvYcCUbe6ZiGVXs5LYDd0nqqnhUgpSM7UCF34q9QBCUKz29f50HPJ11RmwHzzJNCKNBO086ibuPttuqX/pXXc4nM6RfF3DzpBQFqMIsoz4ykg== X-Gm-Message-State: AOJu0YyLVPQloeTPFGlrmIXUmeESjebFJzsOEASquxB3gT26Fgjn9fXw kHiLEwZLeiTa8RQ1uMxZGAnLtMpePPsgd4IMrRKJUX0huGPkEtmmRyBX+ed5nk0= X-Google-Smtp-Source: AGHT+IFvdAWGolMk2tEZ8bM2BAlC1TsYZtb/fNUYXyTQY+hWEfuiEC430lr0paNhGs3so4u/3MehIA== X-Received: by 2002:a4a:e9f3:0:b0:5aa:6a28:27ea with SMTP id w19-20020a4ae9f3000000b005aa6a2827eamr3725829ooc.6.1712797866523; Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Received: from [100.64.0.1] ([170.85.8.167]) by smtp.gmail.com with ESMTPSA id db1-20020a056820270100b005a4bc907f0asm113158oob.15.2024.04.10.18.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 18:11:06 -0700 (PDT) Message-ID: <4c8e63d6-ba33-47fe-8150-59eba8babf2d@sifive.com> Date: Wed, 10 Apr 2024 20:11:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Thiago Jung Bauermann References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> <87wmp4oo3y.fsf@linaro.org> <75a37a4b-f516-40a3-b6b5-4aa1636f9b60@sifive.com> <87wmp4ogoe.fsf@linaro.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <87wmp4ogoe.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , loongarch@lists.linux.dev, Alex Deucher , Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Thiago, On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: >> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>> >>> Unfortunately this patch causes build failures on arm with allyesconfig >>> and allmodconfig. Tested with next-20240410. > > > >> In both cases, the issue is that the toolchain requires runtime support to >> convert between `unsigned long long` and `double`, even when hardware FP is >> enabled. There was some past discussion about GCC inlining some of these >> conversions[1], but that did not get implemented. > > Thank you for the explanation and the bugzilla reference. I added a > comment there mentioning that the problem came up again with this patch > series. > >> The short-term fix would be to drop the `select ARCH_HAS_KERNEL_FPU_SUPPORT` for >> 32-bit arm until we can provide these runtime library functions. > > Does this mean that patch 2 in this series: > > [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT > > will be dropped? No, because later patches in the series (3, 6) depend on the definition of CC_FLAGS_FPU from that patch. I will need to send a fixup patch unless I can find a GPL-2 compatible implementation of the runtime library functions. Regards, Samuel