* [PATCH] ctype.c: Fix a sparse warning
@ 2012-03-04 19:10 Ramsay Jones
0 siblings, 0 replies; only message in thread
From: Ramsay Jones @ 2012-03-04 19:10 UTC (permalink / raw
To: Junio C Hamano; +Cc: GIT Mailing-list
In particular, sparse complains as follows:
SP ctype.c
ctype.c:30:12: warning: symbol 'tolower_trans_tbl' was not declared.\
Should it be static?
An appropriate extern declaration for the 'tolower_trans_tbl' symbol
is included in the "cache.h" header file. In order to suppress the
warning, therefore, we could replace the "git-compat-util.h" header
inclusion with "cache.h", since "cache.h" includes "git-compat-util.h"
in turn. Here, however, we choose to move the extern declaration for
'tolower_trans_tbl' into "git-compat-util.h", alongside the other
extern declaration from ctype.c for 'sane_ctype'.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Junio,
Could you please squash this, or something like it, into
commit 0f871cf5 ("grep: use static trans-case table",28-02-2012).
Thanks!
ATB,
Ramsay Jones
cache.h | 3 ---
git-compat-util.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/cache.h b/cache.h
index 9765b87..9d7bf3d 100644
--- a/cache.h
+++ b/cache.h
@@ -1285,7 +1285,4 @@ extern struct startup_info *startup_info;
/* builtin/merge.c */
int checkout_fast_forward(const unsigned char *from, const unsigned char *to);
-/* in ctype.c, for kwset users */
-extern const char tolower_trans_tbl[256];
-
#endif /* CACHE_H */
diff --git a/git-compat-util.h b/git-compat-util.h
index 426ae43..ed11ad8 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -457,6 +457,9 @@ static inline int has_extension(const char *filename, const char *ext)
return len > extlen && !memcmp(filename + len - extlen, ext, extlen);
}
+/* in ctype.c, for kwset users */
+extern const char tolower_trans_tbl[256];
+
/* Sane ctype - no locale, and works with signed chars */
#undef isascii
#undef isspace
--
1.7.9
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-03-04 19:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-04 19:10 [PATCH] ctype.c: Fix a sparse warning Ramsay Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.