From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 16 Apr 2011 14:55:20 +0200 Subject: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch In-Reply-To: References: <1302850978-2954-1-git-send-email-macpaul@andestech.com> <201104150400.36877.vapier@gentoo.org> <201104150453.21441.vapier@gentoo.org> <20110415100912.1A7B41537B0@gemini.denx.de> <4DA935B9.6070807@aribaud.net> <4DA9401A.2010600@gmail.com> Message-ID: <4DA991B8.1000105@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Macpaul Lin, Le 16/04/2011 13:17, Macpaul Lin a ?crit : > Hi all, > > 2011/4/16 Graeme Russ: >> On 16/04/11 16:22, Albert ARIBAUD wrote: >>> >>> If the goal is to have the !defined aligned, then maybe a solution here >>> would be toput a tab rather than a space after the #if? >>> > > Do you guys means > #if"\t"defined (XXXXXX) || > "\t"defined (XXXXXX) > instead of > #if defined (XXXXXX) || > "space*4" defined (XXXXXX) > ? Yes, this is what I mean. > If so, I'll fix the patch and then send v2 on next Monday and see if > everybody feel this will be better. Amicalement, -- Albert.