* Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0
[not found] ` <23C4EECD-622A-412A-B965-8E586D9360B2@sonic.net>
@ 2024-02-13 9:37 ` Oliver Hartkopp
2024-02-15 0:03 ` Guy Harris
0 siblings, 1 reply; 5+ messages in thread
From: Oliver Hartkopp @ 2024-02-13 9:37 UTC (permalink / raw
To: Guy Harris; +Cc: Developer support list for Wireshark, linux-can
Hello Guy,
On 2024-02-13 01:28, Guy Harris wrote:
> On Feb 12, 2024, at 1:15 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>
>> Excellent! That seems to be the right approach.
>
> OK, so:
>
> fix libpcap to put the priority/VCID field in big-endian order in CAN XL frames:
>
> https://github.com/the-tcpdump-group/libpcap/commit/eb6cfd8feae85b67529bb3c82f6a97bfd98c73f3 in the main branch
>
> https://github.com/the-tcpdump-group/libpcap/commit/23904ebe85c4556b77578fd8d61ef82d9bab62b4 in the 1.10 branch
>
> change Wireshark to treat that field as big-endian:
>
> https://gitlab.com/wireshark/wireshark/-/commit/38a29e82cc96f727aeab7f10e751fa6e8d5e45b6 in the main branch
>
> https://gitlab.com/wireshark/wireshark/-/commit/b763663904b6101764c414056b9248803569d6d2 in the 4.2 branch
>
> update the LINKTYPE_CAN_SOCKETCAN spec to reflect all that:
>
> https://github.com/the-tcpdump-group/tcpdump-htdocs/commit/9c357d9ed6d214bd2fc44850138c2f8861782d88
>
> and it'll show up on the site within 24 hours.
>
I can confirm that all type of CAN frames (CAN CC/FD/XL) are now
displayed correctly with the latest Wireshark
v4.3.0rc0-1528-g37937ef51444. As expected I just don't see the CAN FD
flags due to my current (outdated) Debian libpcap 1.10.4.
Great job!!
Many thanks and best regards,
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0
2024-02-13 9:37 ` [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0 Oliver Hartkopp
@ 2024-02-15 0:03 ` Guy Harris
2024-02-15 8:01 ` Oliver Hartkopp
0 siblings, 1 reply; 5+ messages in thread
From: Guy Harris @ 2024-02-15 0:03 UTC (permalink / raw
To: Oliver Hartkopp; +Cc: Developer support list for Wireshark, linux-can
Wireshark 4.2.3, which includes the SocketCAN changes, has just been released. Presumably, various packagers of Wireshark 4.2.x will pick it up at some point.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0
2024-02-15 0:03 ` Guy Harris
@ 2024-02-15 8:01 ` Oliver Hartkopp
2024-02-15 10:43 ` Guy Harris
0 siblings, 1 reply; 5+ messages in thread
From: Oliver Hartkopp @ 2024-02-15 8:01 UTC (permalink / raw
To: Guy Harris; +Cc: Developer support list for Wireshark, linux-can
On 2024-02-15 01:03, Guy Harris wrote:
> Wireshark 4.2.3, which includes the SocketCAN changes, has just been released. Presumably, various packagers of Wireshark 4.2.x will pick it up at some point.
Many thanks for the information and your support!
Marc created a pull-request for Linux mainline upstream (net-next) and
the CAN XL VCID support will now show up in Linux 6.9:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=c83c22ec1493c0b7cc77327bedbd387e295872b6
Looking forward to see both improvements in the known distributions.
Best regards,
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0
2024-02-15 8:01 ` Oliver Hartkopp
@ 2024-02-15 10:43 ` Guy Harris
2024-02-15 12:20 ` Oliver Hartkopp
0 siblings, 1 reply; 5+ messages in thread
From: Guy Harris @ 2024-02-15 10:43 UTC (permalink / raw
To: Oliver Hartkopp; +Cc: Developer support list for Wireshark, linux-can
On Feb 15, 2024, at 12:01 AM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
> Marc created a pull-request for Linux mainline upstream (net-next) and the CAN XL VCID support will now show up in Linux 6.9:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=c83c22ec1493c0b7cc77327bedbd387e295872b6
How does one request that the VCID information be provided on a PF_PACKET socket (whether SOCK_RAW or SOCK_DGRAM)?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0
2024-02-15 10:43 ` Guy Harris
@ 2024-02-15 12:20 ` Oliver Hartkopp
0 siblings, 0 replies; 5+ messages in thread
From: Oliver Hartkopp @ 2024-02-15 12:20 UTC (permalink / raw
To: Guy Harris; +Cc: Developer support list for Wireshark, linux-can
On 15.02.24 11:43, Guy Harris wrote:
> On Feb 15, 2024, at 12:01 AM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=c83c22ec1493c0b7cc77327bedbd387e295872b6
>
> How does one request that the VCID information be provided on a PF_PACKET socket (whether SOCK_RAW or SOCK_DGRAM)?
>
The VCID is now part of the content in the struct skbuff data. So it is
available everywhere, where a formerly CAN ID was accessible. Also on
PACKET sockets.
The VCID is no VLAN tag, nor uses it the VLAN specific skbuff elements
in Linux.
While it would have been possible to get a VLAN tag via PACKET sockets
auxiliary cmsg mechanic you would never have be able to "write" the VCID
in this way as user space application - and especially not as
unprivileged user. And this is a vital requirement for logging and
replaying CAN (CC/FD/XL) traffic.
The question if we could invent some VLAN-like CAN interface (can0.123)
is to be discussed. But there would be the need of a use-case of real
CAN XL users. So far there is nothing to see.
As CAN XL has up to 2048 bytes of payload it is also possible to do
IP-over-CANXL. IMHO it would make sense to create a software ethernet
device (maybe with VLAN tag) that interacts with a CAN XL network
interface. But this is future work, again when there will be a use-case.
Best regards,
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-15 12:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2dfbf765-5a0e-4b72-bbbb-2649bba7afd8@hartkopp.net>
[not found] ` <B237C266-B7A1-4F5A-85FA-F41FBC71D839@sonic.net>
[not found] ` <DDFFD43D-2CC3-482A-AFC0-B0EEDE5B7081@sonic.net>
[not found] ` <9C5FF793-DD38-4738-9421-C8C411E405D2@sonic.net>
[not found] ` <525f7e66-1b8a-4401-b6a5-c55462f12f4a@hartkopp.net>
[not found] ` <2CB7E192-7F5B-4651-B0B1-9C3788489B8C@sonic.net>
[not found] ` <550c630a-4fba-430e-a0b6-bacce3776f2f@hartkopp.net>
[not found] ` <B9FE825B-F804-4D09-BE01-1D5592D1077D@sonic.net>
[not found] ` <48514D53-9257-4613-9F10-09086D93C2A3@sonic.net>
[not found] ` <68889df4-1ac5-45c0-8820-737cbcc30c56@hartkopp.net>
[not found] ` <40ADC6AD-C4C3-4954-B58C-FCD227474C16@sonic.net>
[not found] ` <48b90be5-7dc8-46f5-a2fb-bc9b310da410@hartkopp.net>
[not found] ` <5D9B69B1-A6D2-429B-8862-5CB60415D7C0@sonic.net>
[not found] ` <aa3671e7-83ed-45ed-a843-d9ed238519c6@hartkopp.net>
[not found] ` <23C4EECD-622A-412A-B965-8E586D9360B2@sonic.net>
2024-02-13 9:37 ` [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-1430-g600de02805d0 Oliver Hartkopp
2024-02-15 0:03 ` Guy Harris
2024-02-15 8:01 ` Oliver Hartkopp
2024-02-15 10:43 ` Guy Harris
2024-02-15 12:20 ` Oliver Hartkopp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.