From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Aaron Mason <absorbentshoulderman@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images
Date: Wed, 27 May 2009 03:23:48 -0500 [thread overview]
Message-ID: <4A1CF894.5010200@codemonkey.ws> (raw)
In-Reply-To: <4A1CEBCC.5000307@redhat.com>
Kevin Wolf wrote:
> Anthony Liguori schrieb:
>
>> Kevin Wolf wrote:
>>
>>> Anthony Liguori schrieb:
>>>
>>>
>>>> Aaron Mason wrote:
>>>>
>>>>
>>>>> Who said the images had to be used for QEMU? As I said, I use the
>>>>> utility primarily for creating VMware images.
>>>>>
>>>>>
>>>> If it's not useful for QEMU, then I don't see that it's worth
>>>> maintaining within QEMU.
>>>>
>>>>
>>> Then I wonder why we have the compat6 option for VMDK. I would be rather
>>> surprised if it was useful for qemu itself.
>>>
>>>
>> Yup. I don't like the compat6 patch either as it's pretty invasive.
>>
>
> Hm, we're both talking about ec36ba1? Because I can't see how it is
> invasing, with the exception of the changes to qemu-img. But we don't
> need these any more, we have -o now.
>
I find it invasive because it extends the block subsytem API with a
non-generic interface.
>> Introducing BLOCK_FLAG_BUSLOGIC and BLOCK_FLAG_LSILOGIC seems very wrong
>> to me. You're happy with it?
>>
>
> No, I'm not happy with this particular patch, especially given that it
> doesn't apply to master any more. ;-)
>
> You said this was "not useful", so I'm just talking of the
> functionality, independent of the code. And code-wise, it really should
> be only a few lines to vmdk - which makes the create function longer by
> maybe five lines, but hardly more complex.
>
I wouldn't mind a few line patch to vmdk's create function.
Regards,
Anthony Liguori
> Kevin
>
next prev parent reply other threads:[~2009-05-27 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 10:29 [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images Aaron Mason
2009-05-22 16:41 ` Anthony Liguori
[not found] ` <e869674d0905240116n3245c5bdxf66552984a4037f5@mail.gmail.com>
2009-05-26 8:02 ` Anthony Liguori
2009-05-26 9:09 ` Kevin Wolf
2009-05-26 19:52 ` Anthony Liguori
2009-05-26 19:58 ` Daniel P. Berrange
2009-05-26 20:01 ` Anthony Liguori
2009-05-27 7:29 ` Kevin Wolf
2009-05-27 7:40 ` Christoph Hellwig
2009-05-27 8:23 ` Anthony Liguori [this message]
2009-05-26 18:17 ` Robert Riebisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1CF894.5010200@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=absorbentshoulderman@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.