From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M92qZ-0005SF-KS for qemu-devel@nongnu.org; Tue, 26 May 2009 16:02:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M92qV-0005Ri-4r for qemu-devel@nongnu.org; Tue, 26 May 2009 16:02:03 -0400 Received: from [199.232.76.173] (port=53090 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M92qV-0005Rf-2t for qemu-devel@nongnu.org; Tue, 26 May 2009 16:01:59 -0400 Received: from rv-out-0708.google.com ([209.85.198.242]:24743) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M92qU-0007b2-IY for qemu-devel@nongnu.org; Tue, 26 May 2009 16:01:58 -0400 Received: by rv-out-0708.google.com with SMTP id c5so1382739rvf.22 for ; Tue, 26 May 2009 13:01:57 -0700 (PDT) Message-ID: <4A1C4AA9.6000002@codemonkey.ws> Date: Tue, 26 May 2009 15:01:45 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images References: <4A16D5B8.50508@codemonkey.ws> <4A1BA22D.4040008@codemonkey.ws> <4A1BB1DE.3080600@redhat.com> <4A1C487B.90908@codemonkey.ws> <20090526195819.GD13938@redhat.com> In-Reply-To: <20090526195819.GD13938@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Kevin Wolf , Aaron Mason , "qemu-devel@nongnu.org" Daniel P. Berrange wrote: > On Tue, May 26, 2009 at 02:52:27PM -0500, Anthony Liguori wrote: > >> Kevin Wolf wrote: >> >> >>> FWIW, I know that SUSE had a use for these SCSI VMDKs and they carry a >>> local patch for it. I would prefer to have such things upstream, even if >>> it's just for exporting. After all, qemu-img is the Swiss army knife for >>> images. >>> >>> >> If there's support for it, we can take it. I worry about adding >> features that aren't widely useful as they add complexity and make it >> hard to refactor things. >> >> Introducing BLOCK_FLAG_BUSLOGIC and BLOCK_FLAG_LSILOGIC seems very wrong >> to me. You're happy with it? >> > > I think the addition of new VMDK specific flags to qemu-img is pretty > wrong too > > - " create [-e] [-6] [-b base_image] [-f fmt] filename [size]\n" > + " create [-e] [-6] [-S] [-L] [-b base_image] [-f fmt] filename > .... > + " '-S' indicates that the target image must be a BusLogic SCSI > virtual disk (vmdk format only)\n" > + " '-L' indicates that the target image must be a LSI Logic SCSI > virtual disk (vmdk format only)\n" > > > If we want to expose this capability, then I think we should have some > kind of generic 'feature' string that can be passed through to the specific > block driver, without needing an unbounded number of qemu-img args to be > added. eg. > > qemu-img create -o target=buslogic foo.vmdk > qemu-img create -o target=lsilogic foo.vmdk > > And just pass the whole value from '-o' through to the block layer's > create method. > You can have the configs be external to vmdk's too, right? Could we just make configs external to the sparse images so that people could edit them however they wanted? Regards, Anthony Liguori > Daniel >