All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] via-velocity: fix hot spin
@ 2009-01-17 21:14 Roel Kluin
  2009-01-18  7:07 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-01-17 21:14 UTC (permalink / raw
  To: romieu; +Cc: netdev

while(--j >= 0) keeps spinning when j is unsigned:

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index a75f91d..c5691fd 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -1302,7 +1302,7 @@ static void velocity_free_rd_ring(struct velocity_info *vptr)
 static int velocity_init_td_ring(struct velocity_info *vptr)
 {
 	dma_addr_t curr;
-	unsigned int j;
+	int j;
 
 	/* Init the TD ring entries */
 	for (j = 0; j < vptr->tx.numq; j++) {


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] via-velocity: fix hot spin
  2009-01-17 21:14 [PATCH] via-velocity: fix hot spin Roel Kluin
@ 2009-01-18  7:07 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-18  7:07 UTC (permalink / raw
  To: roel.kluin; +Cc: romieu, netdev

From: Roel Kluin <roel.kluin@gmail.com>
Date: Sat, 17 Jan 2009 22:14:31 +0100

> while(--j >= 0) keeps spinning when j is unsigned:
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Applied, thanks Roel.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-18  7:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-17 21:14 [PATCH] via-velocity: fix hot spin Roel Kluin
2009-01-18  7:07 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.