* [Fwd: [PATCH]aic7xxx: Take the LED out of diagnostic mode on PM resume, too.]
@ 2008-10-08 11:21 thomas schorpp
2008-10-15 14:23 ` Hannes Reinecke
0 siblings, 1 reply; 2+ messages in thread
From: thomas schorpp @ 2008-10-08 11:21 UTC (permalink / raw
To: James.Bottomley; +Cc: Linux SCSI list
[-- Attachment #1: Type: text/plain, Size: 74 bytes --]
NACK? malformed patches? do You want it against scsi-git? or what?
y
tom
[-- Attachment #2: [PATCH]aic7xxx: Take the LED out of diagnostic mode on PM resume, too..eml --]
[-- Type: message/rfc822, Size: 1841 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 353 bytes --]
Take the Diag/Activity-LED of the HBA out of diagnostic mode on PM resume after successful PM resume from standby and HBA restart,
it remained always on before. If something fails before complete recovery, it should remain on, since it is a diagnostics LED,
reason for the used higher layer for the clear.
Signed-off-by: thomas.schorpp@gmail.com
[-- Attachment #2.1.2: aic7xxx_PM_fixled.patch --]
[-- Type: text/x-diff, Size: 542 bytes --]
--- drivers/scsi/aic7xxx/aic7xxx_core.c 2008-10-03 13:53:39.000000000 +0200
+++ drivers/scsi/aic7xxx/aic7xxx_core.c 2008-10-03 14:26:04.000000000 +0200
@@ -814,6 +814,7 @@
static void
ahc_restart(struct ahc_softc *ahc)
{
+ uint8_t sblkctl;
ahc_pause(ahc);
@@ -868,6 +869,12 @@
ahc_outb(ahc, SEQADDR0, 0);
ahc_outb(ahc, SEQADDR1, 0);
+ /*
+ * Take the LED out of diagnostic mode on PM resume, too
+ */
+ sblkctl = ahc_inb(ahc, SBLKCTL);
+ ahc_outb(ahc, SBLKCTL, (sblkctl & ~(DIAGLEDEN|DIAGLEDON)));
+
ahc_unpause(ahc);
}
[-- Attachment #3: Nachricht als Attachment --]
[-- Type: message/rfc822, Size: 3303 bytes --]
From: thomas schorpp <t.schorpp@gmx.de>
To: SCSI development list <linux-scsi@vger.kernel.org>
Subject: [PATCH][DOC]aic7xxx: Correct wrong Kernel Documentation for Adaptec AHA19160(B) HBA
Date: Fri, 23 Mar 2007 17:45:52 +0100
Message-ID: <46040440.1020704@gmx.de>
--- Documentation/scsi/aic7xxx.txt 2007-03-23 16:44:05.000000000 +0100
+++ Documentation/scsi/aic7xxx.txt 2007-03-23 17:01:19.000000000 +0100
@@ -28,7 +28,7 @@
aic7880 10 PCI/32 20MHz 16Bit 16
aic7890 20 PCI/32 40MHz 16Bit 16 3 4 5 6 7 8
aic7891 20 PCI/64 40MHz 16Bit 16 3 4 5 6 7 8
- aic7892 20 PCI/64-66 80MHz 16Bit 16 3 4 5 6 7 8
+ aic7892 20 PCI/32/64-66 80MHz 16Bit 16 3 4 5 6 7 8
aic7895 15 PCI/32 20MHz 16Bit 16 2 3 4 5
aic7895C 15 PCI/32 20MHz 16Bit 16 2 3 4 5 8
aic7896 20 PCI/32 40MHz 16Bit 16 2 3 4 5 6 7 8
@@ -114,7 +114,7 @@
AHA-29160N aic7892 PCI/32 LVD-HD68F SE-HD50F
SE-50M
AHA-29160LP aic7892 PCI/64-66
- AHA-19160 aic7892 PCI/64-66
+ AHA-19160 aic7892 PCI/32
AHA-29150LP aic7892 PCI/64-66
AHA-29130LP aic7892 PCI/64-66
AHA-3960D aic7899 PCI/64-66 2 X LVD-HD68F 2 X LVD-VHD68F
Correct documentation according to the aic7892 chip, adaptec aha19160 hba specs.
Signed-off-by tom schorpp <t.schorpp@gmx.de>
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Fwd: [PATCH]aic7xxx: Take the LED out of diagnostic mode on PM resume, too.]
2008-10-08 11:21 [Fwd: [PATCH]aic7xxx: Take the LED out of diagnostic mode on PM resume, too.] thomas schorpp
@ 2008-10-15 14:23 ` Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2008-10-15 14:23 UTC (permalink / raw
To: thomas.schorpp; +Cc: James.Bottomley, Linux SCSI list
Hi Thomas,
thomas schorpp wrote:
> NACK? malformed patches? do You want it against scsi-git? or what?
>
-ENOTIME :-(
But now:
Acked-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-15 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-08 11:21 [Fwd: [PATCH]aic7xxx: Take the LED out of diagnostic mode on PM resume, too.] thomas schorpp
2008-10-15 14:23 ` Hannes Reinecke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.