From: Eric Miao <eric.y.miao@gmail.com>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: linux-fbdev-devel@lists.sourceforge.net, ymiao3@marvell.com,
Jaya Kumar <jayakumar.lkml@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [RFC 2.6.26-rc3 1/7] pxafb: module unloading support
Date: Thu, 12 Jun 2008 18:20:02 +0800 [thread overview]
Message-ID: <4850F852.40501@gmail.com> (raw)
In-Reply-To: <20080612072534.adc46a9e.krzysztof.h1@poczta.fm>
Krzysztof Helt wrote:
> On Wed, 11 Jun 2008 21:36:04 -0700
> "Jaya Kumar" <jayakumar.lkml@gmail.com> wrote:
>
>> On Tue, Jun 10, 2008 at 12:44 AM, Eric Miao <eric.y.miao@gmail.com> wrote:
>>> Lothar Waßmann wrote:
>>>> Jaya Kumar wrote:
>>>>> @@ -1587,7 +1587,7 @@ static int __init pxafb_parse_options(struct device *dev, char *options)
>>>>> static char g_options[256] __devinitdata = "";
>>>>>
>>>>> #ifndef CONFIG_MODULES
>>>> ^^^^^^^^^^^^^^
>>>>> -static int __devinit pxafb_setup_options(void)
>>>>> +static int __init pxafb_setup_options(void)
>>>>>
>>>> That should be '#ifndef MODULE'.
>>>> Otherwise support for cmdline options for the built-in driver will
>>>> only be enabled if the kernel is compiled without module support.
>>>>
>>> Yes, indeed. It requires another fix patch for this.
>>>
>> Hi Eric, Lothar,
>>
>> That CONFIG_MODULES is from the pxafb code. It is not part of the
>> changes that I made to pxafb.
>>
>
> I support Jaya position on this. The offending line is not part of his
> patch. I think that this set of patches can be accepted with additional
> patch which corrects existing pxafb problems (not related to his changes).
> He may even post this patch before his set if this is required this way.
>
OK, I see. I'm not proposing a quick fix patch for the moment.
I still feel a bit upset to this set of patches, and I need more time
to review, thanks.
> Regards,
> Krzysztof
>
>
> ----------------------------------------------------------------------
> Podbij Dziki Zachod!Gra strategiczna online
> Sprawdz >>> http://link.interia.pl/f1dff
>
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
next prev parent reply other threads:[~2008-06-12 10:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 4:49 [RFC 2.6.26-rc3 0/7] am200epd, pxafb, metronomefb changes v3 Jaya Kumar
2008-06-07 4:49 ` [RFC 2.6.26-rc3 1/7] pxafb: module unloading support Jaya Kumar
2008-06-07 8:35 ` Krzysztof Helt
2008-06-10 6:25 ` Eric Miao
2008-06-10 6:43 ` Lothar Waßmann
2008-06-10 7:44 ` Eric Miao
2008-06-12 4:36 ` Jaya Kumar
2008-06-12 5:25 ` Krzysztof Helt
2008-06-12 10:20 ` Eric Miao [this message]
2008-06-12 14:17 ` Jaya Kumar
2008-06-07 4:49 ` [RFC 2.6.26-rc3 2/7] pxafb: add shared framebuffer interface Jaya Kumar
2008-06-07 8:38 ` Krzysztof Helt
2008-06-07 4:49 ` [RFC 2.6.26-rc3 3/7] gumstix: conversion to MFP support and add bluetooth support Jaya Kumar
2008-06-07 4:49 ` [RFC 2.6.26-rc3 4/7] am200epd: move am200epd to mach-pxa Jaya Kumar
2008-06-07 8:40 ` Krzysztof Helt
2008-06-07 4:49 ` [RFC 2.6.26-rc3 5/7] am200epd: convert to shared fb and use gpio api Jaya Kumar
2008-06-07 8:43 ` Krzysztof Helt
2008-06-07 4:49 ` [RFC 2.6.26-rc3 6/7] metronomefb: convert printk to dev_dbg/err messages Jaya Kumar
2008-06-07 8:46 ` Krzysztof Helt
2008-06-07 4:49 ` [RFC 2.6.26-rc3 7/7] metronomefb: changes to use separate framebuffer Jaya Kumar
2008-06-07 8:59 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4850F852.40501@gmail.com \
--to=eric.y.miao@gmail.com \
--cc=jayakumar.lkml@gmail.com \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=ymiao3@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.