* ip6tables broken
@ 2008-04-15 13:23 Patrick McHardy
2008-04-15 13:41 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2008-04-15 13:23 UTC (permalink / raw
To: Jan Engelhardt; +Cc: Netfilter Development Mailinglist
Using the net-2.6.26.git/latest SVN tree I get:
[96565.511804] ip6_tables: MARK target: invalid size 4 != 8
[96565.536937] ip6_tables: MARK target: invalid size 4 != 8
[96565.570762] ip6_tables: MARK target: invalid size 4 != 8
Userspace chooses revision 2, the kernel apparently revision 0.
I'm pretty certain this is some fallout from your latest patches.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ip6tables broken
2008-04-15 13:23 ip6tables broken Patrick McHardy
@ 2008-04-15 13:41 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-04-15 13:41 UTC (permalink / raw
To: Jan Engelhardt; +Cc: Netfilter Development Mailinglist
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
Patrick McHardy wrote:
> Using the net-2.6.26.git/latest SVN tree I get:
>
> [96565.511804] ip6_tables: MARK target: invalid size 4 != 8
> [96565.536937] ip6_tables: MARK target: invalid size 4 != 8
> [96565.570762] ip6_tables: MARK target: invalid size 4 != 8
>
> Userspace chooses revision 2, the kernel apparently revision 0.
> I'm pretty certain this is some fallout from your latest patches.
Actually it was the other way around, ip6tables was missing the
code to set the revision for targets. This patch resyncs with
iptables.
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 713 bytes --]
Index: ip6tables.c
===================================================================
--- ip6tables.c (Revision 7492)
+++ ip6tables.c (Arbeitskopie)
@@ -1393,9 +1393,16 @@
target->t = fw_calloc(1, size);
target->t->u.target_size = size;
strcpy(target->t->u.user.name, jumpto);
+ set_revision(target->t->u.user.name,
+ target->revision);
if (target->init != NULL)
target->init(target->t);
- opts = merge_options(opts, target->extra_opts, &target->option_offset);
+ opts = merge_options(opts,
+ target->extra_opts,
+ &target->option_offset);
+ if (opts == NULL)
+ exit_error(OTHER_PROBLEM,
+ "can't alloc memory!");
}
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-15 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-15 13:23 ip6tables broken Patrick McHardy
2008-04-15 13:41 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.