All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* .clang-format vs. checkpatch: Lines should not end with a '('
@ 2023-01-19 14:16 Gal Pressman
  2023-01-19 16:57 ` David Laight
  0 siblings, 1 reply; 3+ messages in thread
From: Gal Pressman @ 2023-01-19 14:16 UTC (permalink / raw
  To: Miguel Ojeda, Nathan Chancellor, Nick Desaulniers, Tom Rix
  Cc: linux-kernel, llvm

Hey,

I use clang-format to automatically format my patches, but checkpatch
likes to complain about:
CHECK: Lines should not end with a '('

I thought maybe adding a 'AllowAllArgumentsOnNextLine: false' would make
it happy but that didn't really seem to work.

Anyone else a bit annoyed by this? Maybe there's another solution I'm
failing to see?

Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: .clang-format vs. checkpatch: Lines should not end with a '('
  2023-01-19 14:16 .clang-format vs. checkpatch: Lines should not end with a '(' Gal Pressman
@ 2023-01-19 16:57 ` David Laight
  2023-01-22  7:16   ` Gal Pressman
  0 siblings, 1 reply; 3+ messages in thread
From: David Laight @ 2023-01-19 16:57 UTC (permalink / raw
  To: 'Gal Pressman', Miguel Ojeda, Nathan Chancellor,
	Nick Desaulniers, Tom Rix
  Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev

From: Gal Pressman
> Sent: 19 January 2023 14:17
> 
> I use clang-format to automatically format my patches, but checkpatch
> likes to complain about:
> CHECK: Lines should not end with a '('
> 
> I thought maybe adding a 'AllowAllArgumentsOnNextLine: false' would make
> it happy but that didn't really seem to work.
> 
> Anyone else a bit annoyed by this? Maybe there's another solution I'm
> failing to see?

Reduce the length of very long names and refactor the code to
remove the massive number of indents and you won't have a problem :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: .clang-format vs. checkpatch: Lines should not end with a '('
  2023-01-19 16:57 ` David Laight
@ 2023-01-22  7:16   ` Gal Pressman
  0 siblings, 0 replies; 3+ messages in thread
From: Gal Pressman @ 2023-01-22  7:16 UTC (permalink / raw
  To: David Laight, Miguel Ojeda, Nathan Chancellor, Nick Desaulniers,
	Tom Rix
  Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev

On 19/01/2023 18:57, David Laight wrote:
> From: Gal Pressman
>> Sent: 19 January 2023 14:17
>>
>> I use clang-format to automatically format my patches, but checkpatch
>> likes to complain about:
>> CHECK: Lines should not end with a '('
>>
>> I thought maybe adding a 'AllowAllArgumentsOnNextLine: false' would make
>> it happy but that didn't really seem to work.
>>
>> Anyone else a bit annoyed by this? Maybe there's another solution I'm
>> failing to see?
> 
> Reduce the length of very long names and refactor the code to
> remove the massive number of indents and you won't have a problem :-)

That's one way to do it :), thanks for the response!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-22  7:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-19 14:16 .clang-format vs. checkpatch: Lines should not end with a '(' Gal Pressman
2023-01-19 16:57 ` David Laight
2023-01-22  7:16   ` Gal Pressman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.