From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9271E6FB0; Fri, 22 Mar 2024 07:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.19.9.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711093154; cv=none; b=vFYIEUP5G00dEZ409BrhyvW0/SdtOM7m6GLIPahgbYdiWw2v+/ho16M3oO1nkbTe8iSC7huBOm5hMA2OQWlbXGATNcJ5n2Zodc1rmLUOjnruCzw5SrAYReru1Hy0D543Mc+w7lD3sd2J+A+F1dpzFEPWbX5GjKKQU+kUw+8SAmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711093154; c=relaxed/simple; bh=74IY4W2ReJ+EBD6XqkKEfxqxu9pBcnlGD0ss0VXKhTw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VaxTvPumt0lZr4qdd49l3FTfCmA1KyEtTCIndDc4YfEEOSrEzNQ46NKTqB7w2jXVzPnyxW/fpAGIojC/ThJpv5H8z1LH08unGKymrNlT5kjwyb9H1Zt934mGRWPw34phlLKqoERqd9cho35wW3tkuXA8Hz9h/UOsMj6iy7i7A+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=norik.com; spf=pass smtp.mailfrom=norik.com; dkim=pass (2048-bit key) header.d=norik.com header.i=@norik.com header.b=ntplgsJt; arc=none smtp.client-ip=46.19.9.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=norik.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=norik.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=norik.com header.i=@norik.com header.b="ntplgsJt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XmDDFMU/4E1etv5sIVB4WfwFGi7VCAGsEJBu9uRrii4=; b=ntplgsJtLpus/vc2992ovayXVr xY1h7gl0F9U4X7qnD9MaEwn3gzMxCaBv+BE0Ew/TFtNB1JxSD60Mj9yDNW3SP9AMBEQMRneN367ff F4gZ7pKaaPdB4xtX0OZ37aS5zwe8qbY4CH110T5xAOYHvLUKElqzQuAnXr7J9+5kuz3cEHSpmWnCj AECN7w7n+GLIYFfRPhwS/AnY/E9DIWaMZDTiffyWnxvdprQbrv94BoZurPD+F7TRSLRtbDe0FXfbH MDmq6ytMd+SaaPh8AeImdbmWqu28kvm3rORB01SIRvaRIf0sZ3nUJ8HloT0yxwX3Oa5BZHqOf47wX OQB5UT7Q==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:55020 helo=[192.168.69.84]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1rnZUV-00EHuV-2e; Fri, 22 Mar 2024 08:39:02 +0100 Message-ID: <40e08a5e-e7e9-47c7-9102-24a2bbba67cf@norik.com> Date: Fri, 22 Mar 2024 08:39:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties Content-Language: en-GB To: Krzysztof Kozlowski , haibo.chen@nxp.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org Cc: jic23@kernel.org, lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, upstream@lists.phytec.de References: <20240320100407.1639082-1-andrej.picej@norik.com> <20240320100407.1639082-3-andrej.picej@norik.com> <38637621-1611-4268-ae79-7ac93a72c5ee@linaro.org> <7e58bf96-3c38-467f-86b6-06ff5feedb31@linaro.org> From: Andrej Picej In-Reply-To: <7e58bf96-3c38-467f-86b6-06ff5feedb31@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: On 20. 03. 24 13:15, Krzysztof Kozlowski wrote: > On 20/03/2024 13:05, Andrej Picej wrote: >> Hi Krzysztof, >> >> On 20. 03. 24 11:26, Krzysztof Kozlowski wrote: >>> On 20/03/2024 11:04, Andrej Picej wrote: >>>> Document calibration properties and how to set them. >>> >>> Bindings are before users. >> >> will change patch order when I send a v2. >> >>> >>> Please use subject prefixes matching the subsystem. You can get them for >>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >>> your patch is touching. >>> There is no file extension in prefixes. >> >> So: dt-bindings: iio/adc: nxp,imx93-adc: Add calibration properties? > > Did you run the command I proposed? I don't see much of "/", but except > that looks good. Ok noted. > >> >>> >>>> >>>> Signed-off-by: Andrej Picej >>>> --- >>>> .../bindings/iio/adc/nxp,imx93-adc.yaml | 15 +++++++++++++++ >>>> 1 file changed, 15 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>>> index dacc526dc695..64958be62a6a 100644 >>>> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>>> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>>> @@ -46,6 +46,21 @@ properties: >>>> "#io-channel-cells": >>>> const: 1 >>>> >>>> + nxp,calib-avg-en: >>>> + description: >>>> + Enable or disable averaging of calibration time. >>>> + enum: [ 0, 1 ] >>>> + >>>> + nxp,calib-nr-samples: >>>> + description: >>>> + Selects the number of averaging samples to be used during calibration. >>>> + enum: [ 16, 32, 128, 512 ] >>>> + >>>> + nxp,calib-t-samples: >>>> + description: >>>> + Specifies the sample time of calibration conversions. >>>> + enum: [ 8, 16, 22, 32 ] >>> >>> No, use existing, generic properties. Open other bindings for this. >> >> You mean I should use generic properties for the ADC calibration >> settings? Is there already something in place? Because as I understand >> it, these calib-* values only effect the calibration process of the ADC. > > Please take a look at other devices and dtschema. We already have some > properties for this... but maybe they cannot be used? > I did look into other ADC devices, grep across iio/adc, adc bindings folders and couldn't find anything closely related to what we are looking for. Could you please point me to the properties that you think should be used for this? Thank you. Andrej > > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97264C54E71 for ; Fri, 22 Mar 2024 07:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Jr39nQLN4eAQ19dJATwV3OISN3Os8XQQRTcXI9o+wI=; b=otQuY/dwqHGtW0 cX+jEqcWP1j2+YF0zvP02EjIg2yr6H/o/uaIhxunZFTCelPJHWQ9y4qW7U6P3tcf96woQASwhX8dE FFKMoxm6wgxLUrCBK2FcpUeZWewrTd7bYPyyDpE3IWpWccFdgsTkLtFEchjjimNk25xD49vV8+oJO +gCnWpZXy2m7ahsGiIBHivzQ1N4rAQ/KySP6V9vywI/DBYhRsOp30xru0uMUNg25a9FR4wQaI94Ox YHCMvCV3VNc4pcoz8q1Eo8lLV/N04VQtc/Hp7qubqVBdcQGuGSdMA4dj05fpkgssb87e+7474M8et TdT5Y/KlPreqAbEKG7pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnZUv-00000006DsG-2hAW; Fri, 22 Mar 2024 07:39:29 +0000 Received: from cpanel.siel.si ([46.19.9.99]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnZUr-00000006Dlf-3W7q for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 07:39:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XmDDFMU/4E1etv5sIVB4WfwFGi7VCAGsEJBu9uRrii4=; b=ntplgsJtLpus/vc2992ovayXVr xY1h7gl0F9U4X7qnD9MaEwn3gzMxCaBv+BE0Ew/TFtNB1JxSD60Mj9yDNW3SP9AMBEQMRneN367ff F4gZ7pKaaPdB4xtX0OZ37aS5zwe8qbY4CH110T5xAOYHvLUKElqzQuAnXr7J9+5kuz3cEHSpmWnCj AECN7w7n+GLIYFfRPhwS/AnY/E9DIWaMZDTiffyWnxvdprQbrv94BoZurPD+F7TRSLRtbDe0FXfbH MDmq6ytMd+SaaPh8AeImdbmWqu28kvm3rORB01SIRvaRIf0sZ3nUJ8HloT0yxwX3Oa5BZHqOf47wX OQB5UT7Q==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:55020 helo=[192.168.69.84]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1rnZUV-00EHuV-2e; Fri, 22 Mar 2024 08:39:02 +0100 Message-ID: <40e08a5e-e7e9-47c7-9102-24a2bbba67cf@norik.com> Date: Fri, 22 Mar 2024 08:39:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties Content-Language: en-GB To: Krzysztof Kozlowski , haibo.chen@nxp.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org Cc: jic23@kernel.org, lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, upstream@lists.phytec.de References: <20240320100407.1639082-1-andrej.picej@norik.com> <20240320100407.1639082-3-andrej.picej@norik.com> <38637621-1611-4268-ae79-7ac93a72c5ee@linaro.org> <7e58bf96-3c38-467f-86b6-06ff5feedb31@linaro.org> From: Andrej Picej In-Reply-To: <7e58bf96-3c38-467f-86b6-06ff5feedb31@linaro.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_003926_139330_1512ED16 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20. 03. 24 13:15, Krzysztof Kozlowski wrote: > On 20/03/2024 13:05, Andrej Picej wrote: >> Hi Krzysztof, >> >> On 20. 03. 24 11:26, Krzysztof Kozlowski wrote: >>> On 20/03/2024 11:04, Andrej Picej wrote: >>>> Document calibration properties and how to set them. >>> >>> Bindings are before users. >> >> will change patch order when I send a v2. >> >>> >>> Please use subject prefixes matching the subsystem. You can get them for >>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >>> your patch is touching. >>> There is no file extension in prefixes. >> >> So: dt-bindings: iio/adc: nxp,imx93-adc: Add calibration properties? > > Did you run the command I proposed? I don't see much of "/", but except > that looks good. Ok noted. > >> >>> >>>> >>>> Signed-off-by: Andrej Picej >>>> --- >>>> .../bindings/iio/adc/nxp,imx93-adc.yaml | 15 +++++++++++++++ >>>> 1 file changed, 15 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>>> index dacc526dc695..64958be62a6a 100644 >>>> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>>> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>>> @@ -46,6 +46,21 @@ properties: >>>> "#io-channel-cells": >>>> const: 1 >>>> >>>> + nxp,calib-avg-en: >>>> + description: >>>> + Enable or disable averaging of calibration time. >>>> + enum: [ 0, 1 ] >>>> + >>>> + nxp,calib-nr-samples: >>>> + description: >>>> + Selects the number of averaging samples to be used during calibration. >>>> + enum: [ 16, 32, 128, 512 ] >>>> + >>>> + nxp,calib-t-samples: >>>> + description: >>>> + Specifies the sample time of calibration conversions. >>>> + enum: [ 8, 16, 22, 32 ] >>> >>> No, use existing, generic properties. Open other bindings for this. >> >> You mean I should use generic properties for the ADC calibration >> settings? Is there already something in place? Because as I understand >> it, these calib-* values only effect the calibration process of the ADC. > > Please take a look at other devices and dtschema. We already have some > properties for this... but maybe they cannot be used? > I did look into other ADC devices, grep across iio/adc, adc bindings folders and couldn't find anything closely related to what we are looking for. Could you please point me to the properties that you think should be used for this? Thank you. Andrej > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel