* [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist
@ 2023-12-23 7:36 Seiji Nishikawa
2023-12-23 11:46 ` Pali Rohár
2024-01-08 15:34 ` Guenter Roeck
0 siblings, 2 replies; 7+ messages in thread
From: Seiji Nishikawa @ 2023-12-23 7:36 UTC (permalink / raw
To: pali; +Cc: jdelvare, linux, linux-hwmon, snishika
This patch, in addition to 95d88d054ad9 that added Dell Precision 7510 to fan
control whitelist, also adds Precision 7540 to the whitelist, which allows manual
PWM control on Dell Precision 7540. It has been confirmed that the same SMM
commands work to enable/disable manual PWM control on Dell Precision 7540.
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 44aaf9b9191d..f946257f72c6 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1330,6 +1330,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
},
+ {
+ .ident = "Dell Precision 7540",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 7540"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+ },
{
.ident = "Dell XPS 13 7390",
.matches = {
--
2.42.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist
2023-12-23 7:36 [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist Seiji Nishikawa
@ 2023-12-23 11:46 ` Pali Rohár
2024-01-08 15:34 ` Guenter Roeck
1 sibling, 0 replies; 7+ messages in thread
From: Pali Rohár @ 2023-12-23 11:46 UTC (permalink / raw
To: Seiji Nishikawa; +Cc: jdelvare, linux, linux-hwmon
On Saturday 23 December 2023 16:36:58 Seiji Nishikawa wrote:
> This patch, in addition to 95d88d054ad9 that added Dell Precision 7510 to fan
> control whitelist, also adds Precision 7540 to the whitelist, which allows manual
> PWM control on Dell Precision 7540. It has been confirmed that the same SMM
> commands work to enable/disable manual PWM control on Dell Precision 7540.
> ---
Acked-by: Pali Rohár <pali@kernel.org>
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 44aaf9b9191d..f946257f72c6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1330,6 +1330,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell Precision 7540",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 7540"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> {
> .ident = "Dell XPS 13 7390",
> .matches = {
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist
2023-12-23 7:36 [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist Seiji Nishikawa
2023-12-23 11:46 ` Pali Rohár
@ 2024-01-08 15:34 ` Guenter Roeck
2024-03-25 4:59 ` 'Re: [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist' Seiji Nishikawa
1 sibling, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2024-01-08 15:34 UTC (permalink / raw
To: Seiji Nishikawa; +Cc: pali, jdelvare, linux-hwmon
On Sat, Dec 23, 2023 at 04:36:58PM +0900, Seiji Nishikawa wrote:
> This patch, in addition to 95d88d054ad9 that added Dell Precision 7510 to fan
> control whitelist, also adds Precision 7540 to the whitelist, which allows manual
Use imperative mood to describe your patch.
> PWM control on Dell Precision 7540. It has been confirmed that the same SMM
> commands work to enable/disable manual PWM control on Dell Precision 7540.
> Acked-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 44aaf9b9191d..f946257f72c6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1330,6 +1330,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell Precision 7540",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 7540"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> {
> .ident = "Dell XPS 13 7390",
> .matches = {
Patch uses spaces instead of tabs and produces lots of checkpatch warnings
and errors. Also, Signed-off: tag is missing.
Overall, please read and follow Documentation/process/submitting-patches.rst.
Guenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* 'Re: [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist'
2024-01-08 15:34 ` Guenter Roeck
@ 2024-03-25 4:59 ` Seiji Nishikawa
2024-03-25 4:59 ` [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist Seiji Nishikawa
0 siblings, 1 reply; 7+ messages in thread
From: Seiji Nishikawa @ 2024-03-25 4:59 UTC (permalink / raw
To: pali; +Cc: jdelvare, linux, linux-hwmon, snishika
On Tue, Jan 9, 2024 at 12:34 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Sat, Dec 23, 2023 at 04:36:58PM +0900, Seiji Nishikawa wrote:
> > This patch, in addition to 95d88d054ad9 that added Dell Precision 7510 to fan
> > control whitelist, also adds Precision 7540 to the whitelist, which allows manual
>
> Use imperative mood to describe your patch.
Just as you pointed out.
> > PWM control on Dell Precision 7540. It has been confirmed that the same SMM
> > commands work to enable/disable manual PWM control on Dell Precision 7540.
> > Acked-by: Pali Rohár <pali@kernel.org>
> > ---
> > drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > index 44aaf9b9191d..f946257f72c6 100644
> > --- a/drivers/hwmon/dell-smm-hwmon.c
> > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > @@ -1330,6 +1330,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> > },
> > .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> > },
> > + {
> > + .ident = "Dell Precision 7540",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 7540"),
> > + },
> > + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> > + },
> > {
> > .ident = "Dell XPS 13 7390",
> > .matches = {
>
> Patch uses spaces instead of tabs and produces lots of checkpatch warnings
> and errors. Also, Signed-off: tag is missing.
Apologies for the noises and the missing tag.
> Overall, please read and follow Documentation/process/submitting-patches.rst.
I should have done that.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist
2024-03-25 4:59 ` 'Re: [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist' Seiji Nishikawa
@ 2024-03-25 4:59 ` Seiji Nishikawa
2024-03-25 16:08 ` Guenter Roeck
0 siblings, 1 reply; 7+ messages in thread
From: Seiji Nishikawa @ 2024-03-25 4:59 UTC (permalink / raw
To: pali; +Cc: jdelvare, linux, linux-hwmon, snishika
Add Precision 7540 to the fan control whitelist, in addition to 7510.
Signed-off-by: Seiji Nishikawa <snishika@redhat.com>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index efcf78673e74..0e12634e83cb 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1506,6 +1506,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
},
+ {
+ .ident = "Dell Precision 7540",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 7540"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+ },
{
.ident = "Dell XPS 13 7390",
.matches = {
--
2.44.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist
2024-03-25 4:59 ` [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist Seiji Nishikawa
@ 2024-03-25 16:08 ` Guenter Roeck
2024-03-26 5:24 ` 'Re: [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist' Seiji Nishikawa
0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2024-03-25 16:08 UTC (permalink / raw
To: Seiji Nishikawa; +Cc: pali, jdelvare, linux-hwmon
On Mon, Mar 25, 2024 at 01:59:13PM +0900, Seiji Nishikawa wrote:
> Add Precision 7540 to the fan control whitelist, in addition to 7510.
>
> Signed-off-by: Seiji Nishikawa <snishika@redhat.com>
Applied. Note though that sending a new version of a patch as reply to
an older one may easily result in it getting lost, so I'd recommend not
to do that.
Guenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* 'Re: [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist'
2024-03-25 16:08 ` Guenter Roeck
@ 2024-03-26 5:24 ` Seiji Nishikawa
0 siblings, 0 replies; 7+ messages in thread
From: Seiji Nishikawa @ 2024-03-26 5:24 UTC (permalink / raw
To: pali; +Cc: jdelvare, linux, linux-hwmon, snishika
On Tue, Mar 26, 2024 at 1:08 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Mon, Mar 25, 2024 at 01:59:13PM +0900, Seiji Nishikawa wrote:
> > Add Precision 7540 to the fan control whitelist, in addition to 7510.
> >
> > Signed-off-by: Seiji Nishikawa <snishika@redhat.com>
>
> Applied. Note though that sending a new version of a patch as reply to
> an older one may easily result in it getting lost, so I'd recommend not
> to do that.
Thank you. Noted. I won't do that again.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-03-26 5:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-23 7:36 [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist Seiji Nishikawa
2023-12-23 11:46 ` Pali Rohár
2024-01-08 15:34 ` Guenter Roeck
2024-03-25 4:59 ` 'Re: [PATCH] hwmon: (dell-smm) Also add Dell Precision 7540 to fan control whitelist' Seiji Nishikawa
2024-03-25 4:59 ` [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist Seiji Nishikawa
2024-03-25 16:08 ` Guenter Roeck
2024-03-26 5:24 ` 'Re: [PATCH v2] hwmon: (dell-smm) Add Dell Precision 7540 to fan control whitelist' Seiji Nishikawa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.