* [PATCH 0/2] Fix the iio-gts-helpers available times table sorting
@ 2024-04-29 6:28 Matti Vaittinen
2024-04-29 6:29 ` [PATCH 1/2] iio: Fix the sorting functionality in iio_gts_build_avail_time_table Chenyuan Yang
2024-04-29 6:29 ` [PATCH 2/2] iio: test: gts: test available times and gains sorting Matti Vaittinen
0 siblings, 2 replies; 4+ messages in thread
From: Matti Vaittinen @ 2024-04-29 6:28 UTC (permalink / raw
To: Matti Vaittinen, Matti Vaittinen
Cc: Matti Vaittinen, Jonathan Cameron, Lars-Peter Clausen, linux-iio,
linux-kernel, Chenyuan Yang
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Fix the available times table sorting in iio-gts-helpers
This series contains a fix and test for the sorting of the available times in
IIO-gts helpers. Fix was originally developed and posted by Chenyuan Yang.
Chenyuan Yang (1):
iio: Fix the sorting functionality in iio_gts_build_avail_time_table
Matti Vaittinen (1):
iio: test: gts: test available times and gains sorting
drivers/iio/industrialio-gts-helper.c | 7 +++++--
drivers/iio/test/iio-test-gts.c | 8 +++++---
2 files changed, 10 insertions(+), 5 deletions(-)
base-commit: 4cece764965020c22cff7665b18a012006359095
--
2.44.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] iio: Fix the sorting functionality in iio_gts_build_avail_time_table
2024-04-29 6:28 [PATCH 0/2] Fix the iio-gts-helpers available times table sorting Matti Vaittinen
@ 2024-04-29 6:29 ` Chenyuan Yang
2024-04-29 6:40 ` Matti Vaittinen
2024-04-29 6:29 ` [PATCH 2/2] iio: test: gts: test available times and gains sorting Matti Vaittinen
1 sibling, 1 reply; 4+ messages in thread
From: Chenyuan Yang @ 2024-04-29 6:29 UTC (permalink / raw
To: Matti Vaittinen, Matti Vaittinen
Cc: Matti Vaittinen, Jonathan Cameron, Lars-Peter Clausen, linux-iio,
linux-kernel, Chenyuan Yang
[-- Attachment #1: Type: text/plain, Size: 2858 bytes --]
The sorting in iio_gts_build_avail_time_table is not working as intended.
It could result in an out-of-bounds access when the time is zero.
Here are more details:
1. When the gts->itime_table[i].time_us is zero, e.g., the time
sequence is `3, 0, 1`, the inner for-loop will not terminate and do
out-of-bound writes. This is because once `times[j] > new`, the value
`new` will be added in the current position and the `times[j]` will be
moved to `j+1` position, which makes the if-condition always hold.
Meanwhile, idx will be added one, making the loop keep running without
termination and out-of-bound write.
2. If none of the gts->itime_table[i].time_us is zero, the elements
will just be copied without being sorted as described in the comment
"Sort times from all tables to one and remove duplicates".
For more details, please refer to
https://lore.kernel.org/all/6dd0d822-046c-4dd2-9532-79d7ab96ec05@gmail.com.
Reported-by: Chenyuan Yang <chenyuan0y@gmail.com>
Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
Co-developed-by: Chenyuan Yang <chenyuan0y@gmail.com>
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Co-developed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
Original commit (by Chenyuan Yang) was amended by me to remove duplicates
so that the user-space callers do not get multiple instances of same time
as was discussed here:
https://lore.kernel.org/all/a59061f8-5caa-43d4-bd4f-5ac4c39515ba@gmail.com/
---
drivers/iio/industrialio-gts-helper.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c
index b51eb6cb766f..59d7615c0f56 100644
--- a/drivers/iio/industrialio-gts-helper.c
+++ b/drivers/iio/industrialio-gts-helper.c
@@ -362,17 +362,20 @@ static int iio_gts_build_avail_time_table(struct iio_gts *gts)
for (i = gts->num_itime - 1; i >= 0; i--) {
int new = gts->itime_table[i].time_us;
- if (times[idx] < new) {
+ if (idx == 0 || times[idx - 1] < new) {
times[idx++] = new;
continue;
}
- for (j = 0; j <= idx; j++) {
+ for (j = 0; j < idx; j++) {
+ if (times[j] == new)
+ break;
if (times[j] > new) {
memmove(×[j + 1], ×[j],
(idx - j) * sizeof(int));
times[j] = new;
idx++;
+ break;
}
}
}
--
2.44.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] iio: test: gts: test available times and gains sorting
2024-04-29 6:28 [PATCH 0/2] Fix the iio-gts-helpers available times table sorting Matti Vaittinen
2024-04-29 6:29 ` [PATCH 1/2] iio: Fix the sorting functionality in iio_gts_build_avail_time_table Chenyuan Yang
@ 2024-04-29 6:29 ` Matti Vaittinen
1 sibling, 0 replies; 4+ messages in thread
From: Matti Vaittinen @ 2024-04-29 6:29 UTC (permalink / raw
To: Matti Vaittinen, Matti Vaittinen
Cc: Matti Vaittinen, Jonathan Cameron, Lars-Peter Clausen, linux-iio,
linux-kernel, Chenyuan Yang
[-- Attachment #1: Type: text/plain, Size: 2836 bytes --]
The iio_gts helpers build available times and scales tables based on the
times and gains arrays given from the driver. The driver should be able
to list all valid register values so that conversion from register valu
to correct gain/time works for all supported register values.
It might be more convenient for drivers to list these times and gains in
the order where they're listed in the data-sheet than ascending order.
However, for user who requests the supported scales / times it is more
convenient to get the results in asscending order. Also, listing
duplicated values is not meaning for the user.
Hence the GTS heler should do sorting and deduplication of the scales
and times when it builds the tables listing the available times/scales.
Note, currently duplicated gain values aren't handled by GTS-helpers.
Unsort the gain and time arrays in the test code, and add duplicates to
time array in order to test the sorting and deduplicating works.
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
drivers/iio/test/iio-test-gts.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/test/iio-test-gts.c b/drivers/iio/test/iio-test-gts.c
index cf7ab773ea0b..5f16a7b5e6d4 100644
--- a/drivers/iio/test/iio-test-gts.c
+++ b/drivers/iio/test/iio-test-gts.c
@@ -70,6 +70,7 @@
*/
static struct iio_gts gts;
+/* Keep the gain and time tables unsorted to test the sorting */
static const struct iio_gain_sel_pair gts_test_gains[] = {
GAIN_SCALE_GAIN(1, TEST_GSEL_1),
GAIN_SCALE_GAIN(4, TEST_GSEL_4),
@@ -79,16 +80,17 @@ static const struct iio_gain_sel_pair gts_test_gains[] = {
GAIN_SCALE_GAIN(256, TEST_GSEL_256),
GAIN_SCALE_GAIN(512, TEST_GSEL_512),
GAIN_SCALE_GAIN(1024, TEST_GSEL_1024),
- GAIN_SCALE_GAIN(2048, TEST_GSEL_2048),
GAIN_SCALE_GAIN(4096, TEST_GSEL_4096),
+ GAIN_SCALE_GAIN(2048, TEST_GSEL_2048),
#define HWGAIN_MAX 4096
};
static const struct iio_itime_sel_mul gts_test_itimes[] = {
- GAIN_SCALE_ITIME_US(400 * 1000, TEST_TSEL_400, 8),
- GAIN_SCALE_ITIME_US(200 * 1000, TEST_TSEL_200, 4),
GAIN_SCALE_ITIME_US(100 * 1000, TEST_TSEL_100, 2),
+ GAIN_SCALE_ITIME_US(400 * 1000, TEST_TSEL_400, 8),
+ GAIN_SCALE_ITIME_US(400 * 1000, TEST_TSEL_400, 8),
GAIN_SCALE_ITIME_US(50 * 1000, TEST_TSEL_50, 1),
+ GAIN_SCALE_ITIME_US(200 * 1000, TEST_TSEL_200, 4),
#define TIMEGAIN_MAX 8
};
#define TOTAL_GAIN_MAX (HWGAIN_MAX * TIMEGAIN_MAX)
--
2.44.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] iio: Fix the sorting functionality in iio_gts_build_avail_time_table
2024-04-29 6:29 ` [PATCH 1/2] iio: Fix the sorting functionality in iio_gts_build_avail_time_table Chenyuan Yang
@ 2024-04-29 6:40 ` Matti Vaittinen
0 siblings, 0 replies; 4+ messages in thread
From: Matti Vaittinen @ 2024-04-29 6:40 UTC (permalink / raw
To: Matti Vaittinen
Cc: Jonathan Cameron, Lars-Peter Clausen, linux-iio, linux-kernel,
Chenyuan Yang
On 4/29/24 09:29, Chenyuan Yang wrote:
> The sorting in iio_gts_build_avail_time_table is not working as intended.
> It could result in an out-of-bounds access when the time is zero.
>
> Here are more details:
>
> 1. When the gts->itime_table[i].time_us is zero, e.g., the time
> sequence is `3, 0, 1`, the inner for-loop will not terminate and do
> out-of-bound writes. This is because once `times[j] > new`, the value
> `new` will be added in the current position and the `times[j]` will be
> moved to `j+1` position, which makes the if-condition always hold.
> Meanwhile, idx will be added one, making the loop keep running without
> termination and out-of-bound write.
> 2. If none of the gts->itime_table[i].time_us is zero, the elements
> will just be copied without being sorted as described in the comment
> "Sort times from all tables to one and remove duplicates".
>
> For more details, please refer to
> https://lore.kernel.org/all/6dd0d822-046c-4dd2-9532-79d7ab96ec05@gmail.com.
>
> Reported-by: Chenyuan Yang <chenyuan0y@gmail.com>
> Suggested-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
> Co-developed-by: Chenyuan Yang <chenyuan0y@gmail.com>
> Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
> Co-developed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Huh. I had never before sent a patch with co-authored tags. Just to
ensure there is no misunderstandings - I did send this patch mail. I
added the From: tag as was suggested in:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
I am afraid mutt picked the email sender from this tag - which does not
fee like correct thing to do! Sorry! I did not intend to impersonate
Chenyuan!
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-29 6:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 6:28 [PATCH 0/2] Fix the iio-gts-helpers available times table sorting Matti Vaittinen
2024-04-29 6:29 ` [PATCH 1/2] iio: Fix the sorting functionality in iio_gts_build_avail_time_table Chenyuan Yang
2024-04-29 6:40 ` Matti Vaittinen
2024-04-29 6:29 ` [PATCH 2/2] iio: test: gts: test available times and gains sorting Matti Vaittinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.