From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Tejun Heo <tj@kernel.org>
Cc: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] writeback use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh
Date: Mon, 6 May 2024 09:36:16 +0800 [thread overview]
Message-ID: <3bbfdaa6-c212-64eb-702f-7a8e18af2c67@huaweicloud.com> (raw)
In-Reply-To: <ZjJ0P2d5v5fW5J7h@slm.duckdns.org>
on 5/2/2024 12:56 AM, Tejun Heo wrote:
> Hello,
>
> On Mon, Apr 29, 2024 at 11:47:32AM +0800, Kemeng Shi wrote:
>> Use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh to remove
>> repeated code.
>
> Maybe fold this into the patch to factor out domain_dirty_avail()?
>
>> + global_domain_dirty_avail(&gdtc, false);
>> + wb_domain_dirty_avail(&mdtc, false);
>
> I'd just use domain_dirty_avail(). The compiler should be able to figure out
> the branches and eliminate them and it removes an unnecessary source of
> error.
Sure, will this do this in next version.
Thanks.
>
> Thanks.
>
next prev parent reply other threads:[~2024-05-06 1:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 3:47 [PATCH 00/10] Add helper functions to remove repeated code and Kemeng Shi
2024-04-29 3:47 ` [PATCH 01/10] writeback: factor out wb_bg_dirty_limits to remove repeated code Kemeng Shi
2024-05-01 16:40 ` Tejun Heo
2024-04-29 3:47 ` [PATCH 02/10] writeback: add general function domain_dirty_avail to calculate dirty and avail of domain Kemeng Shi
2024-05-01 16:49 ` Tejun Heo
2024-05-06 1:32 ` Kemeng Shi
2024-04-29 3:47 ` [PATCH 03/10] writeback: factor out domain_over_bg_thresh to remove repeated code Kemeng Shi
2024-05-01 16:53 ` Tejun Heo
2024-04-29 3:47 ` [PATCH 04/10] writeback use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh Kemeng Shi
2024-05-01 16:56 ` Tejun Heo
2024-05-06 1:36 ` Kemeng Shi [this message]
2024-04-29 3:47 ` [PATCH 05/10] writeback: call domain_dirty_avail in balance_dirty_pages Kemeng Shi
2024-05-01 16:57 ` Tejun Heo
2024-05-06 1:36 ` Kemeng Shi
2024-04-29 3:47 ` [PATCH 06/10] writeback: Factor out code of freerun to remove repeated code Kemeng Shi
2024-05-01 17:15 ` Tejun Heo
2024-05-06 1:38 ` Kemeng Shi
2024-04-29 3:47 ` [PATCH 07/10] writeback: factor out wb_dirty_freerun to remove more repeated freerun code Kemeng Shi
2024-05-01 17:18 ` Tejun Heo
2024-05-06 1:53 ` Kemeng Shi
2024-04-29 3:47 ` [PATCH 08/10] writeback: factor out balance_domain_limits to remove repeated code Kemeng Shi
2024-05-01 17:21 ` Tejun Heo
2024-04-29 3:47 ` [PATCH 09/10] writeback: factor out wb_dirty_exceeded " Kemeng Shi
2024-04-30 7:24 ` Dan Carpenter
2024-05-06 2:15 ` Kemeng Shi
2024-05-01 17:28 ` Tejun Heo
2024-04-29 3:47 ` [PATCH 10/10] writeback: factor out balance_wb_limits " Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bbfdaa6-c212-64eb-702f-7a8e18af2c67@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.