* [OE-core] [PATCH V4 0/2] bluez5: change configuration directory mode
@ 2022-10-06 11:27 liu.ming50
2022-10-06 11:27 ` [OE-core] [PATCH V4 1/2] " liu.ming50
2022-10-06 11:27 ` [OE-core] [PATCH V4 2/2] testsdk.py: ensure the testsdk directory is writable before removing it liu.ming50
0 siblings, 2 replies; 5+ messages in thread
From: liu.ming50 @ 2022-10-06 11:27 UTC (permalink / raw
To: openembedded-core; +Cc: Ming Liu
From: Ming Liu <liu.ming50@gmail.com>
The changes in V4:
1 In commit message, add reference to
https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=00cfb36e20e3c35db2150e7d0351ad7b8442e2d8
2 Make testsdk directory writable before removing it.
Both as suggested by @Luca Ceresoli.
Ming Liu (2):
bluez5: change configuration directory mode
testsdk.py: ensure the testsdk directory is writable before removing
it
meta/lib/oeqa/sdk/testsdk.py | 4 ++++
meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [OE-core] [PATCH V4 1/2] bluez5: change configuration directory mode
2022-10-06 11:27 [OE-core] [PATCH V4 0/2] bluez5: change configuration directory mode liu.ming50
@ 2022-10-06 11:27 ` liu.ming50
2022-10-06 12:19 ` Ross Burton
2022-10-06 11:27 ` [OE-core] [PATCH V4 2/2] testsdk.py: ensure the testsdk directory is writable before removing it liu.ming50
1 sibling, 1 reply; 5+ messages in thread
From: liu.ming50 @ 2022-10-06 11:27 UTC (permalink / raw
To: openembedded-core; +Cc: Ming Liu
From: Ming Liu <liu.ming50@gmail.com>
Change configuration directory mode from 0755 to 0555, this fixes a
following warning when bluetoothd starts:
| ConfigurationDirectory 'bluetooth' already exists but the mode is different.
| (File system: 755 ConfigurationDirectoryMode: 555)
Reference:
https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=00cfb36e20e3c35db2150e7d0351ad7b8442e2d8
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index 79d4645ca8..9f5c78b81e 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -82,7 +82,7 @@ do_install:append() {
install -d ${D}${INIT_D_DIR}
install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
- install -d ${D}${sysconfdir}/bluetooth/
+ install -m 0555 -d ${D}${sysconfdir}/bluetooth/
if [ -f ${S}/profiles/network/network.conf ]; then
install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
fi
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [OE-core] [PATCH V4 2/2] testsdk.py: ensure the testsdk directory is writable before removing it
2022-10-06 11:27 [OE-core] [PATCH V4 0/2] bluez5: change configuration directory mode liu.ming50
2022-10-06 11:27 ` [OE-core] [PATCH V4 1/2] " liu.ming50
@ 2022-10-06 11:27 ` liu.ming50
1 sibling, 0 replies; 5+ messages in thread
From: liu.ming50 @ 2022-10-06 11:27 UTC (permalink / raw
To: openembedded-core; +Cc: Ming Liu
From: Ming Liu <liu.ming50@gmail.com>
We have to make sure all users have write permission to testsdk
directory before removing it, this is to avoid potential 'rm' failures.
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
meta/lib/oeqa/sdk/testsdk.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/lib/oeqa/sdk/testsdk.py b/meta/lib/oeqa/sdk/testsdk.py
index 35e40187bc..e0179c9849 100644
--- a/meta/lib/oeqa/sdk/testsdk.py
+++ b/meta/lib/oeqa/sdk/testsdk.py
@@ -101,6 +101,10 @@ class TestSDK(TestSDKBase):
processes = None
sdk_dir = d.expand("${WORKDIR}/testimage-sdk/")
+
+ # Ensure the Test SDK directory is writable for all users.
+ subprocess.check_output(['chmod', 'ugo+w', '-R', sdk_dir], stderr=subprocess.STDOUT)
+
bb.utils.remove(sdk_dir, True)
bb.utils.mkdirhier(sdk_dir)
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH V4 1/2] bluez5: change configuration directory mode
2022-10-06 11:27 ` [OE-core] [PATCH V4 1/2] " liu.ming50
@ 2022-10-06 12:19 ` Ross Burton
2022-10-07 7:54 ` Ming Liu
0 siblings, 1 reply; 5+ messages in thread
From: Ross Burton @ 2022-10-06 12:19 UTC (permalink / raw
To: liu.ming50@gmail.com; +Cc: openembedded-core@lists.openembedded.org
Is this in a build with systemd or sysvinit? Looking at the referenced commit, that’s when running in a systemd-managed contained environment. In sysv that isn’t the case, so I’m not convinced this is the correct solution.
Ross
> On 6 Oct 2022, at 12:27, Ming Liu via lists.openembedded.org <liu.ming50=gmail.com@lists.openembedded.org> wrote:
>
> From: Ming Liu <liu.ming50@gmail.com>
>
> Change configuration directory mode from 0755 to 0555, this fixes a
> following warning when bluetoothd starts:
> | ConfigurationDirectory 'bluetooth' already exists but the mode is different.
> | (File system: 755 ConfigurationDirectoryMode: 555)
>
> Reference:
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=00cfb36e20e3c35db2150e7d0351ad7b8442e2d8
>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 79d4645ca8..9f5c78b81e 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -82,7 +82,7 @@ do_install:append() {
> install -d ${D}${INIT_D_DIR}
> install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
>
> - install -d ${D}${sysconfdir}/bluetooth/
> + install -m 0555 -d ${D}${sysconfdir}/bluetooth/
> if [ -f ${S}/profiles/network/network.conf ]; then
> install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
> fi
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171494): https://lists.openembedded.org/g/openembedded-core/message/171494
> Mute This Topic: https://lists.openembedded.org/mt/94155398/6875888
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH V4 1/2] bluez5: change configuration directory mode
2022-10-06 12:19 ` Ross Burton
@ 2022-10-07 7:54 ` Ming Liu
0 siblings, 0 replies; 5+ messages in thread
From: Ming Liu @ 2022-10-07 7:54 UTC (permalink / raw
To: Ross Burton; +Cc: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 2447 bytes --]
Hi, Ross:
I think it applies for both systemd and sysvinit, it's bluez5's requirement
that /etc/bluetooth should be read-only.
//Ming Liu
Ross Burton <Ross.Burton@arm.com> 於 2022年10月6日 週四 下午2:19寫道：
> Is this in a build with systemd or sysvinit? Looking at the referenced
> commit, that’s when running in a systemd-managed contained environment. In
> sysv that isn’t the case, so I’m not convinced this is the correct solution.
>
> Ross
>
> > On 6 Oct 2022, at 12:27, Ming Liu via lists.openembedded.org
> <liu.ming50=gmail.com@lists.openembedded.org> wrote:
> >
> > From: Ming Liu <liu.ming50@gmail.com>
> >
> > Change configuration directory mode from 0755 to 0555, this fixes a
> > following warning when bluetoothd starts:
> > | ConfigurationDirectory 'bluetooth' already exists but the mode is
> different.
> > | (File system: 755 ConfigurationDirectoryMode: 555)
> >
> > Reference:
> >
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=00cfb36e20e3c35db2150e7d0351ad7b8442e2d8
> >
> > Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> > ---
> > meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc
> b/meta/recipes-connectivity/bluez5/bluez5.inc
> > index 79d4645ca8..9f5c78b81e 100644
> > --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> > +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> > @@ -82,7 +82,7 @@ do_install:append() {
> > install -d ${D}${INIT_D_DIR}
> > install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
> >
> > - install -d ${D}${sysconfdir}/bluetooth/
> > + install -m 0555 -d ${D}${sysconfdir}/bluetooth/
> > if [ -f ${S}/profiles/network/network.conf ]; then
> > install -m 0644 ${S}/profiles/network/network.conf
> ${D}/${sysconfdir}/bluetooth/
> > fi
> > --
> > 2.25.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#171494):
> https://lists.openembedded.org/g/openembedded-core/message/171494
> > Mute This Topic: https://lists.openembedded.org/mt/94155398/6875888
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ross.burton@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
[-- Attachment #2: Type: text/html, Size: 3904 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-07 7:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-06 11:27 [OE-core] [PATCH V4 0/2] bluez5: change configuration directory mode liu.ming50
2022-10-06 11:27 ` [OE-core] [PATCH V4 1/2] " liu.ming50
2022-10-06 12:19 ` Ross Burton
2022-10-07 7:54 ` Ming Liu
2022-10-06 11:27 ` [OE-core] [PATCH V4 2/2] testsdk.py: ensure the testsdk directory is writable before removing it liu.ming50
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.