From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: lukas.funke-oss@weidmueller.com
Cc: E Shattow <lucent@gmail.com>,
Lukas Funke <lukas.funke@weidmueller.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Bo Gan <ganboing@gmail.com>,
Chanho Park <chanho61.park@samsung.com>,
Leo <ycliang@andestech.com>,
Minda Chen <minda.chen@starfivetech.com>,
Shiji Yang <yangshiji66@outlook.com>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
Yanhong Wang <yanhong.wang@starfivetech.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 2/2] board: starfive: Rename spl_soc_init() to spl_dram_init()
Date: Wed, 24 Apr 2024 13:01:17 +0200 [thread overview]
Message-ID: <3707b3b7-8ded-4c97-93fe-491da21feb0f@gmx.de> (raw)
In-Reply-To: <20240424074339.210851-3-lukas.funke-oss@weidmueller.com>
On 24.04.24 09:43, lukas.funke-oss@weidmueller.com wrote:
> From: Lukas Funke <lukas.funke@weidmueller.com>
>
> Rename spl_soc_init() to spl_dram_init() because the generic function
> name does not reflect what the function actually does. Also
> spl_dram_init() is commonly used for dram initialization and should be
> called from board_init_f().
>
> Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>
> Changes in v3:
> - Reorganize patches such that each patch can be built individually
>
> Changes in v2:
> - capitalized acronym DRAM
>
> arch/riscv/cpu/jh7110/spl.c | 2 +-
> arch/riscv/include/asm/arch-jh7110/spl.h | 2 +-
> board/starfive/visionfive2/spl.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/riscv/cpu/jh7110/spl.c b/arch/riscv/cpu/jh7110/spl.c
> index 6bdf8b9c72..87aaf86524 100644
> --- a/arch/riscv/cpu/jh7110/spl.c
> +++ b/arch/riscv/cpu/jh7110/spl.c
> @@ -28,7 +28,7 @@ static bool check_ddr_size(phys_size_t size)
> }
> }
>
> -int spl_soc_init(void)
> +int spl_dram_init(void)
> {
> int ret;
> struct udevice *dev;
> diff --git a/arch/riscv/include/asm/arch-jh7110/spl.h b/arch/riscv/include/asm/arch-jh7110/spl.h
> index 23ce8871b3..d73355bf35 100644
> --- a/arch/riscv/include/asm/arch-jh7110/spl.h
> +++ b/arch/riscv/include/asm/arch-jh7110/spl.h
> @@ -7,6 +7,6 @@
> #ifndef _SPL_STARFIVE_H
> #define _SPL_STARFIVE_H
>
> -int spl_soc_init(void);
> +int spl_dram_init(void);
>
> #endif /* _SPL_STARFIVE_H */
> diff --git a/board/starfive/visionfive2/spl.c b/board/starfive/visionfive2/spl.c
> index 45848db6d8..ca61b5be22 100644
> --- a/board/starfive/visionfive2/spl.c
> +++ b/board/starfive/visionfive2/spl.c
> @@ -285,9 +285,9 @@ int spl_board_init_f(void)
>
> jh7110_jtag_init();
>
> - ret = spl_soc_init();
> + ret = spl_dram_init();
> if (ret) {
> - debug("JH7110 SPL init failed: %d\n", ret);
> + debug("JH7110 DRAM init failed: %d\n", ret);
> return ret;
> }
>
next prev parent reply other threads:[~2024-04-24 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 7:43 [PATCH v3 0/2] riscv: Rename spl_soc_init() to spl_dram_init() lukas.funke-oss
2024-04-24 7:43 ` [PATCH v3 1/2] board: sifive: " lukas.funke-oss
2024-04-26 7:51 ` Leo Liang
2024-04-24 7:43 ` [PATCH v3 2/2] board: starfive: " lukas.funke-oss
2024-04-24 11:01 ` Heinrich Schuchardt [this message]
2024-05-02 6:06 ` Lukas Funke
2024-05-02 6:33 ` Leo Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3707b3b7-8ded-4c97-93fe-491da21feb0f@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=aurelien@aurel32.net \
--cc=chanho61.park@samsung.com \
--cc=ganboing@gmail.com \
--cc=lucent@gmail.com \
--cc=lukas.funke-oss@weidmueller.com \
--cc=lukas.funke@weidmueller.com \
--cc=minda.chen@starfivetech.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=yangshiji66@outlook.com \
--cc=yanhong.wang@starfivetech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.