From: Tom Lendacky <thomas.lendacky@amd.com>
To: Peter Gonda <pgonda@google.com>
Cc: kvm list <kvm@vger.kernel.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH] KVM: SVM: Do not terminate SEV-ES guests on GHCB validation failure
Date: Mon, 17 May 2021 10:08:03 -0500 [thread overview]
Message-ID: <324d9228-03e9-0fe2-59c0-5e41e449211b@amd.com> (raw)
In-Reply-To: <CAMkAt6qJqTvM0PX+ja3rLP3toY-Rr4pSUbiFKL1GwzYZPG6f8g@mail.gmail.com>
On 5/14/21 6:06 PM, Peter Gonda wrote:
> On Fri, May 14, 2021 at 1:22 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> Currently, an SEV-ES guest is terminated if the validation of the VMGEXIT
>> exit code and parameters fail. Since the VMGEXIT instruction can be issued
>> from userspace, even though userspace (likely) can't update the GHCB,
>> don't allow userspace to be able to kill the guest.
>>
>> Return a #GP request through the GHCB when validation fails, rather than
>> terminating the guest.
>
> Is this a gap in the spec? I don't see anything that details what
> should happen if the correct fields for NAE are not set in the first
> couple paragraphs of section 4 'GHCB Protocol'.
No, I don't think the spec needs to spell out everything like this. The
hypervisor is free to determine its course of action in this case.
I suppose the spec could suggest a course of action, but I don't think the
spec should require a specific course of action.
Thanks,
Tom
>
next prev parent reply other threads:[~2021-05-17 15:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 19:22 [PATCH] KVM: SVM: Do not terminate SEV-ES guests on GHCB validation failure Tom Lendacky
2021-05-14 23:06 ` Peter Gonda
2021-05-17 15:08 ` Tom Lendacky [this message]
2021-05-20 19:16 ` Sean Christopherson
2021-05-20 19:27 ` Sean Christopherson
2021-05-20 20:22 ` Sean Christopherson
2021-05-20 21:04 ` Tom Lendacky
2021-05-20 20:57 ` Tom Lendacky
2021-05-27 17:22 ` Sean Christopherson
2021-07-21 12:32 ` Vitaly Kuznetsov
2021-07-21 20:09 ` Sean Christopherson
-- strict thread matches above, loose matches on Subject: below --
2021-12-02 18:52 Tom Lendacky
2021-12-02 19:19 ` Paolo Bonzini
2021-12-02 19:39 ` Tom Lendacky
2021-12-02 19:39 ` Paolo Bonzini
2021-12-03 16:39 ` Sean Christopherson
2021-12-03 18:59 ` Tom Lendacky
2021-12-03 19:22 ` Sean Christopherson
2021-12-03 22:46 ` Tom Lendacky
2021-12-04 5:14 ` Marc Orr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=324d9228-03e9-0fe2-59c0-5e41e449211b@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.