* [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
@ 2014-01-07 16:24 ` Emil Goode
0 siblings, 0 replies; 7+ messages in thread
From: Emil Goode @ 2014-01-07 16:24 UTC (permalink / raw
To: Eduardo Valentin, Zhang Rui, Len Brown, Rafael J. Wysocki
Cc: linux-acpi, linux-kernel, kernel-janitors, Emil Goode
The following commit introduced the requirement to not declare
thermal_zone_device_ops structs as const in order to allow
changing the .get_temp callback.
commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
Author: Eduardo Valentin <eduardo.valentin@ti.com>
Date: Wed Jul 3 15:35:39 2013 -0400
thermal: introduce device tree parser
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/acpi/thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 1fd21ad..8349a55 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
return acpi_thermal_cooling_device_cb(thermal, cdev, false);
}
-static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
+static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
.bind = acpi_thermal_bind_cooling_device,
.unbind = acpi_thermal_unbind_cooling_device,
.get_temp = thermal_get_temp,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
@ 2014-01-07 16:24 ` Emil Goode
0 siblings, 0 replies; 7+ messages in thread
From: Emil Goode @ 2014-01-07 16:24 UTC (permalink / raw
To: Eduardo Valentin, Zhang Rui, Len Brown, Rafael J. Wysocki
Cc: linux-acpi, linux-kernel, kernel-janitors, Emil Goode
The following commit introduced the requirement to not declare
thermal_zone_device_ops structs as const in order to allow
changing the .get_temp callback.
commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
Author: Eduardo Valentin <eduardo.valentin@ti.com>
Date: Wed Jul 3 15:35:39 2013 -0400
thermal: introduce device tree parser
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/acpi/thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 1fd21ad..8349a55 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
return acpi_thermal_cooling_device_cb(thermal, cdev, false);
}
-static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
+static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
.bind = acpi_thermal_bind_cooling_device,
.unbind = acpi_thermal_unbind_cooling_device,
.get_temp = thermal_get_temp,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
2014-01-07 16:24 ` Emil Goode
(?)
@ 2014-01-07 23:34 ` Eduardo Valentin
-1 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2014-01-07 23:34 UTC (permalink / raw
To: Emil Goode
Cc: Eduardo Valentin, Zhang Rui, Len Brown, Rafael J. Wysocki,
linux-acpi, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On 07-01-2014 12:24, Emil Goode wrote:
> The following commit introduced the requirement to not declare
> thermal_zone_device_ops structs as const in order to allow
> changing the .get_temp callback.
>
> commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> Author: Eduardo Valentin <eduardo.valentin@ti.com>
> Date: Wed Jul 3 15:35:39 2013 -0400
>
> thermal: introduce device tree parser
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/acpi/thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 1fd21ad..8349a55 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
> return acpi_thermal_cooling_device_cb(thermal, cdev, false);
> }
>
> -static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> +static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> .bind = acpi_thermal_bind_cooling_device,
> .unbind = acpi_thermal_unbind_cooling_device,
> .get_temp = thermal_get_temp,
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
@ 2014-01-07 23:34 ` Eduardo Valentin
0 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2014-01-07 23:34 UTC (permalink / raw
To: Emil Goode
Cc: Eduardo Valentin, Zhang Rui, Len Brown, Rafael J. Wysocki,
linux-acpi, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On 07-01-2014 12:24, Emil Goode wrote:
> The following commit introduced the requirement to not declare
> thermal_zone_device_ops structs as const in order to allow
> changing the .get_temp callback.
>
> commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> Author: Eduardo Valentin <eduardo.valentin@ti.com>
> Date: Wed Jul 3 15:35:39 2013 -0400
>
> thermal: introduce device tree parser
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/acpi/thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 1fd21ad..8349a55 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
> return acpi_thermal_cooling_device_cb(thermal, cdev, false);
> }
>
> -static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> +static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> .bind = acpi_thermal_bind_cooling_device,
> .unbind = acpi_thermal_unbind_cooling_device,
> .get_temp = thermal_get_temp,
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
@ 2014-01-07 23:34 ` Eduardo Valentin
0 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2014-01-07 23:34 UTC (permalink / raw
To: Emil Goode
Cc: Eduardo Valentin, Zhang Rui, Len Brown, Rafael J. Wysocki,
linux-acpi, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On 07-01-2014 12:24, Emil Goode wrote:
> The following commit introduced the requirement to not declare
> thermal_zone_device_ops structs as const in order to allow
> changing the .get_temp callback.
>
> commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> Author: Eduardo Valentin <eduardo.valentin@ti.com>
> Date: Wed Jul 3 15:35:39 2013 -0400
>
> thermal: introduce device tree parser
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/acpi/thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 1fd21ad..8349a55 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_zone_device *thermal,
> return acpi_thermal_cooling_device_cb(thermal, cdev, false);
> }
>
> -static const struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> +static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> .bind = acpi_thermal_bind_cooling_device,
> .unbind = acpi_thermal_unbind_cooling_device,
> .get_temp = thermal_get_temp,
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
2014-01-07 23:34 ` Eduardo Valentin
@ 2014-01-08 23:07 ` Rafael J. Wysocki
-1 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2014-01-08 22:54 UTC (permalink / raw
To: Eduardo Valentin
Cc: Emil Goode, Zhang Rui, Len Brown, linux-acpi, linux-kernel,
kernel-janitors
On Tuesday, January 07, 2014 07:34:03 PM Eduardo Valentin wrote:
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: quoted-printable
>
> On 07-01-2014 12:24, Emil Goode wrote:
> > The following commit introduced the requirement to not declare
> > thermal_zone_device_ops structs as const in order to allow
> > changing the .get_temp callback.
> >
> > commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> > Author: Eduardo Valentin <eduardo.valentin@ti.com>
> > Date: Wed Jul 3 15:35:39 2013 -0400
> >
> > thermal: introduce device tree parser
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
Queued up for 3.14, thanks!
> > ---
> > drivers/acpi/thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> > index 1fd21ad..8349a55 100644
> > --- a/drivers/acpi/thermal.c
> > +++ b/drivers/acpi/thermal.c
> > @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_z> one_device *thermal,
> > return acpi_thermal_cooling_device_cb(thermal, cdev, false);
> > }
> >
> > -static const struct thermal_zone_device_ops acpi_thermal_zone_ops = > {
> > +static struct thermal_zone_device_ops acpi_thermal_zone_ops = {
> > .bind = acpi_thermal_bind_cooling_device,
> > .unbind = acpi_thermal_unbind_cooling_device,
> > .get_temp = thermal_get_temp,
> >
>
>
> --
> You have got to be excited about what you are doing. (L. Lamport)
>
> Eduardo Valentin
>
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk
> Content-Type: application/pgp-signature; name="signature.asc"
> Content-Description: OpenPGP digital signature
> Content-Disposition: attachment; filename="signature.asc"
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iF4EAREIAAYFAlLMjvIACgkQCXcVR3XQvP3L6gD7B2J7f2SUQuZhpShZH/GNtjUm
> 66MHYjXagUB6rDRkCAQA/3/Hh35+smtAZvxKm/IX45BOmyC/z3qMulmA6Alsy52I
> =Cuu1
> -----END PGP SIGNATURE-----
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk--
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration
@ 2014-01-08 23:07 ` Rafael J. Wysocki
0 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2014-01-08 23:07 UTC (permalink / raw
To: Eduardo Valentin
Cc: Emil Goode, Zhang Rui, Len Brown, linux-acpi, linux-kernel,
kernel-janitors
On Tuesday, January 07, 2014 07:34:03 PM Eduardo Valentin wrote:
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: quoted-printable
>
> On 07-01-2014 12:24, Emil Goode wrote:
> > The following commit introduced the requirement to not declare
> > thermal_zone_device_ops structs as const in order to allow
> > changing the .get_temp callback.
> >=20
> > commit 4e5e4705bf69ea450f58fc709ac5888f321a9299
> > Author: Eduardo Valentin <eduardo.valentin@ti.com>
> > Date: Wed Jul 3 15:35:39 2013 -0400
> >=20
> > thermal: introduce device tree parser
> >=20
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
Queued up for 3.14, thanks!
> > ---
> > drivers/acpi/thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> > index 1fd21ad..8349a55 100644
> > --- a/drivers/acpi/thermal.c
> > +++ b/drivers/acpi/thermal.c
> > @@ -861,7 +861,7 @@ acpi_thermal_unbind_cooling_device(struct thermal_z=
> one_device *thermal,
> > return acpi_thermal_cooling_device_cb(thermal, cdev, false);
> > }
> > =20
> > -static const struct thermal_zone_device_ops acpi_thermal_zone_ops =3D =
> {
> > +static struct thermal_zone_device_ops acpi_thermal_zone_ops =3D {
> > .bind =3D acpi_thermal_bind_cooling_device,
> > .unbind =3D acpi_thermal_unbind_cooling_device,
> > .get_temp =3D thermal_get_temp,
> >=20
>
>
> --=20
> You have got to be excited about what you are doing. (L. Lamport)
>
> Eduardo Valentin
>
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk
> Content-Type: application/pgp-signature; name="signature.asc"
> Content-Description: OpenPGP digital signature
> Content-Disposition: attachment; filename="signature.asc"
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iF4EAREIAAYFAlLMjvIACgkQCXcVR3XQvP3L6gD7B2J7f2SUQuZhpShZH/GNtjUm
> 66MHYjXagUB6rDRkCAQA/3/Hh35+smtAZvxKm/IX45BOmyC/z3qMulmA6Alsy52I
> =Cuu1
> -----END PGP SIGNATURE-----
>
> --d38TXoq0sN4NKSKSmrSA0nrfhHhs3Hefk--
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-08 22:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 16:24 [PATCH] ACPI: thermal: remove const from thermal_zone_device_ops declaration Emil Goode
2014-01-07 16:24 ` Emil Goode
2014-01-07 23:34 ` Eduardo Valentin
2014-01-07 23:34 ` Eduardo Valentin
2014-01-07 23:34 ` Eduardo Valentin
2014-01-08 22:54 ` Rafael J. Wysocki
2014-01-08 23:07 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.