From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy@kernel.org>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false
Date: Mon, 29 Apr 2024 12:38:50 +0300 (EEST) [thread overview]
Message-ID: <2fb26061-6da6-ae4d-05e2-322eef9e47a2@linux.intel.com> (raw)
In-Reply-To: <20240429093446.130322-1-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
On Mon, 29 Apr 2024, Hans de Goede wrote:
> acpi_send_ev is a bool and everywhere else true/false is used
> to set it. Replace the one instance using 0 with false.
>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 7e2288009063..e2e6c4d3dff7 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3912,7 +3912,7 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 event)
> if (tp_features.hotkey_wlsw &&
> hkey == TP_HKEY_EV_RFKILL_CHANGED) {
> tpacpi_send_radiosw_update();
> - send_acpi_ev = 0;
> + send_acpi_ev = false;
> known_ev = true;
> }
> break;
>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-04-29 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 9:34 [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false Hans de Goede
2024-04-29 9:38 ` Ilpo Järvinen [this message]
2024-04-29 10:03 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fb26061-6da6-ae4d-05e2-322eef9e47a2@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.